public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] linux-custom: add -e option to postinstall script
@ 2025-10-27  7:28 srinuvasan.a via isar-users
  2025-11-03 11:06 ` Zhihang Wei
  0 siblings, 1 reply; 2+ messages in thread
From: srinuvasan.a via isar-users @ 2025-10-27  7:28 UTC (permalink / raw)
  To: isar-users; +Cc: Srinuvasan A

From: Srinuvasan A <srinuvasan.a@siemens.com>

While inspecting the kernel package, a warning was observed related
to the postinstall script. It appears the script was not using the
`-e` option, which ensures the script stops immediately upon any error.

To fix this warning, add the -e option to the postinstall script,
similar to how other maintainer scripts have it.

Logs:
W: linux-image-cip: maintainer-script-ignores-errors [postinst]

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 .../recipes-kernel/linux/files/debian/linux-image.postinst.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux/files/debian/linux-image.postinst.tmpl b/meta/recipes-kernel/linux/files/debian/linux-image.postinst.tmpl
index 3a0d281d..72718a2c 100644
--- a/meta/recipes-kernel/linux/files/debian/linux-image.postinst.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/linux-image.postinst.tmpl
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh -e
 # based on https://salsa.debian.org/kernel-team/linux/blob/479cb120ecb2b3f2c4d929a7b57860248d6f79bd/debian/templates/image.postinst.in
 # SPDX-License-Identifier: GPL-2.0-only
 
-- 
2.34.1

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251027072854.96296-1-srinuvasan.a%40siemens.com.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] linux-custom: add -e option to postinstall script
  2025-10-27  7:28 [PATCH] linux-custom: add -e option to postinstall script srinuvasan.a via isar-users
@ 2025-11-03 11:06 ` Zhihang Wei
  0 siblings, 0 replies; 2+ messages in thread
From: Zhihang Wei @ 2025-11-03 11:06 UTC (permalink / raw)
  To: srinuvasan.a, isar-users

Applied to next, thanks.

On 10/27/25 08:28, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> While inspecting the kernel package, a warning was observed related
> to the postinstall script. It appears the script was not using the
> `-e` option, which ensures the script stops immediately upon any error.
>
> To fix this warning, add the -e option to the postinstall script,
> similar to how other maintainer scripts have it.
>
> Logs:
> W: linux-image-cip: maintainer-script-ignores-errors [postinst]
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>   .../recipes-kernel/linux/files/debian/linux-image.postinst.tmpl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/linux/files/debian/linux-image.postinst.tmpl b/meta/recipes-kernel/linux/files/debian/linux-image.postinst.tmpl
> index 3a0d281d..72718a2c 100644
> --- a/meta/recipes-kernel/linux/files/debian/linux-image.postinst.tmpl
> +++ b/meta/recipes-kernel/linux/files/debian/linux-image.postinst.tmpl
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/sh -e
>   # based on https://salsa.debian.org/kernel-team/linux/blob/479cb120ecb2b3f2c4d929a7b57860248d6f79bd/debian/templates/image.postinst.in
>   # SPDX-License-Identifier: GPL-2.0-only
>   

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/6f2ffc3a-99df-49d0-bb9a-a555bdf23383%40ilbers.de.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-03 11:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-27  7:28 [PATCH] linux-custom: add -e option to postinstall script srinuvasan.a via isar-users
2025-11-03 11:06 ` Zhihang Wei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox