From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6976277815930912768 X-Received: by 2002:a1c:544f:: with SMTP id p15mr703705wmi.51.1624363754810; Tue, 22 Jun 2021 05:09:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:a141:: with SMTP id r1ls875771wrr.3.gmail; Tue, 22 Jun 2021 05:09:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygOOylC6dW5Gc2hmyV4f50quLD3arPb4pDmwY2WA4uZ6nZX1fYEnjscCrPDViY94Ghix90 X-Received: by 2002:a5d:6992:: with SMTP id g18mr4337688wru.73.1624363754069; Tue, 22 Jun 2021 05:09:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624363754; cv=none; d=google.com; s=arc-20160816; b=f/yqNKy8uWtFFyB8Z31F26QmW+dx6qMzx/CvrPZuqlGIh70DJEt0KH+/h85fOosgOK d3+EV9QplIBfB3C8s2zdWM9xpKDITu8DBLO6sBM2bX2Sm3ggMMxUfwIf6+/EkYYNBk83 fYY/zu9o+skKciSasHQyCfJaa4/v1y52IXKIYrdGVoKGBUbhPY9G2DfjaM6KtGANZmp/ GNRxlmoq6XdRYtaPoQC9uDWPfLsheWgDr7eXNPbJ6t7JgQUllZYFpnoccgLbMLt5iYQr qQhd9W0jwKyMW8F4P1Lif7K7WgLGdKypPtLHaDnu0QwqPSrpQ5yGFGqnPZ5SzlPfWCGz VPWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id:dkim-signature; bh=BhUGDCUWfCjA8I4g5QJ8sEteGzeI+1wSEEZc1l3BbnM=; b=ClNIkKzuSgbD/HMb2Q4V9neDtoEc74hq0t0kPEIU3QwqXg24POEpAnXFcL7N9aJGHi 2AEu720Fh9FSp9O6LHeR3ZUspN5lDPHAvVrQsACCIRzYrmxGwKOCZ0gP0Zsv1BRvN50m vEk/aPQFNQgTSjnyWphyTvlhXDeLv6CGYL7zXQgXzAgOmijREuYrjtXclOH3puF287wT V9zqsnGw++zdtHnB8ZRczy0sE77+FyoaCgtxGlxVNeUrvM1fWFXyaVQYgeP9imoj1OJd SrNBxoPAGXc6gQhd8tYOX+ges5owT6/Y/gl/Fu6/7VgIB1Km/zlMqNbZgFCiCklj+lox qUNQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=cIO+qbbH; spf=pass (google.com: domain of hws@denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=hws@denx.de Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gmr-mx.google.com with ESMTPS id c4si170276wml.4.2021.06.22.05.09.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 05:09:13 -0700 (PDT) Received-SPF: pass (google.com: domain of hws@denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=cIO+qbbH; spf=pass (google.com: domain of hws@denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=hws@denx.de Received: from [10.0.40.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: hws@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6BADB800C1; Tue, 22 Jun 2021 14:09:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1624363753; bh=BhUGDCUWfCjA8I4g5QJ8sEteGzeI+1wSEEZc1l3BbnM=; h=Subject:From:To:Date:In-Reply-To:References:From; b=cIO+qbbHEHdkdv7ahOZZK+omakGUYNlrarJhSziz48Yh0MwFj1I0rM3ZqkV6KqUmi DH6KQE3UopWeXqPRYm1wW+G6jto/zBTnscDcA9YCSY9XhvXXTPj7mk2S4zSZFH/UnU MxcuLCzaLAj84LSpZo3iYNSxVhvB9lpirxb9BlDCWrHQjvcgaz3qCIHfR1H/DNj9nO uq0bm1xw1zGQR910p9zA1AkvMiFdSKTgTtWDNE4xCP5WIlxbhcwJ6S4An7Nsvwp4oD Bc1AgfnFnOrFYyq6TjhGCV5Lkc3/H5RapnxR1giKAWcowaOPqgckj14kM2nxNb+HM5 Xc4a9kXMxZsMQ== Message-ID: <6f4646f9746d604028d8d876a4f480a7c3503fe3.camel@denx.de> Subject: Re: [PATCH] u-boot: Use new makefile target for u-boot-initial-env where available From: Harald Seiler To: Jan Kiszka , isar-users Date: Tue, 22 Jun 2021 14:09:13 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-TUID: lHhcoC1f1Ko1 Hi, On Mon, 2021-06-21 at 18:00 +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Since 2019.07, u-boot-initial-env is available as build target. Latest > U-Boot has troubles running the get_default_envs.sh script, so better > switch to the official target where available. > > Signed-off-by: Jan Kiszka > --- >  meta/recipes-bsp/u-boot/files/debian/rules | 8 ++++++-- >  1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-bsp/u-boot/files/debian/rules b/meta/recipes-bsp/u-boot/files/debian/rules > index 85bda91..a5c2cd2 100755 > --- a/meta/recipes-bsp/u-boot/files/debian/rules > +++ b/meta/recipes-bsp/u-boot/files/debian/rules > @@ -3,7 +3,7 @@ >  # Debian rules for custom U-Boot build >  # >  # This software is a part of ISAR. > -# Copyright (c) Siemens AG, 2018 > +# Copyright (c) Siemens AG, 2018-2021 >  # >  # SPDX-License-Identifier: MIT >   > > @@ -15,7 +15,11 @@ endif >  override_dh_auto_build: >   $(MAKE) $(PARALLEL_MAKE) $(U_BOOT_CONFIG) >   $(MAKE) $(PARALLEL_MAKE) ${U_BOOT_BIN} > - ./scripts/get_default_envs.sh >u-boot-initial-env > + $(MAKE) -n u-boot-initial-env >/dev/null 2>&1; if [ $$? -ne 2 ]; then \ > + $(MAKE) $(PARALLEL_MAKE) u-boot-initial-env; \ > + else \ > + ./scripts/get_default_envs.sh >u-boot-initial-env; \ > + fi >   $(MAKE) $(PARALLEL_MAKE) $(SET_CROSS_BUILD_TOOLS) NO_SDL=1 tools-only envtools >   > >  override_dh_auto_install: > -- > 2.26.2 There is a slight difference between the two versions (why are there two?!), where get_default_envs.sh sorts the env entries while the make target does not. I do not think this should matter here, though. Reviewed-by: Harald Seiler