From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6515090200378474496 Date: Sun, 4 Feb 2018 00:08:49 -0800 (PST) From: chombourger@gmail.com To: isar-users Message-Id: <6f48f86e-ade5-46f5-a2f7-05a8eecfbbdf@googlegroups.com> In-Reply-To: <1615cbef938.27ac.034a6b0541ed39b7fb4e17f4ac219eaa@ilbers.de> References: <20180125203655.6894-1-Cedric_Hombourger@mentor.com> <4e857783-a4ae-7649-523c-ae277fef6bab@ilbers.de> <20180129165954.404a1ab8@mmd1pvb1c.ad001.siemens.net> <4dd8dbf0-92b3-891f-4012-f1bb19560ed3@ilbers.de> <1615cbef938.27ac.034a6b0541ed39b7fb4e17f4ac219eaa@ilbers.de> Subject: Re: [PATCH 0/1] avoid user prompts when mk-build-deps is called MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_608_829482034.1517731729651" X-Google-Token: EJH_2tMFJ_QDlU1wk1Q0 X-Google-IP: 81.14.33.59 X-TUID: xokIIT82IVx2 ------=_Part_608_829482034.1517731729651 Content-Type: multipart/alternative; boundary="----=_Part_609_1184739928.1517731729652" ------=_Part_609_1184739928.1517731729652 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable You're welcome and thank you! (BTW: it does not look like you have pushed your updated "next" branch to= =20 GitHub -- no rush though) Cedric On Saturday, February 3, 2018 at 6:37:47 PM UTC+1, Alexander Smirnov wrote: > > Hi,=20 > > chomb...@gmail.com 3 =D1=84=D0=B5=D0=B2=D1=80=D0=B0=D0=BB= =D1=8F 2018 =D0=B3. 12:49:41 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:=20 > > > Hi Alex,=20 > >=20 > > A simple test case to demonstrate the issue consists in adding=20 > libpci-dev=20 > > as a build dependency to example-hello=20 > > I have forked and modified hello for this purpose and modifed the recip= e=20 > as=20 > > follows:=20 > >=20 > > diff --git a/meta-isar/recipes-app/example-hello/example-hello.bb=20 > > b/meta-isar/recipes-app/example-hello/example-hello.bb=20 > > index 602a11e..af87428 100644=20 > > --- a/meta-isar/recipes-app/example-hello/example-hello.bb=20 > > +++ b/meta-isar/recipes-app/example-hello/example-hello.bb=20 > > @@ -10,8 +10,8 @@ LIC_FILES_CHKSUM =3D=20 > > "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=3D751419260=20 > >=20 > > PV =3D "0.2+7bf716d2"=20 > >=20 > > -SRC_URI =3D "git://github.com/ilbers/hello.git;protocol=3Dhttps"=20 > > -SRCREV =3D "7bf716d22dbdb5a83edf0fe6134c0500f1a8b1f0"=20 > > +SRC_URI =3D "git://github.com/chombourger/hello.git;protocol=3Dhttps"= =20 > > +SRCREV =3D "3f05efe8cd471ce0313b5de6ea992c4a46e0e647"=20 > >=20 > > SRC_DIR =3D "git"=20 > >=20 > > If I bitbake example-hello, do_build will fail. The log will show:=20 > >=20 > > The following NEW packages will be installed:=20 > > libpci-dev libpci3 zlib1g-dev=20 > > 0 upgraded, 3 newly installed, 0 to remove and 0 not upgraded.=20 > > 1 not fully installed or removed.=20 > > Need to get 317 kB of archives.=20 > > After this operation, 703 kB of additional disk space will be used.=20 > > Do you want to continue? [Y/n] Abort.=20 > >=20 > > We get an "Abort" because we do not have a stdin when building from=20 > bitbake.=20 > >=20 > > Hope this helps=20 > > Sure, thank you for the explanation!=20 > > BTW: applied to next.=20 > > >=20 > > Cedric=20 > >=20 > > On Monday, January 29, 2018 at 5:15:01 PM UTC+1, Alexander Smirnov=20 > wrote:=20 > >>=20 > >> On 01/29/2018 06:59 PM, Henning Schild wrote:=20 > >> > Am Mon, 29 Jan 2018 16:49:51 +0300=20 > >> > schrieb Alexander Smirnov >:=20 > >> >=20 > >> >> Hello Cedric,=20 > >> >>=20 > >> >> On 01/25/2018 11:36 PM, Cedric_H...@mentor.com wrote:= =20 > >> >>> From: Cedric Hombourger >=20 > >> >>>=20 > >> >>> commit 498b128 caused build dependencies to be installed via=20 > >> >>> mk-build-deps.=20 > >> >>>> The tool may ask the user to confirm their installation but=20 > >> >>>> would=20 > >> >> fail when=20 > >> >>=20 > >> >> Do you know in which circumstances this could happen?=20 > >> >=20 > >> > Basically whenever apt-get decides to become interactive and wants t= o=20 > >>=20 > >> I do understand what this patch does. My question is exactly when=20 > >> "whenever" really happens. I've noticed such behavior several times fo= r=20 > >> different Debian tools, but it would be nice eventually to understand= =20 > >> this kind of magic.=20 > >>=20 > >> BTW: for me it's not the point to block this patch.=20 > >>=20 > >> Alex=20 > >>=20 > >> > ask for confirmation. My patch removed an "apt-get ... -y" while the= =20 > >> > "-y" should have stayed.=20 > >> >=20 > >> > Henning=20 > >> >=20 > >> >> Alex=20 > >> >>=20 > >> >>> called from bitbake (no stdin). Override the default install=20 > >> >>> command to add the -y switch (assume yes).=20 > >> >>>=20 > >> >>> Cedric Hombourger (1):=20 > >> >>> build.sh: eliminate potential prompts from=20 > mk-build-deps/apt-get=20 > >> >>>=20 > >> >>> meta/recipes-devtools/buildchroot/files/build.sh | 5 ++++-=20 > >> >>> 1 file changed, 4 insertions(+), 1 deletion(-)=20 > >> >>>=20 > >> >>=20 > >> >=20 > >>=20 > >=20 > > --=20 > > You received this message because you are subscribed to the Google=20 > Groups=20 > > "isar-users" group.=20 > > To unsubscribe from this group and stop receiving emails from it, send= =20 > an=20 > > email to isar-users+...@googlegroups.com .=20 > > To post to this group, send email to isar-...@googlegroups.com=20 > .=20 > > To view this discussion on the web visit=20 > >=20 > https://groups.google.com/d/msgid/isar-users/d7821b41-5b3e-4b7a-b5cb-0893= 8945ac8a%40googlegroups.com.=20 > > > For more options, visit https://groups.google.com/d/optout.=20 > -=20 > > > ------=_Part_609_1184739928.1517731729652 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
You're welcome and thank you!
(BTW: it does not loo= k like you have pushed your updated "next" branch to GitHub -- no= rush though)

Cedric

On Saturday, February 3, 2018 at 6:37:47= PM UTC+1, Alexander Smirnov wrote:
Hi,

c= homb...@gmail.com 3 =D1=84=D0=B5=D0=B2=D1=80=D0=B0=D0=BB=D1=8F 2018 =D0= =B3. 12:49:41 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:

> Hi Alex,
>
> A simple test case to demonstrate the issue consists in adding lib= pci-dev
> as a build dependency to example-hello
> I have forked and modified hello for this purpose and modifed the = recipe as
> follows:
>
> diff --git a/meta-isar/recipes-app/example-hello/example-hello.bb
> b/meta-isar/recipes-app/example-hello/example-hello.bb
> index 602a11e..af87428 100644
> --- a/meta-isar/recipes-app/example-hello/example-hello.bb
> +++ b/meta-isar/recipes-app/example-hello/example-hello.bb
> @@ -10,8 +10,8 @@ LIC_FILES_CHKSUM =3D
> "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=3D751419260
>
> =C2=A0PV =3D "0.2+7bf716d2"
>
> -SRC_URI =3D "git://github.com/ilbers/hello.git;protocol= =3Dhttps"
> -SRCREV =3D "7bf716d22dbdb5a83edf0fe6134c0500f1a8b1= f0"
> +SRC_URI =3D "git://github.com/chombourger/hello.git;protocol=3Dhttps"
> +SRCREV =3D "3f05efe8cd471ce0313b5de6ea992c4a46e0e6= 47"
>
> =C2=A0SRC_DIR =3D "git"
>
> If I bitbake example-hello, do_build will fail. The log will show:
>
> The following NEW packages will be installed:
> =C2=A0 libpci-dev libpci3 zlib1g-dev
> 0 upgraded, 3 newly installed, 0 to remove and 0 not upgraded.
> 1 not fully installed or removed.
> Need to get 317 kB of archives.
> After this operation, 703 kB of additional disk space will be used= .
> Do you want to continue? [Y/n] Abort.
>
> We get an "Abort" because we do not have a stdin when bu= ilding from bitbake.
>
> Hope this helps

Sure, thank you for the explanation!

BTW: applied to next.

>
> Cedric
>
> On Monday, January 29, 2018 at 5:15:01 PM UTC+1, Alexander Smirnov= wrote:
>>
>> On 01/29/2018 06:59 PM, Henning Schild wrote:
>> > Am Mon, 29 Jan 2018 16:49:51 +0300
>> > schrieb Alexander Smirnov <asmi...@ilbers.de &l= t;javascript:>>:
>> >
>> >> Hello Cedric,
>> >>
>> >> On 01/25/2018 11:36 PM, Cedric_H...@mentor.com= <javascript:> wrote:
>> >>> From: Cedric Hombourger <Cedric_H...@mentor= .com <javascript:>>
>> >>>
>> >>> commit 498b128 caused build dependencies to be in= stalled via
>> >>> mk-build-deps.
>> >>>> The tool may ask the user to confirm their in= stallation but
>> >>>> would
>> >> fail when
>> >>
>> >> Do you know in which circumstances this could happen?
>> >
>> > Basically whenever apt-get decides to become interactive = and wants to
>>
>> I do understand what this patch does. My question is exactly w= hen
>> "whenever" really happens. I've noticed such beh= avior several times for
>> different Debian tools, but it would be nice eventually to und= erstand
>> this kind of magic.
>>
>> BTW: for me it's not the point to block this patch.
>>
>> Alex
>>
>> > ask for confirmation. My patch removed an "apt-get .= .. -y" while the
>> > "-y" should have stayed.
>> >
>> > Henning
>> >
>> >> Alex
>> >>
>> >>> called from bitbake (no stdin). Override the defa= ult install
>> >>> command to add the -y switch (assume yes).
>> >>>
>> >>> Cedric Hombourger (1):
>> >>> =C2=A0 =C2=A0 build.sh: eliminate potential promp= ts from mk-build-deps/apt-get
>> >>>
>> >>> =C2=A0 =C2=A0meta/recipes-devtools/buildchro= ot/files/build.sh | 5 ++++-
>> >>> =C2=A0 =C2=A01 file changed, 4 insertions(+), 1 d= eletion(-)
>> >>>
>> >>
>> >
>>
>
> --
> You received this message because you are subscribed to the Google= Groups=20
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, = send an=20
> email to isar-users+...@googlegroups.com.
> To post to this group, send email to isar-...@googlegroups.com.
> To view this discussion on the web visit=20
> https://groups.google.com/d/msgid/isar-users/d7821b41-5b3e= -4b7a-b5cb-08938945ac8a%40googlegroups.com.
> For more options, visit https://groups.go= ogle.com/d/optout.
-


------=_Part_609_1184739928.1517731729652-- ------=_Part_608_829482034.1517731729651--