From: Anton Mikanovich <amikan@ilbers.de>
To: Henning Schild <henning.schild@siemens.com>
Cc: isar-users@googlegroups.com, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v4 5/5] events: Do not warn on left mounts by default
Date: Tue, 17 Aug 2021 15:36:19 +0300 [thread overview]
Message-ID: <6fe27e08-e5f7-d9a8-5122-d8039943408a@ilbers.de> (raw)
In-Reply-To: <20210816175331.2e990e44@md1za8fc.ad001.siemens.net>
16.08.2021 18:53, Henning Schild wrote:
> Can we find something more generic to attach to? Something that
> represents verbose logging / debug tracing in general? We can not
> invent a new variable for every aspect we want to debug. Could also
> just comment that out ... to have it back handy for someone having to
> debug.
>
> Henning
As Jan already mentioned, originally this supposed to be something to be
always on to take care about the right mount API usage.
But currently we have other places where covering mounts with
try-finally require huge rewriting all that tasks in Python which will
break the compatibility. That's why additional debug messages will
appear for all the failures outside do_dpkg_build but inside mount sections.
Commenting this code out is not a good way if we need to have it
configured from outside (f.e. by CI). I've moved those printouts from
warning to debug in v5, so it will be available with all other debug
information (enabled by -D).
--
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
prev parent reply other threads:[~2021-08-17 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 15:37 [PATCH v4 0/5] Restore downstream mounts compatibility Anton Mikanovich
2021-08-16 15:37 ` [PATCH v4 1/5] Revert "dpkg: Make mount buildroot reliable" Anton Mikanovich
2021-08-16 15:37 ` [PATCH v4 2/5] dpkg: Limit unmount loop Anton Mikanovich
2021-08-16 16:09 ` Henning Schild
2021-08-16 15:37 ` [PATCH v4 3/5] image: Add reference counter Anton Mikanovich
2021-08-16 15:37 ` [PATCH v4 4/5] dpkg-base: Clean up unmounting in do_dpkg_build() Anton Mikanovich
2021-08-16 15:37 ` [PATCH v4 5/5] events: Do not warn on left mounts by default Anton Mikanovich
2021-08-16 15:53 ` Henning Schild
2021-08-16 16:53 ` Jan Kiszka
2021-08-17 12:36 ` Anton Mikanovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fe27e08-e5f7-d9a8-5122-d8039943408a@ilbers.de \
--to=amikan@ilbers.de \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox