From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6997052726746021888 X-Received: by 2002:a1c:a5d4:: with SMTP id o203mr3169183wme.106.1629203786935; Tue, 17 Aug 2021 05:36:26 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:988b:: with SMTP id a133ls925688wme.3.gmail; Tue, 17 Aug 2021 05:36:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwakPF7td+J8XfrYwsdXXJmb3x+5kBpHGzyPJYW6FOwwgTWBYgPX7GZeoU/N+mI/Fo2E75 X-Received: by 2002:a1c:1f17:: with SMTP id f23mr3202582wmf.136.1629203786052; Tue, 17 Aug 2021 05:36:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629203786; cv=none; d=google.com; s=arc-20160816; b=IuA7lprj/Ljkf5pQZKV9qYnAIItRaTVrRcAqHLu92DjkzeU8HiLLvXsIEgXVqpZRhi y8pOFJYvr7O+LPhaFpdKBAcDUvq8nScDoONE9Gm0xcbhLhcF6jhCWLcOsQmKPvq5RabR CQ4okv0aIWj4vXyASOu2sn4iD2LfefGuFL3AKpp4JOPZpa8+xkM32/W2Im3VSEFoIyOZ UIaAb6JeKeb/X7ne6gCUv7JSMrtR9U/OYXmz+B37B3gmOLqczDrGrGXB0GEDPRll6D19 TwMCRQeINAfUA+5t9CVHA80gRCHug/3ueqeW8R4l5LLJ6bt3b9eomZMK7rEMLN0fFP0+ ue9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=V0/x9onn9iJoS8fFJzTcl0Cy8eNHkFz4FG0MrdtCf0c=; b=kPan+R9MNH+oGjC1fZqgYSM7ua7FcMbNnpXcah591EsOHItQeGEw/6p9CYjRijn2RA nF+YFYDCmrAbCYwkM7qU4od81ony1nnzJaXyCoXjZlUUB9L2tSv+US3rFCfOBQGJanB6 R0kQ93xNrStbNjxOD3hyJ50BGGtlY2u9zARfBWvb1BoDuUrdKurVF5GseFM/ifZetWyJ n9RdA7BOl0HzGUuibjKGk9Qjfp45se+50ceA9HUH8Ytcx4fbrx39E1S23fgmxu0j0rY5 e5dUGhHcQoPK7dcpeRvP9hlaBpH73+HeVcP+mDlC2bPZqUf5PmGuiHBbLjDY8SpLlGKs nhtQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id g17si121102wmg.2.2021.08.17.05.36.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Aug 2021 05:36:25 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-146-26-214-37.mgts.dynamic.pppoe.byfly.by [37.214.26.146] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 17HCaOYi008245 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Aug 2021 14:36:25 +0200 Subject: Re: [PATCH v4 5/5] events: Do not warn on left mounts by default To: Henning Schild Cc: isar-users@googlegroups.com, Jan Kiszka References: <20210816153756.3549038-1-amikan@ilbers.de> <20210816153756.3549038-6-amikan@ilbers.de> <20210816175331.2e990e44@md1za8fc.ad001.siemens.net> From: Anton Mikanovich Message-ID: <6fe27e08-e5f7-d9a8-5122-d8039943408a@ilbers.de> Date: Tue, 17 Aug 2021 15:36:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210816175331.2e990e44@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: ypIvfo7iQ4hI 16.08.2021 18:53, Henning Schild wrote: > Can we find something more generic to attach to? Something that > represents verbose logging / debug tracing in general? We can not > invent a new variable for every aspect we want to debug. Could also > just comment that out ... to have it back handy for someone having to > debug. > > Henning As Jan already mentioned, originally this supposed to be something to be always on to take care about the right mount API usage. But currently we have other places where covering mounts with try-finally require huge rewriting all that tasks in Python which will break the compatibility. That's why additional debug messages will appear for all the failures outside do_dpkg_build but inside mount sections. Commenting this code out is not a good way if we need to have it configured from outside (f.e. by CI). I've moved those printouts from warning to debug in v5, so it will be available with all other debug information (enabled by -D). -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov