[PATCH v2 0/1] ci: make vm_start logs readable by all users

[PATCH v2 0/1] ci: make vm_start logs readable by all users

[Uladzimir Bely]

Changes since v1:
- updated commit message

The patch modifies permissions for VM boot logs to make them readable
not only by CI user.

Separate 'chmod' is required because python functions in 'tempfile'
module always use 0600 rights for files/directories they create and
this can't be changes by their interfaces.

Uladzimir Bely (1):
  ci: make vm_start logs readable by all users

 testsuite/vm_boot_test/vm_boot_test.py | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

[PATCH v2 1/1] ci: make vm_start logs readable by all users

[Uladzimir Bely]

This changes permissions for ${BUILD_DIR}/vm_start_.*_log.txt to 644
to make them readable not only by CI user.

Virtual machine boot log files have 0600 permissions by default. This is
a feature of all functions from Python's 'tempfile' module used.

The only way to change permissions is using a particular call of 'chmod'.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 testsuite/vm_boot_test/vm_boot_test.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testsuite/vm_boot_test/vm_boot_test.py b/testsuite/vm_boot_test/vm_boot_test.py
index 01623c5c..69e7f4ae 100644
--- a/testsuite/vm_boot_test/vm_boot_test.py
+++ b/testsuite/vm_boot_test/vm_boot_test.py
@@ -46,6 +46,7 @@ class VmBase(Test):
         fd, output_file = tempfile.mkstemp(suffix='_log.txt',
                                            prefix='vm_start_' + distro + '_' +
                                            arch + '_', dir=build_dir, text=True)
+        os.chmod(output_file, 0o644)
 
         cmdline = start_vm.format_qemu_cmdline(arch, build_dir, distro,
                                                output_file, None)
-- 
2.20.1

Re: [PATCH v2 0/1] ci: make vm_start logs readable by all users

[Anton Mikanovich]

12.01.2022 15:42, Uladzimir Bely wrote:
> Changes since v1:
> - updated commit message
>
> The patch modifies permissions for VM boot logs to make them readable
> not only by CI user.
>
> Separate 'chmod' is required because python functions in 'tempfile'
> module always use 0600 rights for files/directories they create and
> this can't be changes by their interfaces.
>
> Uladzimir Bely (1):
>    ci: make vm_start logs readable by all users
>
>   testsuite/vm_boot_test/vm_boot_test.py | 1 +
>   1 file changed, 1 insertion(+)
>
Applied to next, thanks.