Re: [PATCH v6 4/5] Provide include file for easy custom module builds

[Alexander Smirnov <asmirnov@ilbers.de>]

On 02/15/2018 10:35 AM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This provides an include for custom kernel modules. We choose an include
> over a class as we carry a couple of files to debianize the module. The
> user just needs to specify the module SRC_URI, and those sources must be
> then reside in a separate directory which is - as usual - defined via S.
> 

Should I take then [v5 5/5]?

Alex

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Changes in v6:
>   - fix module build on wheezy-arm and (upcoming) stretch-arm64
> 
> This allows to keep v5 of patch 5. Sorry for the mess, but I initially
> thought it was an issue with old wheezy on special ARM hardware only.
> But when it also popped up on stretch-arm64, I finally analyzed it.
> 
>   .../linux-module/files/debian/changelog            |  5 +++++
>   .../linux-module/files/debian/compat               |  1 +
>   .../linux-module/files/debian/control              | 11 ++++++++++
>   .../recipes-kernel/linux-module/files/debian/rules | 15 ++++++++++++++
>   meta/recipes-kernel/linux-module/module.inc        | 24 ++++++++++++++++++++++
>   5 files changed, 56 insertions(+)
>   create mode 100644 meta/recipes-kernel/linux-module/files/debian/changelog
>   create mode 100644 meta/recipes-kernel/linux-module/files/debian/compat
>   create mode 100644 meta/recipes-kernel/linux-module/files/debian/control
>   create mode 100755 meta/recipes-kernel/linux-module/files/debian/rules
>   create mode 100644 meta/recipes-kernel/linux-module/module.inc
> 
> diff --git a/meta/recipes-kernel/linux-module/files/debian/changelog b/meta/recipes-kernel/linux-module/files/debian/changelog
> new file mode 100644
> index 0000000..c1c3516
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-module/files/debian/changelog
> @@ -0,0 +1,5 @@
> +@PN@ (@PV@) unstable; urgency=low
> +
> +  * Generated package.
> +
> + -- ISAR project <isar-users@googlegroups.com>  Tue, 6 Feb 2018 00:00:00 +0000
> diff --git a/meta/recipes-kernel/linux-module/files/debian/compat b/meta/recipes-kernel/linux-module/files/debian/compat
> new file mode 100644
> index 0000000..ec63514
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-module/files/debian/compat
> @@ -0,0 +1 @@
> +9
> diff --git a/meta/recipes-kernel/linux-module/files/debian/control b/meta/recipes-kernel/linux-module/files/debian/control
> new file mode 100644
> index 0000000..707f857
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-module/files/debian/control
> @@ -0,0 +1,11 @@
> +Source: @PN@
> +Section: kernel
> +Priority: optional
> +Standards-Version: 3.9.6
> +Build-Depends: linux-headers-@KERNEL_NAME@
> +Maintainer: ISAR project <isar-users@googlegroups.com>
> +
> +Package: @PN@
> +Architecture: any
> +Depends: linux-image-@KERNEL_NAME@
> +Description: @DESCRIPTION@
> diff --git a/meta/recipes-kernel/linux-module/files/debian/rules b/meta/recipes-kernel/linux-module/files/debian/rules
> new file mode 100755
> index 0000000..46cf977
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-module/files/debian/rules
> @@ -0,0 +1,15 @@
> +#!/usr/bin/make -f
> +
> +# Debian rules for custom kernel module build
> +#
> +# This software is a part of ISAR.
> +# Copyright (c) Siemens AG, 2018
> +#
> +# SPDX-License-Identifier: MIT
> +
> +export KDIR=$(shell ls -d /lib/modules/*/build)
> +
> +export DEB_BUILD_OPTIONS=parallel=$(shell nproc)
> +
> +%:
> +	CFLAGS= LDFLAGS= dh $@ --parallel
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
> new file mode 100644
> index 0000000..aa232f7
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -0,0 +1,24 @@
> +# Custom kernel module recipe include
> +#
> +# This software is a part of ISAR.
> +# Copyright (c) Siemens AG, 2018
> +#
> +# SPDX-License-Identifier: MIT
> +
> +FILESPATH =. "${LAYERDIR_core}/recipes-kernel/linux-module/files:"
> +
> +DESCRIPTION ?= "Custom kernel module ${PN}"
> +
> +DEPENDS += "linux-headers-${KERNEL_NAME}"
> +
> +SRC_URI += "file://debian/"
> +
> +inherit dpkg
> +
> +dpkg_runbuild_prepend() {
> +    cp -r ${WORKDIR}/debian ${WORKDIR}/${S}/
> +    sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \
> +           -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \
> +           -e 's/@DESCRIPTION@/${DESCRIPTION}/g' \
> +        ${WORKDIR}/${S}/debian/changelog ${WORKDIR}/${S}/debian/control
> +}
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov