From: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
To: Henning Schild <henning.schild@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCH 1/4] classes: make sure container extension can run multiple times
Date: Thu, 29 Jul 2021 10:29:05 +0200 [thread overview]
Message-ID: <702aca73-3567-8f94-ed76-09bd3d2ed2b0@siemens.com> (raw)
In-Reply-To: <20210728152210.7089-2-henning.schild@siemens.com>
On 28/07/2021 17:22, Henning Schild wrote:
> If the container extension fails somewhere in the middle, it could leave
> things behind resulting in issues when trying to run only that one task
> again.
>
> So make sure to remove stuff as root and remove another possibly
> existing directory.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
> meta/classes/image-container-extension.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass
> index e26604a04f06..6537fc693265 100644
> --- a/meta/classes/image-container-extension.bbclass
> +++ b/meta/classes/image-container-extension.bbclass
> @@ -18,7 +18,7 @@ containerize_rootfs() {
>
> # prepare OCI container image skeleton
> bbdebug 1 "prepare OCI container image skeleton"
> - rm -rf "${oci_img_dir}"
> + sudo rm -rf "${oci_img_dir}" "${oci_img_dir}_unpacked"
Correct, since those directory trees are beings created with 'sudo'.
> sudo umoci init --layout "${oci_img_dir}"
> sudo umoci new --image "${oci_img_dir}:${empty_tag}"
> sudo umoci config --image "${oci_img_dir}:${empty_tag}" \
Silvano Cirujano Cuesta
--
Siemens AG, T RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2021-07-29 8:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 15:22 [PATCH 0/4] Allow better control over container tags Henning Schild
2021-07-28 15:22 ` [PATCH 1/4] classes: make sure container extension can run multiple times Henning Schild
2021-07-29 8:29 ` Silvano Cirujano Cuesta [this message]
2021-07-28 15:22 ` [PATCH 2/4] classes: simplify tag handling in container class Henning Schild
2021-07-29 8:49 ` Silvano Cirujano Cuesta
2021-07-28 15:22 ` [PATCH 3/4] classes: allow more control over container image name and tag Henning Schild
2021-07-29 12:50 ` Silvano Cirujano Cuesta
2021-07-29 13:05 ` Henning Schild
2021-07-29 13:13 ` Silvano Cirujano Cuesta
2021-07-28 15:22 ` [PATCH 4/4] classes: fix comment in container-img class Henning Schild
2021-07-29 12:52 ` Silvano Cirujano Cuesta
2021-07-28 15:23 ` [PATCH 0/4] Allow better control over container tags Henning Schild
2021-07-29 12:58 ` Silvano Cirujano Cuesta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=702aca73-3567-8f94-ed76-09bd3d2ed2b0@siemens.com \
--to=silvano.cirujano-cuesta@siemens.com \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox