public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Koch, Stefan (DI PA DCP R&D 3)" <stefan-koch@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "Schmidt, Adriaan (T CED SES-DE)" <adriaan.schmidt@siemens.com>
Subject: Re: [PATCH] dpkg: Add support for building packages also for multi archs
Date: Mon, 16 Jan 2023 14:09:06 +0100	[thread overview]
Message-ID: <707c98b5-202b-f080-db80-f769eb58134d@siemens.com> (raw)
In-Reply-To: <0b769b28b175d32a801ede0e0fa8ef5aa6dacb7c.camel@siemens.com>

On 16.01.23 12:50, Koch, Stefan (DI PA DCP R&D 3) wrote:
> Sounds principally good. Thanks.
> 
> For the kbuild case I have submitted a similar patch:
> [PATCH v2 3/5] dpkg: Add support for additional target and host builds
> (Tue, 20 Dec 2022 18:09:19 +0100)
> 
> It modifies dpkg-base.bbclass instead of dpkg.bbclass
> 
> It uses the SBUILD_HOST variable for the same purpose as this patch
> fulfills with the new PACKAGE_ARCH(S) variable. Migration from
> SBUILD_HOST to PACKAGE_ARCHS should be possible. But I have not tested
> this yet.
> 
> My patch will additionally set SCHROOT_DIR depending on
> ISAR_CROSS_COMPILE to SCHROOT_TARGET_DIR or SCHROOT_HOST_DIR. That's
> what I have not found inside this patch.

It's not needed in my model because schroot variations collapse if you
don't need them (host=target), and the host variant can not only build
for the target but naturally also the host - thus SCHROOT_HOST is
universal in practice.

> Since my patch does it in the
> dpkg-base.bbclass the schroot configuration is written before running
> dpkg_runbuild with the correct SCHROOT_DIR. Doing this in dpkg.bbclass
> would need a bit more code - it's not impossible I think.

There is in fact a 3rd proposal that Adriaan explained to me on Friday
(not sure if he shared it on the list before), and that would model the
variation via different (auto-generated) targets (mytarget,
mytarget-native, mytarget-compat). It has some critical point regarding
how to detect non-identical rebuilt arch-all and source packages, but
would otherwise be even more elegant. Adriaan wants to follow-up on that
soon.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux


      reply	other threads:[~2023-01-16 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 20:05 Jan Kiszka
2023-01-16 11:50 ` Koch, Stefan
2023-01-16 13:09   ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=707c98b5-202b-f080-db80-f769eb58134d@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=stefan-koch@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox