* sources.list empty line results in debootstrap error
@ 2019-05-23 9:22 Schultschik, Sven
2019-05-23 9:34 ` [PATCH] isar-bootstrap: fix ignore empty line in source list claudius.heine.ext
0 siblings, 1 reply; 3+ messages in thread
From: Schultschik, Sven @ 2019-05-23 9:22 UTC (permalink / raw)
To: isar-users
[-- Attachment #1.1: Type: text/plain, Size: 664 bytes --]
I had the error that debootstrap is called with to less values (see image)
After a while I noticed that I had an empty line at the end of my sources.list file. Deleting this line fixed the issue.
It seems that the script reads every line, if it's empty or not.
Two possibility
1. raise a worthy error message, which states the real problem
2. just check if a line is empty and ignore empty lines ...
Reproduce:
Add empty lines to your sources.list for debootstrap and you should run into the error.
https://github.com/ilbers/isar/blob/b6ac71a53eb33b4e777480be557e1220a21c7fa2/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc#L230
[-- Attachment #1.2: Type: text/html, Size: 3627 bytes --]
[-- Attachment #2: image.png --]
[-- Type: image/png, Size: 194406 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] isar-bootstrap: fix ignore empty line in source list
2019-05-23 9:22 sources.list empty line results in debootstrap error Schultschik, Sven
@ 2019-05-23 9:34 ` claudius.heine.ext
2019-05-24 13:07 ` Maxim Yu. Osipov
0 siblings, 1 reply; 3+ messages in thread
From: claudius.heine.ext @ 2019-05-23 9:34 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
From: Claudius Heine <ch@denx.de>
Signed-off-by: Claudius Heine <ch@denx.de>
---
meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index b740c57..7d7c95c 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -76,7 +76,7 @@ def parse_aptsources_list_line(source_list_line):
s = source_list_line.strip()
- if s.startswith("#"):
+ if not s or s.startswith("#"):
return None
type, s = re.split("\s+", s, maxsplit=1)
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] isar-bootstrap: fix ignore empty line in source list
2019-05-23 9:34 ` [PATCH] isar-bootstrap: fix ignore empty line in source list claudius.heine.ext
@ 2019-05-24 13:07 ` Maxim Yu. Osipov
0 siblings, 0 replies; 3+ messages in thread
From: Maxim Yu. Osipov @ 2019-05-24 13:07 UTC (permalink / raw)
To: claudius.heine.ext, isar-users; +Cc: Claudius Heine
On 5/23/19 11:34 AM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
Applied to the 'next'.
Maxim.
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index b740c57..7d7c95c 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -76,7 +76,7 @@ def parse_aptsources_list_line(source_list_line):
>
> s = source_list_line.strip()
>
> - if s.startswith("#"):
> + if not s or s.startswith("#"):
> return None
>
> type, s = re.split("\s+", s, maxsplit=1)
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-24 13:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 9:22 sources.list empty line results in debootstrap error Schultschik, Sven
2019-05-23 9:34 ` [PATCH] isar-bootstrap: fix ignore empty line in source list claudius.heine.ext
2019-05-24 13:07 ` Maxim Yu. Osipov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox