Re: [PATCH 2/8] isar-events: Wait for failing umounts

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-02-19 10:45, Alexander Smirnov wrote:
> On 02/16/2018 11:52 AM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> The BuildCompleted event may come prior to all running build processes
>> being terminated. In that case, some mount might be busy, and we will
>> leave them dangling behind. Wait in that case.
> 
> How long we should wait? 

Until it's done.

> For example there was a bug with apt-get which
> results as hanging of 'http' process. So in this case Isar never returns
> to command prompt until second ^C pressed.

In that case, you need to run around killing processes anyway.

Jan

> 
> Alex
> 
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>   meta/classes/isar-events.bbclass | 28 +++++++++++++++++++---------
>>   1 file changed, 19 insertions(+), 9 deletions(-)
>>
>> diff --git a/meta/classes/isar-events.bbclass
>> b/meta/classes/isar-events.bbclass
>> index 4b5e97e..68208f1 100644
>> --- a/meta/classes/isar-events.bbclass
>> +++ b/meta/classes/isar-events.bbclass
>> @@ -2,11 +2,26 @@
>>   #
>>   # This software is a part of ISAR.
>>   # Copyright (C) 2015-2017 ilbers GmbH
>> +# Copyright (c) Siemens AG, 2018
>>     addhandler isar_handler
>>     python isar_handler () {
>>       import subprocess
>> +    import time
>> +
>> +    def umount_all(basepath):
>> +        # '/proc/mounts' contains all the active mounts, so knowing
>> basepath
>> +        # we can get the list of mounts for the specific multiconfig and
>> +        # clean them.
>> +        with open('/proc/mounts', 'rU') as f:
>> +            for line in f:
>> +                if basepath in line:
>> +                    if subprocess.call('sudo umount ' + line.split()[1],
>> +                                       stdout=devnull, stderr=devnull,
>> +                                       shell=True) != 0:
>> +                        return False
>> +        return True
>>         devnull = open(os.devnull, 'w')
>>   @@ -16,15 +31,10 @@ python isar_handler () {
>>           arch = d.getVar('DISTRO_ARCH', True)
>>             if tmpdir and distro and arch:
>> -            w = tmpdir + '/work/' + distro + '-' + arch
>> -
>> -            # '/proc/mounts' contains all the active mounts, so
>> knowing 'w' we
>> -            # could get the list of mounts for the specific
>> multiconfig and
>> -            # clean them.
>> -            with open('/proc/mounts', 'rU') as f:
>> -                for line in f:
>> -                    if w in line:
>> -                        subprocess.call('sudo umount -f ' +
>> line.split()[1], stdout=devnull, stderr=devnull, shell=True)
>> +            basepath = tmpdir + '/work/' + distro + '-' + arch
>> +
>> +            while not umount_all(basepath):
>> +                time.sleep(1)
>>         devnull.close()
>>   }
>>
> 


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux