From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6683827867816558592 X-Received: by 2002:a50:ad9b:: with SMTP id a27mr42054266edd.206.1556631056319; Tue, 30 Apr 2019 06:30:56 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:8bdb:: with SMTP id n27ls2677439edn.2.gmail; Tue, 30 Apr 2019 06:30:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqzkKB1Un+OJ8Svmgfg/t9Xqi562q0PhUORtihLRrXMCm5Kjx75O2iA1au5lElsi6O/4q0z0 X-Received: by 2002:a50:a704:: with SMTP id h4mr26789751edc.7.1556631055839; Tue, 30 Apr 2019 06:30:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556631055; cv=none; d=google.com; s=arc-20160816; b=wgglJviTnH+a1zCQ1WHZQqbRWLfiwbpm0a9n9yPB59J8XJnHzwA/jZsl/LL6euS6fl m+5lz3a3YaNHLVHLZKpFtb2el4rPGhc+foal9+F7NLaBFQ38rpts/JSD9K2HUYxDRoEl mrTgO4+Dz68aAf4ks1XRC7lKIvN9oVzGk0nExsUm3WbTsIhY8ZGuAfnQwAFH/m8Ndfuw 8zqwMtnnZUbkTd1tWujEg43/x+svChGTKqif+jIjjPYkOtJazLVJpSnNMP41Y+Xwz9nB xBNq1/OYTOQW43bmS1HlhX5mD6bidMO0trqEwmgB8Ap+LM4gVKqQ8fG1ohdg2zg5YF3l iIWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=vHCWW2dcedjhkW04SSRLFuhSF238EL5j4rueEJc/ZcM=; b=u1DNgwIBJUfMId5EDnI2Ze7+G0LbMmNzm7cvscZ35wTG70cYfYnXFzHNLJ8qAfYAiw VUxI6q2ONcahcE390ntjZjXRk9hAj6kJuZaIr4pStzGboFKjb2GFFeWf0pYQxAIz0Wax dR2vBev425tmkjZV+/s/LqJGHQMHDCjt9XBeETSebu9uKRo5Y7PzXPGD29F1a7ADzNwJ V8yR0p94/i1eaHKmnMg0qdYDusvZIqY7reQUDT6fNiOa765/TldAqJAXdSZoR38+Ef24 tjTeSIz2Fb/EmiaLXi2eEMgWoqM2G1f2WHYD8V6yV5MAGec327Qd8e+eFTLWZsIu1soQ wnbg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id j5si1607570ejm.1.2019.04.30.06.30.55 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Apr 2019 06:30:55 -0700 (PDT) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x3UDUpZ1001757 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Apr 2019 15:30:51 +0200 Subject: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage To: Andreas Reichel Cc: Claudius Heine , claudius.heine.ext@siemens.com, isar-users@googlegroups.com References: <20190425134450.13443-1-claudius.heine.ext@siemens.com> <20190425134450.13443-2-claudius.heine.ext@siemens.com> <155626421155.10914.2537647574220599237@ardipi> <89e6b417-265c-b1a6-b151-0938fed5d462@ilbers.de> <20190430093405.GA14335@iiotirae> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <70eae983-d513-9ed9-5c54-cc6218a9af3f@ilbers.de> Date: Tue, 30 Apr 2019 16:30:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190430093405.GA14335@iiotirae> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: Fe6R8XeGtLGm On 4/30/19 12:34 PM, Andreas Reichel wrote: > On Fri, Apr 26, 2019 at 11:41:16AM +0300, Maxim Yu. Osipov wrote: >> Hi Claudius, Andreas, >> >> @Andreas >> Your input is very welcome at this topic as you were busy with all this APT >> keys stuff. >> > > Thank you. Well in my eyes, Claudius delivers important changes to Isar > which improve code quality and the build steps as a whole. Also as I > know him, he is never ever interested in any personal "affairs" whatsoever, > which I also learnt from his reviews on my code. He has a sharp mind and > always tries to get out the best of the code up to his knowledge and > techniques. Furthermore, if he may sometimes sound direct or even > annoying to some - this is merely a personal question of how one focuses > on mails. I also did not understand everything he criticized on my code > in the beginning - but after I understood him, it was always great > improvement. So, Maxim, I beg that you do not take anything personal on > any mail, regarding any words or writing style but just focus on the > code as I always try - which always helps to go on further with the > project and to improve it. That's my input. > > Andreas I would prefer to focus on technical aspects of the modification under review. Are you OK with this modification? Regards, Maxim. >> On 4/26/19 9:36 AM, Claudius Heine wrote: >>> Hi Maxim, >>> >>> Quoting Maxim Yu. Osipov (2019-04-25 20:20:59) >>>> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote: >>>>> From: Claudius Heine >>>>> >>>>> isar-bootstrap-host only supports bootstrapping Debian root file >>>>> systems. Therefore deactivate any DISTRO_APT_KEYS from other >>>>> distributions. >>>>> >>>>> Signed-off-by: Claudius Heine >>>>> --- >>>>> meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>>>> index 08b068f..3e96281 100644 >>>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb >>>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}" >>>>> ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock" >>>>> require isar-bootstrap.inc >>>>> +# We only build debian host buildchroot environments >>>>> +DISTRO_APT_KEYS = "" >>>> >>>> From the first glance this modification limits functionality. >>>> It looks like a hack and I would suggest to avoid this modification. >>> >>> Well it is a fix and that limited functionality was already present but >>> just implicit, hidden behind some bug and the cleanup just made it >>> appear. >> >> >> Could you please point to this hidden, implicit place where mentioned bug >> persists? >> >> I've looked under meta/recipes-core/isar-bootstrap/ >> >> It seems that keyring stuff is quite symmetrical (in terms of host/target): >> >> isar/meta/recipes-core/isar-bootstrap$ grep -ri keyring * >> isar-bootstrap-host.bb:do_generate_keyring[stamp-extra-info] = >> "${DISTRO}-${DISTRO_ARCH}" >> isar-bootstrap-host.bb:addtask bootstrap before do_build after >> do_generate_keyring >> isar-bootstrap.inc:APTKEYRING = "${WORKDIR}/apt-keyring.gpg" >> isar-bootstrap.inc:DEBOOTSTRAP_KEYRING = "" >> isar-bootstrap.inc: d.setVar("DEBOOTSTRAP_KEYRING", "--keyring >> ${APTKEYRING}") >> isar-bootstrap.inc: d.setVar("DEBOOTSTRAP_KEYRING", "--keyring >> ${APTKEYRING}") >> isar-bootstrap.inc:do_generate_keyring[dirs] = "${DL_DIR}" >> isar-bootstrap.inc:do_generate_keyring[vardeps] += "DISTRO_APT_KEYS" >> isar-bootstrap.inc:do_generate_keyring() { >> isar-bootstrap.inc: gpg --no-default-keyring --keyring >> "${APTKEYRING}" \ >> isar-bootstrap.inc:addtask generate_keyring before do_build after do_unpack >> isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \ >> isar-bootstrap.inc: ${DEBOOTSTRAP_KEYRING} \ >> isar-bootstrap-target.bb:do_generate_keyring[stamp-extra-info] = >> "${DISTRO}-${DISTRO_ARCH}" >> isar-bootstrap-target.bb:addtask bootstrap before do_build after >> do_generate_keyring >> isar/meta/recipes-core/isar-bootstrap$ >> >> >> And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc) >> differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing >> regarding >> >> if [ ${IS_HOST} ]; then >> ${DEBOOTSTRAP} $debootstrap_args \ >> ${@get_distro_components_argument(d, True)} \ >> ${DEBOOTSTRAP_KEYRING} \ >> "${@get_distro_suite(d, True)}" \ >> "${ROOTFSDIR}" \ >> "${@get_distro_source(d, True)}" >> >> else >> "${DEBOOTSTRAP}" $debootstrap_args \ >> --arch="${DISTRO_ARCH}" \ >> ${@get_distro_components_argument(d, >> False)} \ >> ${DEBOOTSTRAP_KEYRING} \ >> "${@get_distro_suite(d, False)}" \ >> "${ROOTFSDIR}" \ >> "${@get_distro_source(d, False)}" >> fi >> >> >> >> >>> >>>> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to >>>> avoid confusion between target and host apt keys. >>> >>> Good idea. But that would be a new feature/improvement. >> >> Yes. But your series is also improvement, isn't? >> >> I need more arguments for introduction of this limitation. >> >> Maxim. >> >>> Also thanks for looking at the code! >>> >>> Claudius >>> >>>> >>>> >>>> Maxim. >>>> >>>> >>>> >>>>> inherit isar-bootstrap-helper >>>>> do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" >>>>> >>>> >>>> >>>> -- >>>> Maxim Osipov >>>> ilbers GmbH >>>> Maria-Merian-Str. 8 >>>> 85521 Ottobrunn >>>> Germany >>>> +49 (151) 6517 6917 >>>> mosipov@ilbers.de >>>> http://ilbers.de/ >>>> Commercial register Munich, HRB 214197 >>>> General Manager: Baurzhan Ismagulov >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups "isar-users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. >>>> To post to this group, send email to isar-users@googlegroups.com. >>>> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de. >>>> For more options, visit https://groups.google.com/d/optout. >>> >>> -- >>> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk >>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >>> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de >>> >>> PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 >>> Keyserver: hkp://pool.sks-keyservers.net >>> >> >> >> -- >> Maxim Osipov >> ilbers GmbH >> Maria-Merian-Str. 8 >> 85521 Ottobrunn >> Germany >> +49 (151) 6517 6917 >> mosipov@ilbers.de >> http://ilbers.de/ >> Commercial register Munich, HRB 214197 >> General Manager: Baurzhan Ismagulov > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov