From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6593954480607199232 X-Received: by 2002:a1c:7003:: with SMTP id l3-v6mr658626wmc.28.1535354497944; Mon, 27 Aug 2018 00:21:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:c4fa:: with SMTP id o55-v6ls3733707wrf.8.gmail; Mon, 27 Aug 2018 00:21:37 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdaf+v9RQJ4dY5oMoOJKsBxZ3cr3I/b6bWrIiHLO5PdLAp7I2N8gh+mjFYnAro81z3mWRrlz X-Received: by 2002:a5d:658a:: with SMTP id q10-v6mr929073wru.25.1535354497511; Mon, 27 Aug 2018 00:21:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535354497; cv=none; d=google.com; s=arc-20160816; b=ys/Cctu76gwurXincXFBvgiBbgpRnNZ/ljfoMIBzOVdHkFXOiTS0P3pr/FZAWCawLY hfB86vlD7TtGFKnSrxKe0uyzOSg9SpFSBkvQKuAJv2FKzX0P7CuFWnuSlX/I2b1u34Hz 86K343o4pVByb1Qr3cmX3CqZLjpIstdKhHMhk+Xe4m1UrNkHkAcysl30wgQZMv4+ZalL IVVIRW1e+75r8DR91/Tr1FRtmzh179L7/jZTylPy2sFAvUui3LEFfAzVArMnGipV67WW NvgrcvvoHr06B0pnSKHlweIdLfbJCKgxnOUsRKyGGKK91dGKHalifaamj5Oa47PNtaWz ZjHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=kgzu615XL8pczhgDj0zIt78HNPc/0E1lvQrAcTD1ES0=; b=YcjpZWchqBqoRQKvj4QKx3BeTFq60HLIY0PX0PX8gfkn3z4PivNtvuImXfkPIUuk+5 Ve/z6FQC0T+e/SXxsRBEAh1er7EMg6yp2qbjLVNlwi28Omw07QgOabEzJzzMrQOmo5WS uToRowiP8b14jtSA7nR4zyUoyP7aepngEx6ZLpXvLfxvw+89xPZX2AVnm4GyQI9Xw5bh rgGim5Qg3DpdUedyRWXTOPNVdjk4yefbv423u/XIKAHy8zwf08e+qPelM31zL43CNupi 7jfP/pe5Np3j/QemK/P8LyGMZ26cyS/hP+hCVKi/nMcKUGZz5+quPSN4OynIiDj69hlb 8OfQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id x7-v6si234587wmh.0.2018.08.27.00.21.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Aug 2018 00:21:37 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w7R7LaYb003062 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Aug 2018 09:21:37 +0200 Received: from [167.87.11.147] ([167.87.11.147]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w7R7LaVj031389; Mon, 27 Aug 2018 09:21:36 +0200 Subject: Re: [PATCH] linux: add "git" to KBUILD_DEPENDS To: Cedric Hombourger , isar-users@googlegroups.com References: <1535274652-191-1-git-send-email-Cedric_Hombourger@mentor.com> From: Jan Kiszka Message-ID: <71135f92-ef70-243a-026c-89348a99c5cc@siemens.com> Date: Mon, 27 Aug 2018 09:21:36 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1535274652-191-1-git-send-email-Cedric_Hombourger@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: t3MPBz705Tbz On 2018-08-26 11:10, Cedric Hombourger wrote: > Several build scripts from the kernel use "git" and in particular > scripts/setlocalversion. The latter is used to produce a version > string when we "make -s kernelrelease". My kernel builds would > sporadically fail with the PV check as the "+" sign appended by > kbuild would or would not be present in the "kernelrelease" output > if "git" was installed or not in the buildchroot. Get consistent > results by getting "git" installed into the buildchroot when we > build custom kernels. > > Signed-off-by: Cedric Hombourger > --- > meta/recipes-kernel/linux/linux-custom.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc > index 8438143..d75346e 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -24,7 +24,7 @@ inherit dpkg-base > > SRC_URI += "file://build-kernel.sh" > > -KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc" > +KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git" > KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool, kmod, linux-base (>= 4.3~)" > KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, libssl1.1" > > Makes sense to me. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux