Re: [PATCH 2/2] Revert "meta/classes/image: Call transform_template after rootfs_install"

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Maxim,

On 17/05/2019 12.58, Maxim Yu. Osipov wrote:
> On 5/16/19 2:50 PM, claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> This 'fix' is no longer necessary.
> 
> Why did you put fix in quotes?

Because this change just painted over the underlying issue with the 
non-deterministic and volatile value of the KERNEL_IMAGE and 
INITRD_IMAGE variables. So I would not consider that a permanent fix but 
a quick band-aid.

> This revert fixed the problem with do_fit_image if we want to keep old 
> naming scheme for kernel/initrd image.

This is not just a naming scheme change. Any bitbake variable that could 
change in the middle of the build process is not deterministic an 
therefor a bug.

A good next refactoring step would in fact be to remove the 
'get_image_name' function, since it does not return a deterministic 
value, and instead implement that completely in the `do_copy_boot_files` 
task.

Claudius

> 
> Maxim.
> 
>> This reverts commit 2df0b261610f38bc1d5472f7ee0e3d51243ed602.
>> ---
>>   meta/classes/image.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index 398275f..3eb261f 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -169,7 +169,7 @@ do_copy_boot_files() {
>>           cp -f "$dtb" "${DEPLOY_DIR_IMAGE}/${DTB_FILE}"
>>       fi
>>   }
>> -addtask copy_boot_files before do_rootfs_postprocess 
>> do_transform_template after do_rootfs_install
>> +addtask copy_boot_files before do_rootfs_postprocess after 
>> do_rootfs_install
>>   python do_image_tools() {
>>       """Virtual task"""
>>
> 
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de