From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6691606441411739648 X-Received: by 2002:adf:8bc5:: with SMTP id w5mr1396596wra.132.1558336783149; Mon, 20 May 2019 00:19:43 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:ca45:: with SMTP id m5ls2263061wml.1.canary-gmail; Mon, 20 May 2019 00:19:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCD9zsml3UrVy58QpqlWCUqtXanYrljN3rvoDon6f07tCcVHnuS/SbNGxJx/zQgpx2peXD X-Received: by 2002:a1c:9d4f:: with SMTP id g76mr30879656wme.97.1558336782771; Mon, 20 May 2019 00:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558336782; cv=none; d=google.com; s=arc-20160816; b=k/za+T+l8hDJViLC9k0qLLnj32Fm9r6DzbZ70mwhnyL8BfOceN11hlzow71gF4B/6U vz8Q5RlFVgC2D8gULnjpbGXuzoY8Bwi3trjvbp53Tg8XHM5E+7UbWWlASrGOP73PlXva 6t7A30pWwCsUYWXuxeyGzAUdO8zEiboyUFdsEHlPNT0/sPjCLkQfXpz70OFpFxE+nptP gczgM+gbtSsWr2hVsLhQRVODyurePVN2KDMrcv0jVWnFXyjpfA55ionmiHcOarkZWYbY KYNTPY/MvFSL+vlXB1F0OZhAJtsymPSqlm80j9x6xG/2GFmVtEcL52MP4eHVTjTjDmK3 oDgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=jHzcNUklUo1qf/iIJhMVPU2f6J8GdPuRp6/L+EOqiDI=; b=MSPfI8XM/krQcvM5BUZKSqIDejnkqPnQpa5+838OiVfn7GRZHlH//vWR5T7xpJZ5gG gsTUy4fEPDmoxKZISPgBFCAHCBs3IxUHxAr3CO+B8/FGz2/c+mk+3DKJw2h0zr98GctY KbcHVoHF4A+cBjC5KtfwAmt7pQR9YNVWJJ3CIXhG9A+q21aYxUqop2P/2tPrQ/ooy/tT cdD8szYkyoASkH5rTFrf/17SNIlx9Fi5YJqEhxA3duXedSvR8tHt44cNDG/J1F9f29tq cJ3Gc7QfuQfcyxEhiytTeXBKGsGWmmzZ9QVzXkcJYx6/5PS+8uiabfgChe2cvTs6llJU f3gg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id q11si216920wrj.2.2019.05.20.00.19.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 00:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x4K7JfOu020662 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 May 2019 09:19:42 +0200 Received: from [139.25.69.232] (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x4K7Jf5J021342; Mon, 20 May 2019 09:19:41 +0200 Subject: Re: [PATCH 2/2] Revert "meta/classes/image: Call transform_template after rootfs_install" To: "Maxim Yu. Osipov" , isar-users@googlegroups.com Cc: Claudius Heine References: <20190516125030.13190-1-claudius.heine.ext@siemens.com> <20190516125030.13190-3-claudius.heine.ext@siemens.com> <7de18f5d-e5ca-49ba-2497-ab70a0508c66@ilbers.de> From: Claudius Heine Message-ID: <729803d9-2ce2-4de4-c121-a7d1d90842a7@siemens.com> Date: Mon, 20 May 2019 09:19:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <7de18f5d-e5ca-49ba-2497-ab70a0508c66@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: LPL7dlfybSKF Hi Maxim, On 17/05/2019 12.58, Maxim Yu. Osipov wrote: > On 5/16/19 2:50 PM, claudius.heine.ext@siemens.com wrote: >> From: Claudius Heine >> >> This 'fix' is no longer necessary. > > Why did you put fix in quotes? Because this change just painted over the underlying issue with the non-deterministic and volatile value of the KERNEL_IMAGE and INITRD_IMAGE variables. So I would not consider that a permanent fix but a quick band-aid. > This revert fixed the problem with do_fit_image if we want to keep old > naming scheme for kernel/initrd image. This is not just a naming scheme change. Any bitbake variable that could change in the middle of the build process is not deterministic an therefor a bug. A good next refactoring step would in fact be to remove the 'get_image_name' function, since it does not return a deterministic value, and instead implement that completely in the `do_copy_boot_files` task. Claudius > > Maxim. > >> This reverts commit 2df0b261610f38bc1d5472f7ee0e3d51243ed602. >> --- >>   meta/classes/image.bbclass | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index 398275f..3eb261f 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -169,7 +169,7 @@ do_copy_boot_files() { >>           cp -f "$dtb" "${DEPLOY_DIR_IMAGE}/${DTB_FILE}" >>       fi >>   } >> -addtask copy_boot_files before do_rootfs_postprocess >> do_transform_template after do_rootfs_install >> +addtask copy_boot_files before do_rootfs_postprocess after >> do_rootfs_install >>   python do_image_tools() { >>       """Virtual task""" >> > > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de