Re: [PATCH v4 07/13] isar-bootstrap: Connect to gpg-agent before adding keys

[Jan Kiszka <jan.kiszka@siemens.com>]

On 07.10.20 16:01, [ext] Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> We have recurring issues in CI with the gpg-agent not being ready when
> trying to use apt-key:
> 
> gpg: can't connect to the agent: IPC connect call failed
> 
> Work around this by connecting upfront to the agent, retrying that in a
> bounded loop.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index fbfe669d..1c5dba74 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -303,10 +303,13 @@ isar_bootstrap() {
>                               "${ROOTFSDIR}/etc/apt/apt.conf.d/50isar.conf"
>              find ${APT_KEYS_DIR}/ -type f | while read keyfile
>              do
> -                kfn="$(basename $keyfile)"
> +                export kfn="$(basename $keyfile)"
>                  cp $keyfile "${ROOTFSDIR}/tmp/$kfn"
> -                chroot "${ROOTFSDIR}" /usr/bin/apt-key \
> -                   --keyring ${THIRD_PARTY_APT_KEYRING} add "/tmp/$kfn"
> +                chroot "${ROOTFSDIR}" sh -c '
> +                    for i in $(seq 10); do
> +                        /usr/bin/apt-key --keyring ${THIRD_PARTY_APT_KEYRING} add "/tmp/$kfn" && break
> +                        sleep 1
> +                    done'
>                  rm "${ROOTFSDIR}/tmp/$kfn"
>              done
>  
> 

No more gpg-related CI failures since this has been applied to our
layers. You said you have an even better version, but that wasn't even
shared so far.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux