From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7280073785777061888 X-Received: by 2002:a19:7906:0:b0:503:3cc:cd39 with SMTP id u6-20020a197906000000b0050303cccd39mr3031601lfc.8.1696493937469; Thu, 05 Oct 2023 01:18:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:1ce:b0:500:880d:5fa5 with SMTP id f14-20020a05651201ce00b00500880d5fa5ls337908lfp.2.-pod-prod-05-eu; Thu, 05 Oct 2023 01:18:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGihbXyMkDg1X4XzDDS9Hv7xgQheVkp8NCo5qMwvUTx3UhgA6pDi4dRrAt3OwCiQXtAqQAT X-Received: by 2002:ac2:4989:0:b0:502:c615:99a9 with SMTP id f9-20020ac24989000000b00502c61599a9mr3776908lfl.30.1696493935091; Thu, 05 Oct 2023 01:18:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696493935; cv=none; d=google.com; s=arc-20160816; b=TQ2QoKOTri4cz8vnQnMAyRMIlFAszIgqGwJ0OOtNTfzXpynhQQUq/IGXMKTdhsxXRF f5sv6UcYsjO8vXzKVCTgBGWDC4s9c5K4xy6H7OkPzJSabA5TBTdJHWvK11t0UmQZu9Dx bg16TPXXhye3x69HVaICPnvgIAvvzVRzLWyRDCEVpy0SXWjCWz3XOOUzrW/IiydcUEXO jGEMp8hY/a8f98nJRYTCQVUdvwKXkvx4hX8gtzUxv7RmGvR0gbfxpMvZV83pJblYs9/N mY0VaCYRPmee0Mdu7huERpOgmthNBYHcZdYyzjIxVlJRcYozQ1v1l0b2bP6s2FtWbioN tkcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=UkTcfZiSi+2Rv7jOv+Y/5Zqpqy6a7Asw4/KJRPZeQh8=; fh=IxbeHM4vWxalf1XNf2rnGcQL+r1v0Lr0C6ICsGNNkYw=; b=JlaLBACIcT5htddcHd3IF6+F0Aduqh7ygAAIRTfLhyzrvrqccS1ONWobt4NQFWkNOv e+OiQAQ3W86L8Y9hLHrqAR2Y5UTd5tMiJO2V8389HgmZQyZIWaBl/EIOJihMLHQZLsIg TgVNl9vlFBh9emvmTziTNByBDZa45V6vu1Z2a5BnHjJvLsrx6hNi0e5y8JIfKDpvLASq /DZ00pqakvgVDP00adwfKUJH9hz4I0di97QXqRSStpEBTf/AXzcDMF3+7T1ixcKDPDrB 8nhNA/CN6L4KdyjNfXpmZkrCAaPSx3xk9q72ieBXVU/vhVJN1kC6F3NQ9gB1S5SRM5JE tQ4w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id w13-20020a05651234cd00b005042ae499b9si64410lfr.7.2023.10.05.01.18.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2023 01:18:54 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 3958Iq0A027157 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Oct 2023 10:18:53 +0200 Message-ID: <73872ab4f7ae8c8fe50757de6a1a378e032b70a6.camel@ilbers.de> Subject: Re: [PATCH v3] base: Fix HOST_ARCH for native builds From: Uladzimir Bely To: Jan Kiszka , isar-users Date: Thu, 05 Oct 2023 11:18:53 +0300 In-Reply-To: <0c292419-da7d-43ab-af00-c33322087130@siemens.com> References: <7e817969-de10-43fa-911d-639aa91e9499@siemens.com> <9c2cf410f9a3f13bd0d8c0091888fb1d29071c32.camel@ilbers.de> <0c292419-da7d-43ab-af00-c33322087130@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: bjRiw5hDLont On Thu, 2023-10-05 at 08:56 +0200, Jan Kiszka wrote: > On 05.10.23 07:48, Uladzimir Bely wrote: > > On Sun, 2023-10-01 at 11:09 +0200, Jan Kiszka wrote: > > > From: Jan Kiszka > > >=20 > > > HOST_ARCH must be DISTRO_ARCH when we are not cross-building. > > > Otherwise, > > > recipes that set PACKAGE_ARCH to it will fail in native builds. > > >=20 > > > To avoid recursions, we have to rework the ISAR_CROSS_COMPILE > > > setting > > > in > > > imagetypes.bbclass to an anonymous python function. > > >=20 > > > Signed-off-by: Jan Kiszka > > > --- > > >=20 > > > This looks better now. > > >=20 > > > Maybe we can even kill BUILD_HOST_ARCH, now that HOST_ARCH is > > > fixed. > > >=20 > > > =C2=A0meta/classes/base.bbclass=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |= 6 ++++-- > > > =C2=A0meta/classes/imagetypes.bbclass | 6 ++++-- > > > =C2=A02 files changed, 8 insertions(+), 4 deletions(-) > > >=20 > > > diff --git a/meta/classes/base.bbclass > > > b/meta/classes/base.bbclass > > > index 88004120..f315a9d5 100644 > > > --- a/meta/classes/base.bbclass > > > +++ b/meta/classes/base.bbclass > > > @@ -49,13 +49,15 @@ def oe_import(d): > > > =C2=A0# We need the oe module name space early (before INHERITs get > > > added) > > > =C2=A0OE_IMPORTED :=3D "${@oe_import(d)}" > > > =C2=A0 > > > -def get_deb_host_arch(): > > > +def get_deb_host_arch(d): > > > =C2=A0=C2=A0=C2=A0=C2=A0 import subprocess > > > +=C2=A0=C2=A0=C2=A0 if d.getVar("ISAR_CROSS_COMPILE") !=3D "1": > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return d.getVar("DISTRO_A= RCH") > > > =C2=A0=C2=A0=C2=A0=C2=A0 host_arch =3D subprocess.check_output( > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ["dpkg", "--print-ar= chitecture"] > > > =C2=A0=C2=A0=C2=A0=C2=A0 ).decode('utf-8').strip() > > > =C2=A0=C2=A0=C2=A0=C2=A0 return host_arch > > > -HOST_ARCH ??=3D "${@get_deb_host_arch()}" > > > +HOST_ARCH ??=3D "${@get_deb_host_arch(d)}" > > > =C2=A0HOST_DISTRO ??=3D "${DISTRO}" > > > =C2=A0 > > > =C2=A0die() { > > > diff --git a/meta/classes/imagetypes.bbclass > > > b/meta/classes/imagetypes.bbclass > > > index a3be0a1d..205377b1 100644 > > > --- a/meta/classes/imagetypes.bbclass > > > +++ b/meta/classes/imagetypes.bbclass > > > @@ -65,8 +65,10 @@ UBIFS_IMG ?=3D > > > "${PP_DEPLOY}/${IMAGE_FULLNAME}.ubifs" > > > =C2=A0 > > > =C2=A0# glibc bug 23960 > > > https://sourceware.org/bugzilla/show_bug.cgi?id=3D23960 > > > =C2=A0# should not use QEMU on armhf target with mkfs.ubifs < v2.1.3 > > > -THIS_ISAR_CROSS_COMPILE :=3D "${ISAR_CROSS_COMPILE}" > > > -ISAR_CROSS_COMPILE:armhf =3D > > > "${@bb.utils.contains('IMAGE_BASETYPES', > > > 'ubifs', '1', '${THIS_ISAR_CROSS_COMPILE}', d)}" > > > +python() { > > > +=C2=A0=C2=A0=C2=A0 if d.getVar('DISTRO_ARCH') =3D=3D 'armhf' and > > > bb.utils.contains('IMAGE_BASETYPES', 'ubifs', True, False, d): > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 d.setVar('ISAR_CROSS_COMP= ILE', '1') > > > +} > > > =C2=A0 > > > =C2=A0IMAGE_CMD:ubifs() { > > > =C2=A0=C2=A0=C2=A0=C2=A0 ${SUDO_CHROOT} /usr/sbin/mkfs.ubifs ${MKUBIF= S_ARGS} \ > >=20 > > The patch is merged now, but it seems to bring a regression. > >=20 > > Now, native compilation if imx6-sabrelite fails, because we set > > ISAR_CROSS_COMPILE to "1", while it seems should be "0" (like > > previously used temporary value of THIS_ISAR_CROSS_COMPILE. > >=20 >=20 > No, this is correct: The image recipe must have ISAR_CROSS_COMPILE =3D > "1" > because of >=20 > # glibc bug 23960 > https://sourceware.org/bugzilla/show_bug.cgi?id=3D23960 > # should not use QEMU on armhf target with mkfs.ubifs < v2.1.3 >=20 > Package recipes have it disabled, as desired. >=20 > I'll try a build to see what is really broken. >=20 > Jan >=20 Actually, it's easy to reproduce with isar/kas, if select bullseye on imx6-sabrelite, disable cross-compile and disable all packages to speedup the project. Probably, the issue is caused by using wrong SCHROOT_DIR in the imager.