public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com, Anton Mikanovich <amikan@ilbers.de>,
	Uladzimir Bely <ubely@ilbers.de>
Subject: Re: [PATCH v6 4/4] meta: Deploy DTBs once per kernel
Date: Mon, 16 Feb 2026 18:51:59 +0100	[thread overview]
Message-ID: <743de9ab-12f8-4e8d-b6b5-b3b8af1e7482@siemens.com> (raw)
In-Reply-To: <aZNQpq3wXA3HLJjG@abai.de>

On 16.02.26 18:15, Baurzhan Ismagulov wrote:
> On 2026-02-13 09:01, 'Jan Kiszka' via isar-users wrote:
>>> Task do_copy_boot_files deploys DTB files into the same location for
>>> different images (e.g., isar-image-base and isar-image-ci). This causes
>>> a build error.
>>>
>>> do_copy_boot_files is called once for every image recipe while dtb files
>>> belong to the kernel which is the same for both images. Performing dtb
>>> deployment once for the same kernel solves the issue.
>>
>> This remains inconsistent: DTBs are just another artifact of the kernel.
>> The kernel image itself is also deployed via the image recipe. Why is
>> there no conflict is because of image-specific file names being used. We
>> can't change the DTB file names, but we could put them in image-specific
>> deployment folders, for the case that multiple images are pushed into
>> the same deployment folder.
>>
>> Again: NAK, wrong approach, please finally process my feedback.
> 
> v6 has been sent for documenting the reasons in the archive as previously
> announced; I think we can solve this without escalating.
> 
> Now that you've shared your proposal of splitting by image -- that's an option
> and we can discuss it.
> 
> Our use case is:
> 1. Two images, same dtb name, same dtb contents.

Which is just the tip of this issue. Other layers deploy bootloader
files or firmware binaries under the same name, overwriting things right
now if two images are built under different names. And that overwriting
sometimes triggers the infamous bitbake deployment errors.

> 2. Downstream already has many deliverables.
> 
> My underlying question: Should we always duplicate, or should we at least try
> to identify cases where we can avoid duplication? "Same file -- single
> deployment".

How would you switch between de-duplicated and different artifacts by
name then? How would imagers or other users find deployed artifacts in
both cases?

> 
> Patch 4 "deploy dtb once per kernel" associates the dtb with the recipe
> producing it, reducing shuffling around in the image recipe. Yes, the kernel is
> still deployed in the image which is inconsistent at this step; I'd be fine
> doing that later.
> 
> We'll try playing with splitting by image. Even if we end up doing it at this
> time, I'd still propose to explore the other options step by step.

Please not so many user-visible changes "step by step". We need a design
that holds now, and we need one step to get there, at least when that
step implies path changes that downstream layers need to adjust to.

I guess we should rather introduce the pattern of creating a subfolder
${IMAGE_FULLNAME} and put all those potentially colliding artifacts there.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/743de9ab-12f8-4e8d-b6b5-b3b8af1e7482%40siemens.com.

  reply	other threads:[~2026-02-16 17:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  7:40 [PATCH v6 0/4] Deploy DTBs with separate recipe Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 1/4] wic: Obtain real machine name in isoimage source plugin Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 2/4] testsuite: Add testcases to check dtb deployment Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 3/4] meta: Fix do_copy_boot_files error for different distros of same machine Anton Mikanovich
2026-02-13  7:40 ` [PATCH v6 4/4] meta: Deploy DTBs once per kernel Anton Mikanovich
2026-02-13  8:01   ` 'Jan Kiszka' via isar-users
2026-02-16 17:15     ` Baurzhan Ismagulov
2026-02-16 17:51       ` 'Jan Kiszka' via isar-users [this message]
2026-02-18 16:21         ` Baurzhan Ismagulov
2026-02-18 16:45           ` 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=743de9ab-12f8-4e8d-b6b5-b3b8af1e7482@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=amikan@ilbers.de \
    --cc=jan.kiszka@siemens.com \
    --cc=ubely@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox