public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] CI: Remove KFAIL for Ubuntu
@ 2023-07-18 11:36 Anton Mikanovich
  2023-07-18 12:07 ` Jan Kiszka
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Anton Mikanovich @ 2023-07-18 11:36 UTC (permalink / raw)
  To: isar-users; +Cc: Anton Mikanovich

There were no KFAILs for Ubuntu for a long time already, so it looks
stable enough to remove CI protection from it.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 testsuite/citest.py | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/testsuite/citest.py b/testsuite/citest.py
index 0d30b883..c706abe0 100755
--- a/testsuite/citest.py
+++ b/testsuite/citest.py
@@ -129,7 +129,8 @@ class CrossTest(CIBaseTest):
             'mc:de0-nano-soc-bullseye:isar-image-base',
             'mc:stm32mp15x-bullseye:isar-image-base',
             'mc:qemuarm-bookworm:isar-image-ci',
-            'mc:qemuarm64-bookworm:isar-image-ci'
+            'mc:qemuarm64-bookworm:isar-image-ci',
+            'mc:qemuarm64-focal:isar-image-base'
                   ]
 
         self.init()
@@ -146,17 +147,6 @@ class CrossTest(CIBaseTest):
         except:
             self.cancel('KFAIL')
 
-    def test_cross_ubuntu(self):
-        targets = [
-            'mc:qemuarm64-focal:isar-image-base'
-                  ]
-
-        self.init()
-        try:
-            self.perform_build_test(targets)
-        except:
-            self.cancel('KFAIL')
-
 class WicTest(CIBaseTest):
 
     """
-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] CI: Remove KFAIL for Ubuntu
  2023-07-18 11:36 [PATCH] CI: Remove KFAIL for Ubuntu Anton Mikanovich
@ 2023-07-18 12:07 ` Jan Kiszka
  2023-07-18 12:56 ` Henning Schild
  2023-08-02  4:07 ` Uladzimir Bely
  2 siblings, 0 replies; 5+ messages in thread
From: Jan Kiszka @ 2023-07-18 12:07 UTC (permalink / raw)
  To: Anton Mikanovich, isar-users

On 18.07.23 13:36, Anton Mikanovich wrote:
> There were no KFAILs for Ubuntu for a long time already, so it looks
> stable enough to remove CI protection from it.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  testsuite/citest.py | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index 0d30b883..c706abe0 100755
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -129,7 +129,8 @@ class CrossTest(CIBaseTest):
>              'mc:de0-nano-soc-bullseye:isar-image-base',
>              'mc:stm32mp15x-bullseye:isar-image-base',
>              'mc:qemuarm-bookworm:isar-image-ci',
> -            'mc:qemuarm64-bookworm:isar-image-ci'
> +            'mc:qemuarm64-bookworm:isar-image-ci',
> +            'mc:qemuarm64-focal:isar-image-base'

Reminds me that we could try an update to recent Ubuntu, now that dpgk
supports zstd...

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] CI: Remove KFAIL for Ubuntu
  2023-07-18 11:36 [PATCH] CI: Remove KFAIL for Ubuntu Anton Mikanovich
  2023-07-18 12:07 ` Jan Kiszka
@ 2023-07-18 12:56 ` Henning Schild
  2023-07-18 13:50   ` Anton Mikanovich
  2023-08-02  4:07 ` Uladzimir Bely
  2 siblings, 1 reply; 5+ messages in thread
From: Henning Schild @ 2023-07-18 12:56 UTC (permalink / raw)
  To: Anton Mikanovich; +Cc: isar-users

Am Tue, 18 Jul 2023 14:36:42 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> There were no KFAILs for Ubuntu for a long time already, so it looks
> stable enough to remove CI protection from it.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  testsuite/citest.py | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index 0d30b883..c706abe0 100755
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -129,7 +129,8 @@ class CrossTest(CIBaseTest):
>              'mc:de0-nano-soc-bullseye:isar-image-base',
>              'mc:stm32mp15x-bullseye:isar-image-base',
>              'mc:qemuarm-bookworm:isar-image-ci',
> -            'mc:qemuarm64-bookworm:isar-image-ci'
> +            'mc:qemuarm64-bookworm:isar-image-ci',
> +            'mc:qemuarm64-focal:isar-image-base'

same here, consider trainling commas in these arrays ... maybe a patch
on top to add them everywhere

Henning

>                    ]
>  
>          self.init()
> @@ -146,17 +147,6 @@ class CrossTest(CIBaseTest):
>          except:
>              self.cancel('KFAIL')
>  
> -    def test_cross_ubuntu(self):
> -        targets = [
> -            'mc:qemuarm64-focal:isar-image-base'
> -                  ]
> -
> -        self.init()
> -        try:
> -            self.perform_build_test(targets)
> -        except:
> -            self.cancel('KFAIL')
> -
>  class WicTest(CIBaseTest):
>  
>      """


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] CI: Remove KFAIL for Ubuntu
  2023-07-18 12:56 ` Henning Schild
@ 2023-07-18 13:50   ` Anton Mikanovich
  0 siblings, 0 replies; 5+ messages in thread
From: Anton Mikanovich @ 2023-07-18 13:50 UTC (permalink / raw)
  To: Henning Schild; +Cc: isar-users

18/07/2023 15:56, Henning Schild wrote:
> Am Tue, 18 Jul 2023 14:36:42 +0300
> schrieb Anton Mikanovich <amikan@ilbers.de>:
>
>> There were no KFAILs for Ubuntu for a long time already, so it looks
>> stable enough to remove CI protection from it.
>>
>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>> ---
>>   testsuite/citest.py | 14 ++------------
>>   1 file changed, 2 insertions(+), 12 deletions(-)
>>
>> diff --git a/testsuite/citest.py b/testsuite/citest.py
>> index 0d30b883..c706abe0 100755
>> --- a/testsuite/citest.py
>> +++ b/testsuite/citest.py
>> @@ -129,7 +129,8 @@ class CrossTest(CIBaseTest):
>>               'mc:de0-nano-soc-bullseye:isar-image-base',
>>               'mc:stm32mp15x-bullseye:isar-image-base',
>>               'mc:qemuarm-bookworm:isar-image-ci',
>> -            'mc:qemuarm64-bookworm:isar-image-ci'
>> +            'mc:qemuarm64-bookworm:isar-image-ci',
>> +            'mc:qemuarm64-focal:isar-image-base'
> same here, consider trainling commas in these arrays ... maybe a patch
> on top to add them everywhere
>
> Henning

Agree, will prepare a patch on top of all CI-related stuff.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] CI: Remove KFAIL for Ubuntu
  2023-07-18 11:36 [PATCH] CI: Remove KFAIL for Ubuntu Anton Mikanovich
  2023-07-18 12:07 ` Jan Kiszka
  2023-07-18 12:56 ` Henning Schild
@ 2023-08-02  4:07 ` Uladzimir Bely
  2 siblings, 0 replies; 5+ messages in thread
From: Uladzimir Bely @ 2023-08-02  4:07 UTC (permalink / raw)
  To: Anton Mikanovich, isar-users

On Tue, 2023-07-18 at 14:36 +0300, Anton Mikanovich wrote:
> There were no KFAILs for Ubuntu for a long time already, so it looks
> stable enough to remove CI protection from it.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  testsuite/citest.py | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index 0d30b883..c706abe0 100755
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -129,7 +129,8 @@ class CrossTest(CIBaseTest):
>              'mc:de0-nano-soc-bullseye:isar-image-base',
>              'mc:stm32mp15x-bullseye:isar-image-base',
>              'mc:qemuarm-bookworm:isar-image-ci',
> -            'mc:qemuarm64-bookworm:isar-image-ci'
> +            'mc:qemuarm64-bookworm:isar-image-ci',
> +            'mc:qemuarm64-focal:isar-image-base'
>                    ]
>  
>          self.init()
> @@ -146,17 +147,6 @@ class CrossTest(CIBaseTest):
>          except:
>              self.cancel('KFAIL')
>  
> -    def test_cross_ubuntu(self):
> -        targets = [
> -            'mc:qemuarm64-focal:isar-image-base'
> -                  ]
> -
> -        self.init()
> -        try:
> -            self.perform_build_test(targets)
> -        except:
> -            self.cancel('KFAIL')
> -
>  class WicTest(CIBaseTest):
>  
>      """
> -- 
> 2.34.1
> 

Applied to next.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-08-02  4:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-18 11:36 [PATCH] CI: Remove KFAIL for Ubuntu Anton Mikanovich
2023-07-18 12:07 ` Jan Kiszka
2023-07-18 12:56 ` Henning Schild
2023-07-18 13:50   ` Anton Mikanovich
2023-08-02  4:07 ` Uladzimir Bely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox