From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6836316038099894272 X-Received: by 2002:a2e:8901:: with SMTP id d1mr2466231lji.37.1591811913318; Wed, 10 Jun 2020 10:58:33 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:96d2:: with SMTP id d18ls3275652ljj.1.gmail; Wed, 10 Jun 2020 10:58:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAICnubNeb4QzVE63Ga7ZCTC4r9VbSvZdtQfeONu45i6LiQBYb1no3vfkavm/BKja2EFvL X-Received: by 2002:a2e:8554:: with SMTP id u20mr2366419ljj.188.1591811912013; Wed, 10 Jun 2020 10:58:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591811912; cv=none; d=google.com; s=arc-20160816; b=MMaVLv2pVUHFXQgzNbz9BWHbSbXE6vI0ItU2g2X6X3L2qNpQbeYPtfan9YvgRIiT5H DBMLZ89Mrr5iuT2OVCNhqdlPcBq2//nhmp6aOfLZ7pdjLZ3EfGT828NBo1o/ZRrYaqGJ rXU87cDjPwwJSxw6Pr8nk7NLi0lPOSeDxkJfMEqVAEtHRs1Y191LdfkC7UvNSCD8Ur/X 9MbgWZCV5kE52MIJkRFeqYsuCQ9ONKSBHdJj4eWWytT47whVyM9TjeAnVTZD8E6btSJR WRQcNbJza2VaI/+ww2lFgF0E6I/1Pa5iBZhXejrAboMrectHYCh55chnBY+HNSz9KzIm aZUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=BbEQi6W8lEmn1VOVzO5Y8Fnt8ZSHqoe5rk7r6qEJ1CI=; b=LF0JHffIM2PPjWhUHTYKF2Yifbo20W9ftcsrfKwdon8L/tt16ZdRUsUb2vk9PP6xRH X1lsiNc3TNluGwpaWOGbZEpNhOKF8ZJ4qcTYb9K2VB2lQ4RkZy5UmeJqs4S0KlQx4GJj ZBexCHuBn2FOFsAiWijOXLIlocGUNwQ2+AY/OwSBP+AlBttdtsFKBh2idd+uWWwoSVGH pCoko6fKvPWx97JL6KyuwintrTXMv7mawkR+dAmzxpIflobsGfXWVgVvqiSl31qmOmNn KobAPBs+Rl1dCcCeo6VY8C+9XGF/4I8OBdS6i61F8VPa6Yd+dMKwTqecZNLgZwDipsy4 Kfxw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id j14si29205lji.8.2020.06.10.10.58.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jun 2020 10:58:31 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 05AHwVKo016419 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 10 Jun 2020 19:58:31 +0200 Received: from [167.87.24.185] ([167.87.24.185]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 05AHwUMU016366; Wed, 10 Jun 2020 19:58:30 +0200 Subject: Re: [PATCH] dpkg-raw: Allow patching and templating To: Henning Schild Cc: isar-users References: <9ded6977-71ed-3ef1-a1fe-4cb54fed78ed@siemens.com> <20200610183529.2846b543@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <753fd517-3900-ad28-762b-a188d71a682e@siemens.com> Date: Wed, 10 Jun 2020 19:58:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200610183529.2846b543@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: eif+x6T+j4nn On 10.06.20 18:35, Henning Schild wrote: > Just found this the hard way, LGTM > Yeah, it's a nasty issue. We even released the first IOT2050 image with this (I left this gremlin behind) - but the binary image itself is fine. That is because you may see a race in favor of you, allowing the parallel patch to actually run before the install. Jan > Am Tue, 9 Jun 2020 13:57:41 +0200 > schrieb "[ext] Jan Kiszka" : > >> From: Jan Kiszka >> >> We already allow pulling the artifacts from git, so it is also >> consequent to support patching as well as using templates before >> installing things. >> >> Signed-off-by: Jan Kiszka >> --- >> meta/classes/dpkg-raw.bbclass | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/classes/dpkg-raw.bbclass >> b/meta/classes/dpkg-raw.bbclass index 9d4e8c19..dd7b761f 100644 >> --- a/meta/classes/dpkg-raw.bbclass >> +++ b/meta/classes/dpkg-raw.bbclass >> @@ -13,7 +13,7 @@ do_install() { >> } >> >> do_install[cleandirs] = "${D}" >> -addtask install after do_unpack before do_prepare_build >> +addtask install after do_patch do_transform_template before >> do_prepare_build >> do_prepare_build[cleandirs] += "${S}/debian" >> do_prepare_build() { > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux