From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6671974161673355264 X-Received: by 2002:a50:b618:: with SMTP id b24mr13521885ede.9.1553440038959; Sun, 24 Mar 2019 08:07:18 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:9950:: with SMTP id l16ls1169858edb.3.gmail; Sun, 24 Mar 2019 08:07:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqySQVs8bdouehvwlGlLMHycwAAEZuCHIlTx3cMoReaZGf3f8+n7xJiajS23E0y4wuT7NFM3 X-Received: by 2002:a50:b36b:: with SMTP id r40mr13570659edd.12.1553440038537; Sun, 24 Mar 2019 08:07:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553440038; cv=none; d=google.com; s=arc-20160816; b=EqtDuJriysgDo0Lf6l6o8Jn93V8fvN2lOe9tnlS+j6pPKeuBbx+6VP3zRoHbIuqtJg aOUWzdYKr1eJdAFH9a6uOkiMQN3HASdm/khIIgC2KT1bKqLwzpLqIICBu2KwlZw3oxyS X5ZKFueP8dZ7b48yxxKv0s09X16DSM1+TvVXfdHvanptLlwI8aSLYXZZiCVxmCIzSTvO u+3KOY885dDWKLSBZiV9hq35VLCOiWMjsffF74U1hUZI/L2bCZIpAOpLlJP0xjoUKu0s inWsb2DXN/Z/xGFnxdf3ffTJYivP1ustTbF2vapMfAuPZUKMgpdr1rIGWa0jbfRRUNmf svQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:mime-version:user-agent :date:message-id:subject:from:cc:to:dkim-signature; bh=aG1VCWSKdXDmjUtiLFmCo9H0ZaNpQzU80vYyt882qjk=; b=i4wNg3D1jz/RJqbzQawC4rf6aWvvU6iPHmE7PTLijgrKShi8KFSM6qBaWBvyBS3XzO Cg37y9lTmOuVynrYJzbfzFzx7qWnSlLc9oW6f/D0ca+g5fYUNeKx9KygxG34R3EY/3qn Nd+NcMu9ct2iGe4ij2b/x6bEt9Pskb5QIU6KWvq8yG6YEJ7yXH1CgVc+g5t+Td8sFkvV AlScPz4lMBIcatp/RlwEnNc8/jnAq/tzgwkSA/K8L8pmTVAKk2paewXJeKWA6cpC2WbI IkwOszkKap8ErnAwpBd1P/3csHQYs4gHg3T+L3Jun31lxSKy8MiU/dtxEsnGXv6mjzUq hvPQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=p6DK2Id9; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [212.227.15.4]) by gmr-mx.google.com with ESMTPS id q1si446898edd.5.2019.03.24.08.07.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 08:07:18 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) client-ip=212.227.15.4; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=p6DK2Id9; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=jan.kiszka@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1553440038; bh=VSUX1gbpIxJeFvw1kWnHItf9SVTUarNp7gvGtg1GIpI=; h=X-UI-Sender-Class:To:Cc:From:Subject:Date; b=p6DK2Id9y4Dp87LTR4R21rzctTrVOSUh6aOW9Yy0ruEQvp6tAmsK07/JoMzUR1MMS Uq13WuqjhqfWzWA0eHxm8XgCmCXwaVZ8PQUUbsGgBq881FUhN+3hm3hdy2aSPeRQf/ noNmEcSCnGPtb0YlbW21OhHn43uZFxzHnn7gxt/4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MDxFv-1hCksU3uxj-00HQkU; Sun, 24 Mar 2019 16:07:18 +0100 To: isar-users Cc: Cedric Hombourger From: Jan Kiszka Subject: [PATCH] dpkg: Beautify runbuild Message-ID: <75befabe-76f0-7750-a1bf-3c2c3dbd2b22@web.de> Date: Sun, 24 Mar 2019 16:07:17 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:IXMs2bdWXsPzXL7VL0t+J83h4C+xqZKAqttG73V85aqc0y2xukS rKqbZ/8jdwdCb5TxgSWk2KgFZyaCSLmvPngvKLptFwAymgIPYqD3dGTgcYt33RVOiTcJwwD hvPWIrdNK+nlRGU/57nnwVzAyIf5WzhctaCzbTBQT67F1bJC8N041x2dZy7ERtjOBpWdMYA 0pTF+ISm06Y7TCyfor0LQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:T9jmT3PU77k=:Z87th/zTBaynRQt0vDivyd u8WLe6ENR16XGZzXfYt+IbvubSStI6um4Fx9LSKCsKAVXySMr83n/MUcQIoA+z2f1J0mXUMBy vDoKaeCv37Hv1YCoqMcyJ5/rFx6O3/CTBvVpTDQ88dfq/br+HLcre1vVnQpyJ59F8Rgcf5jAZ Vo2sQfRSAtZqgb/qhZLYQ3w34Q3a5UETHnupaJbIsDdAJ8vqo7v5aCRYDh+EUc+j8HNLna5jD JUOCV9KBXMCQ6hOYOIXtBsbq0GQb+fZBEP2BLodAM9IsSknu03C2CaipfiPRKBaUNLw3sp2pE 3eZPL4DxTyit2xz9y8tthEPIr9rDJD815hutuLsbMVjSei46k7IXJwxkO/wTim3IRttQbsrID TkX/2mPTxsopku7lJHUx4THCfZJGMtNIrrfAPRJypRqrt/8xCo+rCn7E0Bq8FGwF+TU0dIv8W 3y9AOivl45ofm8V20dt2QOrQABDaucxIVa5Mj84I9tRKuTKtaUe68VMtyVQEO9FKfnFssE7XQ 44msFwO5Kdub2tmwL5U7N1h1Gmf5O1wLe5J4a9RZs+j6M7nc14p/94gqK4rCTdRRw2s5XqKfX SCzwFWLR1x8wHQZSPaBjuZxFxgRYF0aXIzi0cmTcbAaNpRhX5qWEwi/WtZHciRl6nis7cWBe5 RrU9F0kUXRhIt7vzSe0uAht3ZcD3yJO2s50j1f5tlGxyNnRGKnKGsdSr1akaXeLT1M7wTyWFd ELqUPnTbMDUZTkXcouHjG9dpe8M7L1uP6ISM4FH+BR5zFFPW63CoYdBdUUaboyfNIbP0Eweyq U1PTU749xNm1Z1N+ucVGJEE/niJD0C4i6sz0Aiws5LsGd5hYyat3nBo/ei1ZG/Dvpt0AkdNTQ AeO8NGpszhXIeDKsagDKIP5P0k62Evq68A9l6RwIhI5GESvQOLk/jd48hULwdxOA55r7XcMMi tGRCBQIKIYQ== X-TUID: OPX2WkIqxnD1 From: Jan Kiszka Properly indent so that it becomes clearer that chroot runs under a lock. Also avoid overlong lines. Signed-off-by: Jan Kiszka =2D-- Looked at it while trying to understand why jailhouse-images started to serialize jobs massively. The reason is simple: If you have one package wi= th a heavy-weight build, every other packages that didn't finish its install_builddeps or even apt_fetch before that build starts will now wait= for the fat guy. This is fairly suboptimal. I guess the best answer to that is= to avoid the sharing: per package buildchroots. A topic for the next release.= .. meta/classes/dpkg.bbclass | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass index f4e3d7a..997f2f3 100644 =2D-- a/meta/classes/dpkg.bbclass +++ b/meta/classes/dpkg.bbclass @@ -20,5 +20,6 @@ do_install_builddeps[stamp-extra-info] =3D "${DISTRO}-${DISTRO_ARCH}" dpkg_runbuild() { E=3D"${@ bb.utils.export_proxies(d)}" flock -s "${REPO_ISAR_DIR}/isar.lock" \ - sudo -E chroot --userspec=3D$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} + sudo -E chroot --userspec=3D$( id -u ):$( id -g ) ${BUILDCHROOT_D= IR} \ + /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH} } =2D- 2.16.4