From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7013366436890411008 X-Gmail-Labels: Topic type: DISCUSSION Date: Mon, 4 Oct 2021 23:02:01 -0700 (PDT) From: Michael Ebel To: isar-users Message-Id: <75c4505a-0c79-4d3f-8646-8f36cb2b357bn@googlegroups.com> In-Reply-To: <20211004181932.0f6a59da@md1za8fc.ad001.siemens.net> References: <01271061-bcfd-4fa7-9c8a-1e54fa0d6817n@googlegroups.com> <20211004181932.0f6a59da@md1za8fc.ad001.siemens.net> Subject: Re: [PATCH] meta/classes/debianize: Create debian folder if source does not contain one MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_394_745471308.1633413721755" X-TUID: NcdtQrMeal0g ------=_Part_394_745471308.1633413721755 Content-Type: multipart/alternative; boundary="----=_Part_395_1081425002.1633413721755" ------=_Part_395_1081425002.1633413721755 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > These double headers look a little weird. Let us use if they cause fun > for "git am". Might be a product of not using "git-send-email". I used plain "git format-patch". I also checked that the patch does apply properly with "git am". But anyway based on your feedback I will gladly submit a v2 with "git-send-email". Michael Henning Schild schrieb am Montag, 4. Oktober 2021 um 18:19:35 UTC+2: > Am Wed, 29 Sep 2021 07:43:41 -0700 (PDT) > schrieb Michael Ebel : > > > From e4f8153bd3b3886b283ea19517b56f5190ca6b9a Mon Sep 17 00:00:00 2001 > > From: Michael Ebel > > Date: Wed, 29 Sep 2021 16:29:40 +0200 > > Subject: [PATCH] meta/classes/debianize: Create debian folder if > > source does not contain one > > These double headers look a little weird. Let us use if they cause fun > for "git am". Might be a product of not using "git-send-email". > > > Signed-off-by: Michael Ebel > > --- > > meta/classes/debianize.bbclass | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/meta/classes/debianize.bbclass > > b/meta/classes/debianize.bbclass index 4486778..338b1f5 100644 > > --- a/meta/classes/debianize.bbclass > > +++ b/meta/classes/debianize.bbclass > > @@ -88,6 +88,11 @@ EOF > > } > > > > deb_debianize() { > > + # create the debian folder if the source does not contain it > > The code is too obvious to ask for an explanation. > > > + if [ ! -d ${S}/debian ]; then > > Can be done without condition, install will not complain when already > there > > > + install -v -m 755 -d ${S}/debian > > no need to -v > > Henning > > > + fi > > + > > # create the compat-file if there is no file with that name in > > WORKDIR if [ -f ${WORKDIR}/compat ]; then > > install -v -m 644 ${WORKDIR}/compat ${S}/debian/compat > > ------=_Part_395_1081425002.1633413721755 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit > These double headers look a little weird. Let us use if they cause fun
> for "git am". Might be a product of not using "git-send-email".

I used plain "git format-patch". I also checked that the patch does apply properly with "git am".
But anyway based on your feedback I will gladly submit a v2 with "git-send-email".

Michael
Henning Schild schrieb am Montag, 4. Oktober 2021 um 18:19:35 UTC+2:
Am Wed, 29 Sep 2021 07:43:41 -0700 (PDT)
schrieb Michael Ebel <me...@christ-es.de>:

> From e4f8153bd3b3886b283ea19517b56f5190ca6b9a Mon Sep 17 00:00:00 2001
> From: Michael Ebel <me...@christ-es.de>
> Date: Wed, 29 Sep 2021 16:29:40 +0200
> Subject: [PATCH] meta/classes/debianize: Create debian folder if
> source does not contain one

These double headers look a little weird. Let us use if they cause fun
for "git am". Might be a product of not using "git-send-email".

> Signed-off-by: Michael Ebel <me...@christ-es.de>
> ---
> meta/classes/debianize.bbclass | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/classes/debianize.bbclass
> b/meta/classes/debianize.bbclass index 4486778..338b1f5 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -88,6 +88,11 @@ EOF
> }
>
> deb_debianize() {
> + # create the debian folder if the source does not contain it

The code is too obvious to ask for an explanation.

> + if [ ! -d ${S}/debian ]; then

Can be done without condition, install will not complain when already
there

> + install -v -m 755 -d ${S}/debian

no need to -v

Henning

> + fi
> +
> # create the compat-file if there is no file with that name in
> WORKDIR if [ -f ${WORKDIR}/compat ]; then
> install -v -m 644 ${WORKDIR}/compat ${S}/debian/compat

------=_Part_395_1081425002.1633413721755-- ------=_Part_394_745471308.1633413721755--