Re: [PATCH v2 7/9] dpkg-raw: Clean DEBIAN dir prior to filling it

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi,

On 02/15/2018 11:30 AM, Alexander Smirnov wrote:
> 
> 
> On 02/15/2018 01:26 PM, Claudius Heine wrote:
>> On 02/15/2018 10:18 AM, Jan Kiszka wrote:
>>> On 2018-02-15 10:14, Claudius Heine wrote:
>>>> Hi Jan,
>>>>
>>>> On 02/13/2018 09:05 PM, [ext] Jan Kiszka wrote:
>>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>>
>>>>> When we run unprivileged, writing files in that directory will not 
>>>>> work
>>>>> after the first run because everything is root-owned at the end.
>>>>>
>>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>>> ---
>>>>>    meta/classes/dpkg-raw.bbclass | 5 ++---
>>>>>    1 file changed, 2 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/meta/classes/dpkg-raw.bbclass
>>>>> b/meta/classes/dpkg-raw.bbclass
>>>>> index 44aa078..e3ae9e8 100644
>>>>> --- a/meta/classes/dpkg-raw.bbclass
>>>>> +++ b/meta/classes/dpkg-raw.bbclass
>>>>> @@ -16,10 +16,9 @@ do_install() {
>>>>>    do_install[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
>>>>>    addtask install after do_unpack before do_deb_package_prepare
>>>>>    -# so we can put hooks etc. in there already
>>>>> -do_install[dirs] = "${D}/DEBIAN"
>>>>> -
>>>>>    do_deb_package_prepare() {
>>>>> +    sudo rm -rf ${D}/DEBIAN
>>>>> +    mkdir ${D}/DEBIAN
>>>>>        cat<<-__EOF__ > ${D}/DEBIAN/control
>>>>>            Package: ${PN}
>>>>>            Architecture: ${DISTRO_ARCH}
>>>>>
>>>>
>>>> This:
>>>>
>>>>    do_install() {
>>>>      sudo install -v -m 755 ${WORKDIR}/postinst ${D}/DEBIAN/postinst
>>>>    }
>>>>
>>>> causes now:
>>>>
>>>>    install: cannot create regular file ‘/[...]/DEBIAN/postinst’: No 
>>>> such
>>>> file or directory
>>>>
>>>> How should that be fixed?
>>>
>>> Simply by removing the install above. "dpkg-raw: Install hooks
>>> automatically" makes it obsolete.
>>
>> Thx! But now it shows:
>>
>>    DEBUG: Executing shell function do_deb_package_prepare
>>    mkdir: cannot create directory ‘/[...]/DEBIAN’: No such file or 
>> directory
>>
>> I suppose it needs "mkdir -p ${D}/DEBIAN".
> 
> BTW: this series is already in next and it has passed all CI tests. 
> Which git head you use?

I rebased my own branch to next (e7e40a68adbfa60), and my stuff broke. 
AFAIK next is there to test stuff with our own setup and provide 
feedback, so that commits can be fixed there with sometimes even some 
history rewriting.

I wouldn't be against squashing Jans patch into this one on next.

regards,
Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de