From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6596905571509600256 X-Received: by 2002:a19:e05b:: with SMTP id g27-v6mr119728lfj.28.1536266812088; Thu, 06 Sep 2018 13:46:52 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:8246:: with SMTP id j6-v6ls646221ljh.10.gmail; Thu, 06 Sep 2018 13:46:51 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZc/1UdDcrI9DL3tT2pIqdo6K883JKezW9xs5lgUirmrHuYmxMwMyoKyQ2rLoReXO05lg8+ X-Received: by 2002:a2e:9b01:: with SMTP id u1-v6mr100744lji.11.1536266811665; Thu, 06 Sep 2018 13:46:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536266811; cv=none; d=google.com; s=arc-20160816; b=O7/1UQN4zNqIDmCg/niyq4dplrNm1RiUjb/EiPylYMF5TgDHDqn7iT2dzmxBNw24MZ MOJykDaudUrPDu7sNLB2kseDtYP4OVtTG97V4zrmRSHyAz3ApVNOOHAR+SBBg655pejU 0xSL3NfRRdH8Uj42Sr6q7Rnt2rz21K9YmDDM+mN0cCb6oc8ddtXVdKVnQRkXHNRKGVPM OxsmDYVyDfSOREgF82MJGVRvRZNLj1cDCZO3wM9an1r7T6w7tPLKBarXbmsRY8FefUBp T9T7PEVy/yYr5qgmeK72vDMXk2KlNTAFfr6sOgkMAPILVPMRRThQx6BGv56I6F1URUl2 YMog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=FbdwXBHND9S9JlGsGz+VFDFOs/1abm51gsu4abXkkZw=; b=gb8cHzhDm8Qn4huDFsVtXrEE8IMJ8jPDqWvEt9sfwVtVhihxNKFfynnETET9CPFPCN 29f6vY5inDb4HdQbUfvn3OXyDCuAOMGnGjC0CQ3X7UhDvnT8cBjkjzGku6rzkiT+Y2Uk mczkz1fLZ0kjHl3K2XjMEwMHrclsyRfcUqLEQpGM14f+Xx52WM+FA5BJL3XeqvQguysf n2jlqZXr1JB693DlndnD73l7uhKdnL8fEcrJQnzauvcqUf6VnqDk7G/M5kNEg0wmDyNq JtoJaGC1OHT8UwPUZRq7ga6CFeGxKBHZ1Tsqzneq924pyF2+5nrjSzPIbiZVF6Lcx7+3 DHjA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id y14-v6si132419lfy.1.2018.09.06.13.46.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Sep 2018 13:46:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (d51A48A80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w86KkmIZ016899 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 6 Sep 2018 22:46:49 +0200 Subject: Re: [PATCH] u-boot-script: Handle quoted --append bootloader parameter To: Jan Kiszka , isar-users References: <6a2481f9-2f0d-258e-de49-0e535adf44ba@siemens.com> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <770fbae5-705c-561f-1ad1-a46b73d3cfa4@ilbers.de> Date: Thu, 6 Sep 2018 22:46:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6a2481f9-2f0d-258e-de49-0e535adf44ba@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: w5iWyqkxjufF On 09/03/2018 10:02 AM, Jan Kiszka wrote: > We only supported a single parameter value for --append so far and broke > if the user put multiples under quotes. Applied to the 'next', Thanks, Maxim. > Signed-off-by: Jan Kiszka > --- > meta/recipes-bsp/u-boot-script/u-boot-script_1.0.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-bsp/u-boot-script/u-boot-script_1.0.bb b/meta/recipes-bsp/u-boot-script/u-boot-script_1.0.bb > index 490c306..da8dca5 100644 > --- a/meta/recipes-bsp/u-boot-script/u-boot-script_1.0.bb > +++ b/meta/recipes-bsp/u-boot-script/u-boot-script_1.0.bb > @@ -33,8 +33,8 @@ do_install() { > # to the packaged /etc/default/u-boot-script. > if [ -n ${WKS_PATH} ]; then > APPEND=$(grep "^bootloader " ${WKS_PATH} | \ > - sed 's/.* --append=\([^ $]*\).*/\1/') > - sed -i 's|\(^KERNEL_ARGS_APPEND=\).*|\1'${APPEND}'|' \ > + sed 's/.* --append=\(".*"\|[^ $]*\).*/\1/') > + sed -i 's|\(^KERNEL_ARGS_APPEND=\).*|\1'"${APPEND}"'|' \ > ${WORKDIR}/u-boot-script > fi > > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov