From: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>
To: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
"Kiszka, Jan" <jan.kiszka@siemens.com>
Cc: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>,
"Klincov, Wadim" <wadim.klincov@siemens.com>
Subject: Re: [PATCH v2] dpkg: Account for empty local apt cache after package build
Date: Wed, 25 Oct 2023 06:26:43 +0000 [thread overview]
Message-ID: <7782d3c747174a5d759f08746c26f39666cd3cf6.camel@siemens.com> (raw)
In-Reply-To: <47a6c8a9-cbb5-4ef2-ba47-c7a320f9da6e@siemens.com>
On Thu, 2023-10-19 at 06:39 +0200, 'Jan Kiszka' via isar-users wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> A build dependency-free package combined with sstate caching and
> cleared
> deb cache can trigger
>
> > cp -Ln --no-preserve=owner /var/cache/apt/archives/*.deb -t
> > /home/builder/example-raw/rootfs/var/cache/apt/archives/
> > -------------------------------------------------------------------
> > -------------------------------------------------
> >
> > cp: cannot stat '/var/cache/apt/archives/*.deb': No such file or
> > directory
> >
> > E: Command 'cp -Ln --no-preserve=owner
> > /var/cache/apt/archives/*.deb -t /home/builder/example-
> > raw/rootfs/var/cache/apt/archives/' failed to run.
>
> Account for that.
>
Yes, this is needed and blocks us updating ISAR.
Acked-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Felix
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> Changes in v2:
> - avoid returning error via negativ [ -n ] result
>
> meta/classes/dpkg.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index d89b0fd9..d61e9377 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -109,7 +109,7 @@ dpkg_runbuild() {
> --chroot-setup-commands="mkdir -p ${deb_dir}" \
> --chroot-setup-commands="ln -sf ${ext_deb_dir}/*.deb -t
> ${deb_dir}/" \
> --finished-build-commands="rm -f ${deb_dir}/sbuild-build-
> depends-main-dummy_*.deb" \
> - --finished-build-commands="cp -Ln --no-preserve=owner
> ${deb_dir}/*.deb -t ${ext_deb_dir}/" \
> + --finished-build-commands="[ -z "$(find ${deb_dir} -maxdepth
> 1 -name '*.deb' -print -quit)" ] || cp -Ln --no-preserve=owner
> ${deb_dir}/*.deb -t ${ext_deb_dir}/" \
> --finished-build-commands="cp /var/log/dpkg.log
> ${ext_root}/dpkg_partial.log" \
> --debbuildopts="--source-option=-I" \
> --build-dir=${WORKDIR} --dist="isar" ${DSC_FILE}
> --
> 2.35.3
>
next prev parent reply other threads:[~2023-10-25 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 4:39 Jan Kiszka
2023-10-25 6:26 ` MOESSBAUER, Felix [this message]
2023-10-25 6:44 ` Uladzimir Bely
2023-12-22 9:43 ` Uladzimir Bely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7782d3c747174a5d759f08746c26f39666cd3cf6.camel@siemens.com \
--to=felix.moessbauer@siemens.com \
--cc=adriaan.schmidt@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=wadim.klincov@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox