From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7184544729767346176 X-Received: by 2002:adf:dec6:0:b0:282:9531:662b with SMTP id i6-20020adfdec6000000b002829531662bmr1067020wrn.371.1672820861991; Wed, 04 Jan 2023 00:27:41 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:ce11:0:b0:3cf:afd2:ab84 with SMTP id m17-20020a7bce11000000b003cfafd2ab84ls15432464wmc.2.-pod-control-gmail; Wed, 04 Jan 2023 00:27:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXtCQV6uC9igVhth9ublYyw3DD+16x2x4UI1dlPHg9KII3rUaNCxHPDMaMOPtapPAvgMayHw X-Received: by 2002:a1c:6a14:0:b0:3d1:f302:1975 with SMTP id f20-20020a1c6a14000000b003d1f3021975mr32762434wmc.33.1672820860760; Wed, 04 Jan 2023 00:27:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1672820860; cv=pass; d=google.com; s=arc-20160816; b=xDxRqlmrOmdYYFX6tMxvcWhRECYHU5mx7miFw8Cmbi6k+1iXNMeYaHs607kiq8ZteT d6riUKLvKRtVonyYCivexPECoNA/qnRdpwRFa+mLHOwuyawNYlnQLSLluoXAe7k/aS4Q VlvnKKyOEJYXNCQypUaAWHIgAnuGMXzjicHqhct2EU7v98wPDCgutOrZFRFkYDCGhZ6c 6NswDP+r3o56Bskrnlg+lR2PrSWOAjaUbUKyFsB32sMgP9ayYP3W35Z6I4BWNZyOKj53 P6Mok8tY/lKBVRyrd5iHCVEZz7IwtotMKnfPiYdXfeEbf/Y6quDz0pavpY4ISSqE5AmC sKSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=MPEbj9PE3xtpRAW0NQ/6q+5nOjHyDJmOtSEyrfxrIhM=; b=ZbdDsRyQAS8m+xnStE8iT84SpUPzDCyw/DDzsNQhe/C/ViL2jJqu1WaCFWepM10gmB nPQnAdx5iL9aWn4nJG87DBH2N9r6xMnFOY1Hu3rmvfvBsoZtBBY+BDfZ3slunMErNQij MRm1vAlZmW2lyqG114aaCZQnm+5UMHVnmmnTevKZQ9O+onWGIESci9dyohP0kH4Dx6Ci FVdluwq0TnFUkX4jfJ+DA0PSg+iY+Y1XHA5Jq+YQwZeEJIdZc4qWHm91rEUt0d19/hWC HYoCBGhtURg7uu+D2zMvyXwDR5D40UiqJAKO7ItlPgZXvgfPy/uRrL5cKVEMRkAvJFFR JIhg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=uoa0FaMW; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.22.87 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2087.outbound.protection.outlook.com. [40.107.22.87]) by gmr-mx.google.com with ESMTPS id b22-20020a05600c4e1600b003d9c774d43fsi40683wmq.2.2023.01.04.00.27.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2023 00:27:40 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.22.87 as permitted sender) client-ip=40.107.22.87; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=uoa0FaMW; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.22.87 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VKj7VDI4KBw5op+XhRbq8EaPQWsZGXyVtwlJYqvi3zVm6VGrtsmkNEfQOzj8qFmB81UkSiJez5QVBNxJLRyIKdBNHMmbZ1FZcu45NGA2LKLpJHX1HMWu4C4xg3bsYdYcdkuwkdw8VfQP2VclqFARDdDGETtcdxxePiBUyJLFeByZSv2v1UDTBVkt83LX9V4tlDrB6EzalvJS41J+VovY+SsZs1MTXH+d3THSBGyD62+PgKCjkDEpel8waeDyJXvYh15KU7RN+ZywpKmH6vLcjTMGR7spYInDYbDbr2ju3kk6uTj21a0ax4HgCHXE4fuOrgxVAUwneA1rehULvHMlNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MPEbj9PE3xtpRAW0NQ/6q+5nOjHyDJmOtSEyrfxrIhM=; b=Q/R9KWA5jMeLSAOeTCRzWHNksXLJNrO6tk/b5hsdHU6jetzwjNx6j/sgi597/fwJcTSI84A17ykqDJp0nc/cyZj3Z7MMmcikBr6UPeFMYPH/oq3EqQ+65E+Ry63r4/1maZ3fjf37KgvrizbBo4b2g//StQwAjrkbGvloPM7B4d5YpIKu2U0V4s861EH/nE7N0NHnwjfIPhQk0eJvcYu70WpkbXjIJBsNFz03xHhm17g0WGBJWIq6fvKV3jSEuz0bMAHcbPrJre1k1nOgYHMWO/Dm4BbemZ6RKzD6jRhhkgbVA61OftAUfGazs/CVVjo7N5+zR02oPhEKbnwX2vS2Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MPEbj9PE3xtpRAW0NQ/6q+5nOjHyDJmOtSEyrfxrIhM=; b=uoa0FaMWyFfAg/zdUCsLVnu7TYpjkvEw3s+NHeAgTLFscO4lkU4BTojUU4h1gWDzmWRm6L2YtTCavce3R+5TkK2hgBZH0jTCQw0l/lYetc33SjC2RR1LeuZZYlFhUGUodZ2xddwT4KWjmGyKrrd8cI9TOA+nmaSEJCvr5OdWU/HQY+LkU+YBJHlprNbIM3A7FJEQZbrSeJHYJ9duwhAxjXKBtVW0nSDcV2YbDW8RPg7ru0N81gMOzHKBqZDtdV0xjgPbedCGPaHGURhvO6kCcTgW9LIwHvN5Ydr/bV6OTjb7BzP0KoYsWoRYHrHVhO4GGYHlO73imRxawOEgeU50ig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by AS2PR10MB7300.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:604::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 08:27:40 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2957:50e8:8ce6:124a]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2957:50e8:8ce6:124a%9]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 08:27:39 +0000 Message-ID: <77c3fed2-4a48-afe5-cd21-ccbe999bbdbd@siemens.com> Date: Wed, 4 Jan 2023 09:27:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] dpkg class set default value for ISAR_CROSS_COMPILE, if missing Content-Language: en-US To: "Roberto A. Foglietta" , isar-users@googlegroups.com References: From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::8) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|AS2PR10MB7300:EE_ X-MS-Office365-Filtering-Correlation-Id: c5b345b0-ff91-4f8e-9364-08daee2d8ade X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8el7oy4vd8jGYnDpmjYZXW3BIoZY0n3vsAk3E1NdXb2mrnrrFPA9okLiWJWqNDhaSKE5JiCWJu5WeACJJCbvXyMLLVleDCi0aMkZOF9/yOKnKDE/OL2HD94OosYz5xHv493ZWmjyP32gvl6CPU461NNw9iuPPcMGfePxAK4YloVSPO7ylo5VaK8mu09UYNxfqYUWTxVJ0dQspKhBjj9ThHhXkXlGfP7JswDhjSaAf5kSN5YMuKrSzn74gnvN3UR0PX9mMCnnbUhrXlJUZj0vdNxjNdU0LBVpmuhopS+O/0qGAr62GcvfM1gT06u/IIODA/jk/fL354mdo5luBLin3mJ8SNSLzYKgy2F0fOCtz5m4KzNs91wS3WeTbrCfSvVGMcMR+j0emHZZoLdo9FfW4cdELXU8rANN/HPx1nU3yilp7WUtwY+wbwO9oMlP4UlS4JS3HjxwaOmZFkD4cK32bVyDEAtmgJUzlSTZpt4bEpEyco0KOucFmFTfts3fVWHeBjI0ufc1TMQsauUAHC7dZwquqsuYucChc9GwiP+PSaPP4U2esebl43o2GAawOnNIdNpfdLEt5AD5llNhUS4kZxKCOlkttGDkKt367CvpERXSI0FA4C12NKaVKz57izqFBb253U9QYKy96sbKx3wWACwYGj8Qb8jn2i88CDVLY3ru8gwtahEDxFYJa5uFslS6fi5WZ/V7pNFHTsFZD/TBl7JKPdOgTOT3r7VapMHLLeMe5a85sESN+aAJObyzcBZDtOV+rtcpyWFSQ5WwmzqF4A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199015)(5660300002)(2906002)(8936002)(44832011)(8676002)(41300700001)(31686004)(66476007)(66946007)(316002)(6486002)(966005)(478600001)(66556008)(53546011)(6512007)(186003)(26005)(6506007)(6666004)(2616005)(82960400001)(38100700002)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVFEWWhBOFRDUEtNMlV6ZUdUampiSHpyNjZ3REtRR3RaWTZKZER1aVhRa2lr?= =?utf-8?B?ZXl1Zk1oZUEvRno4aEdYWGxrbE1IN3YvRFdZVmVLdE5POEJDaTB2RERGeDMz?= =?utf-8?B?cEF3WnZwU1pxUVNqd1B3d25NMFdjZ1Y3elRtanczK01lNFNxcUdIaEtCbWVm?= =?utf-8?B?Q0xSellzWHY0aGZxbUw2cUl3K281NUJaRFBQQklaNHhsZUJ0WmRzaWpYSVhn?= =?utf-8?B?VDJuZWZ4a05DeFF3ZnFzd1FCTG1SYWExTkR5d3JndnlUZlZxQUt1WHRPK0FG?= =?utf-8?B?QkRIUFVFK3lDRFlTY2NVdzdvc1ZIbnVXUzliNkhMWGRybEhFVWZZQ0N1K0k4?= =?utf-8?B?WlVjNWFOaldQNkZUSnJFUWFtN1I4NlVSWEF4aFkrUGU3UFdMMDdrNEZmaWJN?= =?utf-8?B?M2FNL2tROWc1dFhQd2xzVFZtTzlCaXVVQWRLeVBDb2NHZzRXRHBQWE9IeFdJ?= =?utf-8?B?RmM3VDhuSGhNdFg3bitWemNNY0hEb0w4ZlFnakExam1DNUsrMnFvUE1wOElZ?= =?utf-8?B?Q0FHdlFsZzJNTEhnQWNiY05KakNPamRpVDJxdW5EVXlxUFdYZzRzcTZrYUR4?= =?utf-8?B?UGdOVHM2bTdMWmFxUFNCL0F0cnB3YzVvZWREekdVbldraU5VbmtydHhRcHoy?= =?utf-8?B?VVpQMWJuZnlUYi9Hc1I1UVY4OHdBdElVUFdqU0ZwQS9tZ1RNQnd2MVJkbkMw?= =?utf-8?B?Z1VOMTRYajl6VlV6RDVQVzlCRU1aMUdwWmZBMlJGM2l3LzI5Q2Z1RjZ2eENk?= =?utf-8?B?cE5OTy9FRm02NnVMN1k0K3p4SmJwY0NkOFBBV05RNWZBNWIxSGtrNU0xem5I?= =?utf-8?B?Z2x1QXR0QjFsdE5CQ0dvSEVOZlNxM0hjaXA4NnJhTnhZbHlicTFjcytjNHUy?= =?utf-8?B?OHlSYW90b2xCMjUydGlrdjBGQzllYTlvT2EvaTM1RkdtdTdBWkhqU2dHeXBF?= =?utf-8?B?dFN1aWRPVjZXc2d5alZLZzdDanBiR0QyMGJnWGJ0YmdSZC9RbDZtY1EvNXpr?= =?utf-8?B?RlNVeWJQQXpjSWNIdCtmeXR3ZDg4RWxCZFRjc2lGTkttQnZKRlFOZVM3SjNF?= =?utf-8?B?UkF1V0p3RGVQSVVwQTk5SmRTRWlSS1ZFUmxubW5FZGJCenRodmpId2t2TDNx?= =?utf-8?B?TFhQRjlJeU92bWhTSk9YYmxqMnVhdjBIemZmeXNpbGF5SFNjdDNMY3BzL3hT?= =?utf-8?B?VS8vdFJPOEJxNEI2aE94WXNFSW9sZjd6S3NqZlJ0L0FQTzlJSDZ5bzNPWDVD?= =?utf-8?B?b0RlZ3RjUnVZM0I3dVdXSzdUQzZlRnR6Tm9obXFoL2lrRVRncTM0ZC9UZEdy?= =?utf-8?B?QkYwWTFPeGk4Q3ROWnVPMnIwcXV6WUJ4aTRBQjNKN281ZUdvTS9Bb0lJZWNl?= =?utf-8?B?VUhUc0dFTmFSbkUzQWNmczc3NjBqNS9TQVlZdWZ2cWVpN250dXFSNVd2WVhh?= =?utf-8?B?QmFSRVZQUEJlZmRjVS9NdWRZZWZPYUFBdWRENDlhQ3RyS1BScmF5NnI4dGpm?= =?utf-8?B?TXRPcjNwcjVBanBaelRieU55eGs4T0Y2bCtOSkhXZVQ2cWZEdE4yQVdWYTRU?= =?utf-8?B?TmFlMGpyRDNXQm13TEtnOEtaakg1QnZMTG1NNzRrTHp0L0JZVVBCVFZvYk1D?= =?utf-8?B?Y01XM3ByTElvVERVeDJwNzFZNmc3ZjlUa0NoQ3g4T0xXUUZVWFZaNmNvQmNZ?= =?utf-8?B?Z1VIZ000Y2luNE80aDFPUHB3L2NqaDJJekxyOXlEMkFza2ZFTUFxK0xyVCtk?= =?utf-8?B?VlVta05DN0Mybmk5SVVMN1duTWN6cW1FSlBOM1hucnB1eWVOeTNWRlNxRWx1?= =?utf-8?B?enpncXNwZ3BVUWNwcGtYWldLUHJYMjlSamIzUkpXd1lHV1AvTG81TXNsSUNn?= =?utf-8?B?UWJjT0VBZi9CSXJUWXpVQ2pnbWFaNkoxOURRY0JaOU82THp3SUUybHlsMVBv?= =?utf-8?B?N3BRY24rVm14OTVEeVh5QTBxSFdDOEkzcGVwNGk0SmVtRXVuOWpwUDlTTGZI?= =?utf-8?B?Wk1jcFNFR3ExT2p4NGw1MGczdnRqalp4akJueGdxcDhuNDF1a1pxaDhVV29x?= =?utf-8?B?NC9WNzNGMUNIWS9oV092dDBra1kzdVZVa3NtMkZrN3lPOFNLZzdadFBYbzcz?= =?utf-8?B?Tzc3K2JJczF0V1lqRmFZR0FZWXQ0NGFqR20zOTJ2SThTOVJOQ3A0b3VubXh5?= =?utf-8?B?NGc9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5b345b0-ff91-4f8e-9364-08daee2d8ade X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 08:27:39.8065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i5OnCe/D32j0BYydx52koR8Ott36YLU249eBOqZQH50ywEupx3Yo/QDjgfY/UGoec1JnxqmwtQsxoUdgW8+G4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7300 X-TUID: 49uWxJ5sf/fu On 03.01.23 22:42, Roberto A. Foglietta wrote: > The variable ISAR_CROSS_COMPILE might not be initialised in the dpkg > class thus the project fails to build. This sets the default, if missing. > > Signed-off-by: Roberto A. Foglietta > --- > meta/classes/dpkg.bbclass | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index bf60a5b..230bac9 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > > https://github.com/ilbers/isar/commit/06916be39eb00e9808674231afb0ead03a526bc1 > You must send patches inline, or we can't review things. Exceptionally pulling it in here: > From 06916be39eb00e9808674231afb0ead03a526bc1 Mon Sep 17 00:00:00 2001 > From: "Roberto A. Foglietta" > Date: Tue, 3 Jan 2023 22:28:05 +0100 > Subject: [PATCH] dpkg class set default value for ISAR_CROSS_COMPILE, if > missing > > The variable ISAR_CROSS_COMPILE might not be initialised in the dpkg > class thus the project fail to build. This sets the default, if missing. > > Signed-off-by: Roberto A. Foglietta > --- > meta/classes/dpkg.bbclass | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index bf60a5b..230bac9 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -3,6 +3,8 @@ > > inherit dpkg-base > > +ISAR_CROSS_COMPILE ?= "0" > + > PACKAGE_ARCH ?= "${DISTRO_ARCH}" > > DPKG_PREBUILD_ENV_FILE="${WORKDIR}/dpkg_prebuild.env" > -- > 2.34.1 Not sure what saved our ass so far, but the usage of ISAR_CROSS_COMPILE is way more spread out, so this does not make sense. If we want (and need) a global default, it should go into isar's bitbake.conf now. That would also be in line with USE_CCACHE e.g. Jan -- Siemens AG, Technology Competence Center Embedded Linux