Re: [PATCH 2/2] Revert "events: Do not warn on left mounts by default"

[Anton Mikanovich <amikan@ilbers.de>]

03/10/2024 10:25, 'Jan Kiszka' via isar-users wrote:
> On 02.10.24 22:31, 'Florian Bezdeka' via isar-users wrote:
>> This reverts commit 72ec986d9cd3a3913e8592554456d5968d6b659a.
>>
> This needs reasoning why the original motivation for this change no
> longer applies or was wrong.
>
> Jan
>
>> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
>> ---
>>   meta/classes/isar-events.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
>> index f5061a8b..77dfecee 100644
>> --- a/meta/classes/isar-events.bbclass
>> +++ b/meta/classes/isar-events.bbclass
>> @@ -53,7 +53,7 @@ python build_completed() {
>>       with open('/proc/mounts') as f:
>>           for line in f.readlines():
>>               if basepath in line:
>> -                bb.debug(1, '%s left mounted, unmounting...' % line.split()[1])
>> +                bb.warn('%s left mounted, unmounting...' % line.split()[1])
>>                   subprocess.call(
>>                       ["sudo", "umount", line.split()[1]],
>>                       stdout=subprocess.DEVNULL,

The motivation of original change was discussed here:
https://groups.google.com/g/isar-users/c/mz-7DWob0O0/m/8hLr6cw4AgAJ

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/77ecc277-59c5-4094-809c-f0fcc3f48e8e%40ilbers.de.