Re: [PATCH 1/1] newer kernels (e.g. v5.19) do not include objtool anymore in linux-header fixed

["Bezdeka, Florian" <florian.bezdeka@siemens.com>]

On Thu, 2022-11-03 at 09:47 +0300, Uladzimir Bely wrote:
> In the email from Saturday, 29 October 2022 22:09:10 +03 user Roberto A. 
> Foglietta wrote:
> > Hi all,
> > 
> >  I discovered that newer kernels (e.g. v5.19) when compiled and
> > packaged by an ISAR project do not include the objectool anymore. This
> > obviously breaks any activity which expects to use that binary
> > executable. In this a patch below a suggestion for fixing this issue
> > (tested ok).
> > 
> > From 48c6e9b409eb9d00e04a20f69df71ae88f51e178 Mon Sep 17 00:00:00 2001
> > From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
> > Date: Sat, 29 Oct 2022 18:59:10 +0200
> > Subject: [PATCH] linux install.tmpl: added OR with CONFIG_HAVE_OBJTOOL for
> >  objtools
> > 
> > linux install.tmpl: added OR with CONFIG_HAVE_OBJTOOL for objtools
> > a fix for newer kernels (since 5.19 for sure) to include objtool
> > 
> > Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> > ---

In addition to Uladzimir's findings below: 

This is the place (after the --- line) where additional comments can be
made. Those comments here will not be part of the commit message.

So maybe you can rework that patch a bit and send again.

> >  meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> > index 0a8645d..de57d82 100644
> > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> > @@ -177,7 +177,7 @@ kernel_headers() {
> >          echo Module.symvers >> ${obj_hdr_files}
> >      fi
> >      (cd ${O}; find arch/${ARCH}/include include scripts -type f)
> > 
> > > > ${obj_hdr_files}
> > 
> 
> The patch is mailformed here. Looks like it was sent not via "git send-email", 
> but just copy-pasted to the mail body.
> 
> Could you please send v2?
> 
> > -    if [ -n "${CONFIG_STACK_VALIDATION}" ]; then
> > +    if [ -n "${CONFIG_STACK_VALIDATION}" -o -n "${CONFIG_HAVE_OBJTOOL}" ];
> > then (cd ${O}; find tools/objtool -type f -executable) >>${obj_hdr_files}
> > fi
> >      if [ -n "${CONFIG_GCC_PLUGINS}" ]; then
> 
> 
> -- 
> Uladzimir Bely
> 
> 
>