From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6592507174472122368 X-Received: by 2002:a2e:9b01:: with SMTP id u1-v6mr703959lji.11.1535706332595; Fri, 31 Aug 2018 02:05:32 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:6802:: with SMTP id c2-v6ls1089804lja.1.gmail; Fri, 31 Aug 2018 02:05:32 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZrc/uVTDloCtDzYCT9KmULwjqAyvYhXP0/Pha1nEnUAmQ8Kz3TFheTKEasADtxw4Yd3cfk X-Received: by 2002:a2e:9048:: with SMTP id n8-v6mr700265ljg.44.1535706332019; Fri, 31 Aug 2018 02:05:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535706331; cv=none; d=google.com; s=arc-20160816; b=Z78h2P4rQHZNb3HnSvLaUycvQJupOexflJXs34jJCInP9QiLBu8V4PP/+6FtU7eRvh M/PvX3saKuvyGXey3R4uDjTGM9txJRvW5pmJdPT9wvCugtmUk+DqbQs2bx8659tb7nIl dtgmwchQIxgcbDSROHfD4HdbqdUWWNTBY/EaLloID8yf+/vtmGECwM+hyrhM6Whfy2xS DJ0aoSYK8ioW45Nydq+Ygxc2jCrWl88D+xH3/Z/ZDpHe1qtf/imZF3Et8CARqb2Uu/Eg 9fsXkcCb0PoQozpHdZ8Djfk5zLbPJ5OCct2d7WTqRvi465Tv51b8h+ZfZyBz6a2Znbzh lrWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject :arc-authentication-results; bh=ljKodr699wuIKCm0gECZG4AaaTOtCxbXkiSAwAQ26Sw=; b=qPkc2IBhMbJNgQ6mjY3PvA/OPn28/BhdHkgoGbeMR/Xv+8ByYFNlLLoxOdPDYrZkfe DDfj9sZQYPctRIl/q9G+X8yc578aWZl/26hbhV7D50sgW1rT5Ucxps2JzaAjZClvfTY/ Fcof9yO/mdLUAZGERpsjWcP9WUsCq1HJng27KyUedBE3o/qJOFstSBEU7ocSpBMzhR3X Yiiso2n/GhKO05C4ZGai1AfsrIIoKYZaf+yoIdFijVfsEmjNkVy/Py4YjqQ+yzhWz3Zi yNfOo6kdNNwc7mPB1vxKZA4wJemTnIggD4MqxoCrTnMdHAh+GjJV16KbSbZW9AWGTBBT lI/g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id n1-v6si340163ljg.0.2018.08.31.02.05.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Aug 2018 02:05:31 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w7V95U1c027929 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Aug 2018 11:05:30 +0200 Received: from [139.22.120.205] ([139.22.120.205]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w7V95TOK021441; Fri, 31 Aug 2018 11:05:29 +0200 Subject: Re: [PATCH v3 1/3] dpkg: move installation of dependencies into dpkg_prepare From: Jan Kiszka To: chombourger@gmail.com, isar-users , Maksim Osipov References: <20180822154145.07d4a2ca@md1pvb1c.ad001.siemens.net> <1535264488-128-1-git-send-email-Cedric_Hombourger@mentor.com> <3681e5f1-6401-4453-980b-585049d14329@googlegroups.com> <1e560261-edee-203b-db74-4ed5d1a35541@siemens.com> Message-ID: <78c2e4d4-6fff-c312-323e-582b961460d5@siemens.com> Date: Fri, 31 Aug 2018 11:05:29 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1e560261-edee-203b-db74-4ed5d1a35541@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: CAZCbBVji7nE On 2018-08-31 10:41, Jan Kiszka wrote: > On 2018-08-31 10:33, chombourger@gmail.com wrote: >> >> >> On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: >> >>     Re-reading the patch with my new knowledge: >> >>     On 2018-08-26 08:21, Cedric Hombourger wrote: >>      > diff --git a/meta/recipes-kernel/linux-module/module.inc >>     b/meta/recipes-kernel/linux-module/module.inc >>      > index 3075f44..3a3cab1 100644 >>      > --- a/meta/recipes-kernel/linux-module/module.inc >>      > +++ b/meta/recipes-kernel/linux-module/module.inc >>      > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0" >>      > >>      >   inherit dpkg >>      > >>      > -dpkg_runbuild_prepend() { >>      > +do_prepare_prepend() { >> >>     Shouldn't that be dpgk_prepare_append()? >> >> >> Wouldn't it be too late? >> I am afraid that debian/control wouldn't be complete and prevent >> installation of build dependencies >> > > Right, we need that for the installation... > > I was wondering, though, if it wouldn't be cleaner to hook additions to > the inner handler. > > Anyway, all this is not mature yet: > > - debianization does not require locking, only the dependency >   installation does > > - I'm quite sure something is broken now with dpkg-raw, because there is >   no lock involved, but we can pull packages that way as well > Yep, confirmed: We so far installed the dependencies of both regular and raw packages in the build script under the lock. Now you pulled that installation into deps.sh, but that script is not executed by dpkg-raw, nor is there any lock on the related prepare step. Can we fix this quickly? Or better revert and redo the series (given the other issues)? Jan > - we should cleanly name the steps, as you suggested, so that users know >   what to overwrite / append /prepend > > Jan > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux