From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6864480010557718528 X-Received: by 2002:a1c:7c13:: with SMTP id x19mr2763380wmc.45.1598979478372; Tue, 01 Sep 2020 09:57:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:4c:: with SMTP id 73ls1139973wma.0.canary-gmail; Tue, 01 Sep 2020 09:57:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxOPGGKRsAkin21dj+yiozN7y4pFeRAV5VcTf8p2dxshx3xrNyw138/dOk35UcBMGYpAe3 X-Received: by 2002:a1c:c90d:: with SMTP id f13mr2730768wmb.25.1598979477480; Tue, 01 Sep 2020 09:57:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598979477; cv=none; d=google.com; s=arc-20160816; b=WiyroqnYhMAnWndvaoPtCFRT+4UflcM0wEegRoMzRyF8RSQmKsR1nYPT1qJQc8yhCA pb5m5Nd1ryiV3AYNJD+6JjNOS5BaPCrH7EYz8GMpI99jhYK5oNI1QcgRejiJ5FXY43Eg IkzgclzWoHMuXe7jQ75CqSdZ0VzTMKlhoZPqyiYLRhi31MIMzobTBk2xKOW8t0Ga5Ncw L/MrupTdDUyPDe49E7IeJ7T1hCugX7o5ufVvRRUSJhVjDBFoNqQ+09KwDI7zxLMGiywj KaiLY0x+n3/i2YgnFujEgGztqSl5SFE8artsXk07a59rTIUTRYaD86DcyLxTkP3tFk1u P/xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=whwn4kz9UWwexm2xdfTo7WqiWJxPep/1iCvvWYArttw=; b=tbaQUu3RQn55sp8i4Mk1itL6B8wqIWvw9d4RGmvhqJmpw/luLF62WU3/0iYMdC2W1p 3IgYsrJRXfbor7edjV7tL5qCMKbAr92WyOfbEs3k5pLqVzmJlojuXpidq6s9UZ4mRqzW ObaB7TxAbcMZyAAbYFVUzJsilYv7O0AyPXgYJ98KOBJoJTFeTbHMxdO3N5kSt13mav1G mUaamX9LWs23bnp1GNIpWQXESDrUfoqZKbVpdS1lLm261KtT+49vcJ7j+AlLqRtv/M0s iza0kOPg+RsvXSRCs4GMI4hfhMUhEzvfElVYil91SMae4D7Zc4tMjHVTNas3/NJD7zWh Igsg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id g5si103756wmi.3.2020.09.01.09.57.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Sep 2020 09:57:57 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 081GvuwC017574 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 1 Sep 2020 18:57:56 +0200 Received: from [167.87.132.216] ([167.87.132.216]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 081GvsPc025451; Tue, 1 Sep 2020 18:57:55 +0200 Subject: Re: [RFC PATCH 00/10] WIC update To: "vijaikumar....@gmail.com" , isar-users References: <20200824092750.19642-1-Vijaikumar_Kanagarajan@mentor.com> From: Jan Kiszka Message-ID: <78efe825-8fc2-e281-67ec-627887567172@siemens.com> Date: Tue, 1 Sep 2020 18:57:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: lcw9qMzDa8hg On 01.09.20 18:53, vijaikumar....@gmail.com wrote: > > > On Monday, August 24, 2020 at 2:58:19 PM UTC+5:30 > vijaikumar_...@mentor.com wrote: > > The following series updates the wic to the latest one from > openembedded core. The git tree is available here. > > https://github.com/vj-kumar/isar/tree/wic/staging0 > > Below are summary of key changes in the below series. > > P3 & P6: > The latest version of WIC detects the presence of fakeroot using > pseudo_dir(${IMAGE_ROOTFS}/../pseudo). If this is non-existent it > doesnot > use fakeroot. P3 handles that quirk. There is also a standalone > invocation of > pseudo which P6 tries to handle via wic_fakeroot. > > In case of ISAR, we need wic_fakeroot as fakeroot only for 2 purposes. > 1. To workaround fsck return values for stretch > 2. To handle standalone invocation of pseudo(P4 in series) > > Number 2 is not needed if we dont use fakeroot. > > The alternative approach to fakeroot is to carry patches on top of wic > directory instead of working around such quirks using fakeroot. The > downside > being the need to rebase the local changes on future updates of wic. > > > P4 & P5: > These cherry-picked changes address the --exclude-path issues which > Henning > has addressed in [2]. Should be dropped once that is merged. > > P9: > P9 is needed for --include-path to work. I have observed that > --include-path > does not yet work/broken in the latest OE-core/poky. Posted a query > in [1]. In ISAR > it works with P9 fix. P9 fix could also be relevant upstream and can > be sent there > for review. > > > P9 fix is sent to OE-core mailing list. Currently in master-next. > Hopefully should get merged. > > https://lists.openembedded.org/g/openembedded-core/message/142048 > > I will send a V2 with updated P9 commit. > I would cherry-pick and carry P9 version from OE-core once it is merged > to master. We could drop that > the next time we update wic. > > FWIW, --include-path is fixed in OE-core with the below patch. It is > merged to master. > >  https://lists.openembedded.org/g/openembedded-core/message/141865 > Great, well done! Jan > Thanks, > Vijai Kumar K >    > > > Apart from the normal qemu build test, Below are the list of > features tested. > KS API: > --exclude-path > --include-path > --fsuuid > --overhead-factor > --fixed-size > --use-label > --use-uuid > > Standalone invocations: > wic ls > wic cp > wic rm > > Currently in the process of finding a way to test wic features > automatically. Some wic features > like -fsuuid cannot be validated till we boot the target. Need to > find a generalized way for > testing the available wic features. The approach in hand is to use a > wic-test.wks file and > generate qemu image with that to validate the wic features. > > [1] https://lists.yoctoproject.org/g/poky/message/12151 > [2] https://groups.google.com/g/isar-users/c/xePCyEl2qhM/m/mwFdeou0AQAJ > > > Henning Schild (1): > lib/oe/path: try hardlinking instead of guessing when it might fail > > Paul Barker (1): > oe.path: Add copyhardlink() helper function > > Vijai Kumar K (8): > wic: Update to the latest wic from openembedded core > wic/plugins: Fix wic plugins to work with the latest wic > wic-img: Satisfy the quirks of latest wic > wic_fakeroot: Handle standalone pseudo invocations > meta-isar/conf: Add provision to debug WIC > debian-common: Add tar as a dependency for wic > scripts/lib/wic: Add /bin to the list of searchpaths > meta-isar/canned-wks: Remove /boot mountpoint > > meta-isar/conf/local.conf.sample | 3 + > .../lib/wic/canned-wks/common-isar.wks.inc | 2 +- > .../scripts/lib/wic/canned-wks/hikey.wks | 2 +- > .../lib/wic/canned-wks/sdimage-efi.wks | 2 +- > meta/classes/wic-img.bbclass | 15 +- > meta/conf/distro/debian-common.conf | 3 +- > meta/lib/oe/path.py | 27 +- > .../wic/plugins/source/bootimg-efi-isar.py | 2 +- > .../wic/plugins/source/bootimg-pcbios-isar.py | 9 +- > .../lib/wic/plugins/source/rootfs-u-boot.py | 2 +- > scripts/lib/scriptpath.py | 32 ++ > scripts/lib/wic/__init__.py | 14 +- > scripts/lib/wic/canned-wks/common.wks.inc | 2 +- > .../directdisk-bootloader-config.cfg | 8 +- > .../lib/wic/canned-wks/efi-bootdisk.wks.in > | 3 + > scripts/lib/wic/canned-wks/mkhybridiso.wks | 2 +- > scripts/lib/wic/canned-wks/qemuriscv.wks | 3 + > .../lib/wic/canned-wks/qemux86-directdisk.wks | 2 +- > .../lib/wic/canned-wks/sdimage-bootpart.wks | 4 +- > .../lib/wic/canned-wks/systemd-bootdisk.wks | 4 +- > scripts/lib/wic/engine.py | 421 +++++++++++++++- > scripts/lib/wic/filemap.py | 170 ++++--- > scripts/lib/wic/help.py | 401 ++++++++++++++-- > scripts/lib/wic/ksparser.py | 115 +++-- > scripts/lib/wic/{utils => }/misc.py | 100 ++-- > scripts/lib/wic/partition.py | 234 ++++----- > scripts/lib/wic/pluginbase.py | 36 +- > scripts/lib/wic/plugins/imager/direct.py | 175 ++++--- > .../wic/plugins/source/bootimg-biosplusefi.py | 213 +++++++++ > scripts/lib/wic/plugins/source/bootimg-efi.py | 111 +++-- > .../wic/plugins/source/bootimg-partition.py | 153 ++++-- > .../lib/wic/plugins/source/bootimg-pcbios.py | 91 ++-- > scripts/lib/wic/plugins/source/fsimage.py | 56 --- > .../wic/plugins/source/isoimage-isohybrid.py | 185 +++---- > scripts/lib/wic/plugins/source/rawcopy.py | 44 +- > scripts/lib/wic/plugins/source/rootfs.py | 159 ++++-- > scripts/lib/wic/utils/__init__.py | 0 > scripts/lib/wic/utils/runner.py | 114 ----- > scripts/wic | 452 +++++++++++++----- > scripts/wic_fakeroot | 5 + > 40 files changed, 2340 insertions(+), 1036 deletions(-) > create mode 100644 scripts/lib/scriptpath.py > create mode 100644 scripts/lib/wic/canned-wks/efi-bootdisk.wks.in > > create mode 100644 scripts/lib/wic/canned-wks/qemuriscv.wks > rename scripts/lib/wic/{utils => }/misc.py (70%) > create mode 100644 > scripts/lib/wic/plugins/source/bootimg-biosplusefi.py > delete mode 100644 scripts/lib/wic/plugins/source/fsimage.py > delete mode 100644 scripts/lib/wic/utils/__init__.py > delete mode 100644 scripts/lib/wic/utils/runner.py > > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google > Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to isar-users+unsubscribe@googlegroups.com > . > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/ce2f12b7-f976-41b3-ac52-977bd2a2b8a3n%40googlegroups.com > . -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux