From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7235862407233404928 X-Received: by 2002:a05:600c:2044:b0:3f7:e535:ff3b with SMTP id p4-20020a05600c204400b003f7e535ff3bmr517081wmg.3.1685948461921; Mon, 05 Jun 2023 00:01:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:3b99:b0:3f6:77a:31af with SMTP id n25-20020a05600c3b9900b003f6077a31afls210728wms.1.-pod-prod-08-eu; Mon, 05 Jun 2023 00:01:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6sawf7sBr4F1X3eeTjAMjfX0dGUyWmih5rIL+RDAMiqdeHpkHJxWzr2/5Oasa/qTYhsjeG X-Received: by 2002:a05:600c:22da:b0:3f7:395e:46a2 with SMTP id 26-20020a05600c22da00b003f7395e46a2mr1696848wmg.16.1685948460365; Mon, 05 Jun 2023 00:01:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1685948460; cv=pass; d=google.com; s=arc-20160816; b=tNaKGWyD1DErxNd8IhgEmbGa3HOpd7mm3qkvL2TXZWPFeJZX4niAZ5mWRzqRoY3BbS xy0v2irP+gHKPZ9MU+9Vv97RRrQPOprlODhlsjDVkfyvA7bfEOla1s8HwB6M34ZXcOVv Wj+isCSkxj+af27OJYPHgPmDI5jxLlkawLnUvGnGWBdYABwPeXtzUSf5DX2GBt6Oxjzr UBBX65NtIr70OELi7z1mnGB1sZ+UsjMMzJ1NxdsgIvtQ6ZY1eU1WZwwB7CrX/cjNrDvK +M7AKW3wj+88zaI6heu9y2njT/1m/WsgAaq8JP8bviFIAOkoZ3fwzHyBPU5dvBC4n6Qh w18A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=K+vOiCuBcUxRmpcmWwWlY5IYSVB4l1/lzQ1/L5y/qTU=; b=tgDda750T/VzNs1BYd7iGyJbr0HJyk5XA4yeTucAgfHG0rQ5heuGeO7aU9ZLI85dnn OyIxX9agX9+5mCsdiUvYr2bHTgcqxy6LFe17RfbG0UGbpqckNEP/k6K7vAT+foP0cekx DMiOLyMziOli7UecaBg8vz/ubaMfLhXMGZCkHaAt+QczrjgvfHYHem6WJ19kpvp5Hvn9 FkHAvd7+a9iPlNkuy5dclxk/hp5zC0evk2UuvFatMgWzPrmOLcRyMlmCev+YKjZ/REfG K6iAKAulehQJsGAfODGYcOVCPja+qevt1MzxwFHfx8VavucuS3L2gX/J0JYMjgRAEwL3 79AQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=f4tYrwxV; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0d::62f as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on062f.outbound.protection.outlook.com. [2a01:111:f400:fe0d::62f]) by gmr-mx.google.com with ESMTPS id p16-20020a05600c1d9000b003f6069b86d0si834931wms.2.2023.06.05.00.01.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jun 2023 00:01:00 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0d::62f as permitted sender) client-ip=2a01:111:f400:fe0d::62f; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=f4tYrwxV; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0d::62f as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YVx43c7Ti9mhK+PYYuBhmocTHEE12bysYXk0uqxqDz1zJsVVhV5Y+JXyfijf5hbv0hSU7ySOnMMKygaEEoUMyiJIGNCZn3mncZdREcjJbc0PY8/+6cLeg23GJIFlNV0rSqt3/Fc5gh9JLdRc/V/7NYOus5x/vkB76Rk9oZKYQHr3zbNqcyLVEYCF3WRMbzGwWPvU9wZasrfLHEfYXd3yBuKZm2NjPniZIaOIf4ujyODuk5JpCBzVRl70q5yThqU2/g98Vsl8TE3O3CFybRWR7IOEfllnnoZdAnacnWS7m5GpnHthjQTJHpVYat6vttV73zH2EMqwIrtvnBx+B05lAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K+vOiCuBcUxRmpcmWwWlY5IYSVB4l1/lzQ1/L5y/qTU=; b=U8PBcYZu2bqEKrft2qmyAuZQKrVi6cmJA2/dvC4GKuheh7yLMUTRGogctdBIV9+J2YFMj1TZnz7ocJGkLOH3qLE8Cqk30rzZ09ceBMj4AICrGak+dBxKC0JVr0XS/YcTzIOdkRJww2LJ4Pg69k5S4QNnEJpfe+fIPWPllmVTyd7uctcuhStCSuZwisYpPaRrAq3rsbHy0SXG8pCphMpGs0tZRtW6odWcAqZQm0TLya7u0CYAICRUWgiEoWrLeHMQBONgswHMx6+ry7MljM/uwvzu8nLlD/NLovGdExFN5noKCKbnylzNahz0b2vcN+KMjCU+6L/B2o0xQdsUnqIc1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K+vOiCuBcUxRmpcmWwWlY5IYSVB4l1/lzQ1/L5y/qTU=; b=f4tYrwxV5bVeOwTyK5SMMLQp5SPdJCcFVmyqV/4Oi0ak18l3ohDnDxRMuly+BhZqFuS1Uh8GNdYzSAjZK//5lahxhncFGGasDQlHujuNkYUOccJU+48pIqTd/8qDqqHJrYyzZY1ScfV0qKQ32TonyaLvaD5wu0A16VYas/A1SZtK6Nz6ExZ8mRE9Fgd3C7A2daHKL8I62XLbSwnxF9w1rRl9iVlF3TeHncTyQTioKakkBeYGtIkIKTb7ibPlGSLBASv8ApXFAZsH6VKGnsUYSyNv12ZLyy/X5U5JnoKZ+LSm0jNCsJY/L8i0M6zzq7gHKCNy3XifF5Lr5NxWsgmmpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by AS8PR10MB7497.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5ac::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Mon, 5 Jun 2023 07:00:59 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2ecd:9a8a:5601:47e4]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2ecd:9a8a:5601:47e4%6]) with mapi id 15.20.6455.030; Mon, 5 Jun 2023 07:00:58 +0000 Message-ID: <78f99600-592a-b3c3-7fee-791e2116abdf@siemens.com> Date: Mon, 5 Jun 2023 09:00:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] meta/classes/crossvars: move sdk toolchain selection from python block Content-Language: en-US To: Srinuvasan Arjunan , isar-users@googlegroups.com Cc: amikan@ilbers.de, Srinuvasan A References: <46a03938-0343-4221-a57c-efba80b27c83@siemens.com> <20230604093216.1094289-1-srinuvasan_a@mentor.com> From: Jan Kiszka In-Reply-To: <20230604093216.1094289-1-srinuvasan_a@mentor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::15) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|AS8PR10MB7497:EE_ X-MS-Office365-Filtering-Correlation-Id: 43e87589-609f-4f93-fb07-08db65929da4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DdpBKMfKnJL0S2tRvOSyANVb6gBU4hP1A/IPk/vq+m6Xl8S04HN1wZsGt1eAvzATPSzAnUN3RNWg6t1Y0dLnERUoWx7eDbop6RQCP8ftWHM9wtz61L2MWl4DKs6H0eeKWv75GaS3t3OUqBzgWp40vzsdqqWM3IcqSB9kGtqNJqtUXV4Bt/N8RrJ/kgX0jJYVR3fur+ydl4vdWGxpSEv8LDfy/PqgkOo2Y5SF41AURKY8AxYO12CgkZF8cFGQTwaHvGyMZ2iRxNv8OGlYyqCGFZ+E9apJ1yjYVByOb3+eZ7zCbCn1kYjIqreWU6a2bLvL+N46bKcMuoRBTAvy7Jo+8Pv+iREV8KlyV07pzk5rPTpHJdTB+skvRckVMq/JE0CumsWKcstITW7KdDHSGz5LA1q+9vkXQsvRKzS6JEk5mpwM3us/8gy13NbfNmba6sa100crWi9LSzqp2ogda2AJ1tApwq7UoCKkywz7rRhrdyASjyH+xa5jzHVWDZ2CPqoYzT9epiWs6wNtQ3IC/r2X86AOXKTVq2u+nHA/ccxUKHm9rGiYA8S1cWmmHMIzJQWyyXEX0NZmfEDrwSqxUjioYqcx+RI+KK1U40LBJ1iwTIgGlVj3SrivzmXpoOjNwIlU60yh+VLIB849TVnX9MyQAQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(451199021)(6486002)(82960400001)(2906002)(66476007)(66946007)(66556008)(8676002)(36756003)(38100700002)(8936002)(5660300002)(44832011)(86362001)(31696002)(41300700001)(4326008)(316002)(478600001)(2616005)(53546011)(6512007)(6506007)(26005)(107886003)(31686004)(186003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RU1tdytqcFBzempjN08vVU90MHNGeU9JdjdndE93ZWxianpUaDVkR3QzOGtY?= =?utf-8?B?VU5EbHpJWlhDUUROemtKODU4eGsrN1lyRURNTVI4ZTJRWUdpbUd1NHpkeTly?= =?utf-8?B?Ry81akZuQTBrbTY1SUU4N1NtYTBOa0xaSzdyOGhSQ1NUMnJYTk9lVDJ3TXZF?= =?utf-8?B?RHlCR21GQnR6K2FrMFQ4RU5JWmxkVVhrTytyei9Rc0RJRXRycU9hMTdROFdZ?= =?utf-8?B?TlpheDQ3NG5IRmpDNHh2eVB5OVRTMXNhU2c1VHN3clNrQTZSSndXd3cyZlgz?= =?utf-8?B?YzhYdEMvRjNQK0VVTHJqaHpKcElJWmptTC8rcmhhTzkxL1I4SEpoN0lDTWpw?= =?utf-8?B?eXV0cFl4K0c4Tm5iN0RmdkFZQS9JZmM5YW1mem1wSlM0ZmFYakdDZ240dDZM?= =?utf-8?B?MjlDWEVVNENwekNJc0pwcmNMNU1RemhrN0hPZnBidi91UmljM3l1QWE5YzNa?= =?utf-8?B?dldIQzQ1Vlh2b1d4NzF4SXBRTTErMVV0czBIaVE5b2FUOURKTkNhaFd4MzlU?= =?utf-8?B?dVNhUXZ4NzVxOWxoKzA1NGFDTGZUTCtkTmZjVnlnSjd5MHNNNnJoQjZsQ2NF?= =?utf-8?B?SnE2YVg1SzBKM1ZFeG1RZytvWTZ1Qk8wTU1DaUNTUUVsamp4N1dSS2cvK3Fi?= =?utf-8?B?bW04MWNMTVk4QllmM1Q3bXViazBHNGtqOEllZ1NzRXRIWkpmSFdZZnFwVzBN?= =?utf-8?B?c2ZGcDR4em9Va0crTXpwMmQrbDhkRGFvTGFQZTdmZmhvNFhQL0s3UUVMMXNV?= =?utf-8?B?SmxEL0lzSGR1MlJka0gvNzZUUUdzSW9ieVV0cm5ZUkRSUjIrQzVjQnpNVXE5?= =?utf-8?B?Vks1WVhFcDROV1drc1FwbnZNWjE5SWZ4K3BleFdhd0xXOXJyTEowekNuTkQw?= =?utf-8?B?K1c3YlRsckRMRjQ1d0hQTEFnamJ1c0RHWFU3NTdPMW03ejlHWDFYdEdjcHpB?= =?utf-8?B?YTIrSG1yMEtucCs1Z20vYVFNMENqTk11SGprczhYaXhjbGNrRys4NVhEZXVV?= =?utf-8?B?cnkzRkdVMTdIQjJHMnk1UFYrVXY2b2dLRTI0dzB5VTRWandtR1hoUHNkRnJX?= =?utf-8?B?ZVZsVHVvUDhFMmt5Vys0RFhkMXAvRVhnM2hCRjFSeTBwMFl6NXJRSjZSS01x?= =?utf-8?B?cUNwL1JFSWJBVUJPbUNrL1NVQVhiLyttYkt3SFRBSmpyQkZ1dG9oemlBYkdF?= =?utf-8?B?QVhjZk9pNEVaSWdlVHptbFFIZS8wejMxdkhaS3ptMGZKd0Nsb1hmVUR6V25S?= =?utf-8?B?dW5aamozMTVDNi9LRkw0ZlhTeVdFK0xFVzV5aUdBeW9JcG1idi9IZHJvOUhz?= =?utf-8?B?ajRyU0JSQmQvNGFhWm1jYUVBTmd1MTFIMnpFNEFoaTJvaEdXbis1elIxRmpm?= =?utf-8?B?SXZuYTNUNkZXd3BqdDRxOWtkTmp6eTNDcko4cCtPMVJSZlE3NGRLZERIR1oy?= =?utf-8?B?bVlwVWc2dlFCNHJmK1R0VlJKZXU3bWQvcjFMN1dPNi9mSnJTSFE1RWVhQ1Ba?= =?utf-8?B?UmhkcnF3NStyNHc0TURhQUNWN01iYnFqY09JZ3QrZXVNbjRvSlZySmRaZUcy?= =?utf-8?B?UmowTWVnRE9JNjluVzdHV1NrM1MrNFFxMTlxUDJmWjdZYXo1R0hUd0JmRVNJ?= =?utf-8?B?ZE9IODRpYWh6Q3FpckVXdEp3dzlxNHUwZDlnYkNmcWlvYTA0WG1qZUFwREZq?= =?utf-8?B?Njc4NVdmdG54eGY0bTFqSUlOTWdhYnhIM3RkK1Qzb1pyYmZCMFFsaW03S0Ns?= =?utf-8?B?WkJXVncvSG9razdycDR4eUkyWmxYZWJUZlhrRGN4RXJSbkdOQTNEZGR1bXhz?= =?utf-8?B?M3JXL0R0OUFNTGhrNURuVDh3N1ErZmorMjRqRXhLRHpzcW51eGdyZkg0M3Ra?= =?utf-8?B?SWJ0UktMN1BGKzJjVFcyUVRwbVRiRjZVUHNqemlCSDdkOElFQ040V04zaEth?= =?utf-8?B?NGR3SUFaUS8vK1ZzT1h3QXJwZjFlR3hQNHdJQUxqVzNFS0t4TCtFZE4zV09x?= =?utf-8?B?WjhQdzVZam5lNjNSWGxVRmlPUGFrcjBhQm9DREJnTXZ0cUI5SGVQL2VVbEZZ?= =?utf-8?B?NVVxY2RaQmZZWjBCNCtHV3hla3VQYW5NZlRHZTIvMENpLzlkSzlXU05rRXNV?= =?utf-8?B?VlVQbm0rRWJqTll5TE5VVHdhSjF2Qlc5Ykx4R1hVeUFpbGhZWEVaaGU5aC9T?= =?utf-8?B?YXc9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43e87589-609f-4f93-fb07-08db65929da4 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 07:00:58.8794 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oARfg/XKulDGXd8gWPetvl3MuAfeWed17GdQLn5Snup/NySO308hq9meuR5W0vugj9q9yZ8Zl7tDLkYtko4/eQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7497 X-TUID: jDOT4tm2OFP9 On 04.06.23 11:32, Srinuvasan Arjunan wrote: > From: Srinuvasan A > > In the present implementation we are not able to override the SDK > toolchain from downstream layer, this is due to the SDK toolchain > selection part in anonymous python function. > > Anonymous python functions always run at the end of parsing, regardless of where they are defined > even when we do override in our recipe, always wins the Anonymous Python > functions variable settings, hence we are not able to override our > downstream toolchain. > > Move the SDK toolchian selection from python block, now we can able to > override from downstream layer. > > Signed-off-by: Srinuvasan A > --- > meta/classes/crossvars.bbclass | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass > index 201d460..120e6d1 100644 > --- a/meta/classes/crossvars.bbclass > +++ b/meta/classes/crossvars.bbclass > @@ -5,6 +5,10 @@ ISAR_CROSS_COMPILE ??= "0" > > inherit compat > > +SDK_TOOLCHAIN = "${@'build-essential' if d.getVar('ISAR_CROSS_COMPILE') == '0' or d.getVar('HOST_ARCH') == d.getVar('DISTRO_ARCH') or d.getVar('DISTRO_ARCH') == None else 'crossbuild-essential-${DISTRO_ARCH}'}" > + > +SDK_TOOLCHAIN:append = "${@' crossbuild-essential-${COMPAT_DISTRO_ARCH}' if isar_can_build_compat(d) else ''}" > + This is still no weak assignment which you will need for overrides. Did you actually test this? And, again, can't we implement the weak assignment in python below? Jan > python __anonymous() { > import pwd > d.setVar('SCHROOT_USER', pwd.getpwuid(os.geteuid()).pw_name) > @@ -17,19 +21,14 @@ python __anonymous() { > sbuild_dep = "sbuild-chroot-target:do_build" > buildchroot_dir = d.getVar('BUILDCHROOT_TARGET_DIR', False) > buildchroot_dep = "buildchroot-target:do_build" > - sdk_toolchain = "build-essential" > else: > d.setVar('BUILD_HOST_ARCH', d.getVar('HOST_ARCH')) > schroot_dir = d.getVar('SCHROOT_HOST_DIR', False) > sbuild_dep = "sbuild-chroot-host:do_build" > buildchroot_dir = d.getVar('BUILDCHROOT_HOST_DIR', False) > buildchroot_dep = "buildchroot-host:do_build" > - sdk_toolchain = "crossbuild-essential-" + distro_arch > d.setVar('SCHROOT_DIR', schroot_dir) > d.setVar('SCHROOT_DEP', sbuild_dep) > d.setVar('BUILDCHROOT_DIR', buildchroot_dir) > d.setVar('BUILDCHROOT_DEP', buildchroot_dep) > - if isar_can_build_compat(d): > - sdk_toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH') > - d.setVar('SDK_TOOLCHAIN', sdk_toolchain) > } -- Siemens AG, Technology Competence Center Embedded Linux