Re: [PATCH 2/3] meta: Set LAYERSERIES_* variables

[Jan Kiszka <jan.kiszka@siemens.com>]

On 07.11.18 18:24, Maxim Yu. Osipov wrote:
> On 11/7/18 7:41 PM, Jan Kiszka wrote:
>> On 07.11.18 17:39, Maxim Yu. Osipov wrote:
>>> On 11/7/18 7:20 PM, Jan Kiszka wrote:
>>>> On 07.11.18 17:09, Maxim Yu. Osipov wrote:
>>>>> Fix warnings after update to the latest bitbake.
>>>>>
>>>>> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
>>>>> ---
>>>>>   meta-isar/conf/layer.conf | 1 +
>>>>>   meta/conf/layer.conf      | 5 ++++-
>>>>>   2 files changed, 5 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/meta-isar/conf/layer.conf b/meta-isar/conf/layer.conf
>>>>> index 4aa1cf1..b4b90c1 100644
>>>>> --- a/meta-isar/conf/layer.conf
>>>>> +++ b/meta-isar/conf/layer.conf
>>>>> @@ -14,6 +14,7 @@ BBFILE_PRIORITY_isar = "5"
>>>>>   # This should only be incremented on significant changes that will
>>>>>   # cause compatibility issues with other layers
>>>>>   LAYERVERSION_isar = "3"
>>>>> +LAYERSERIES_COMPAT_isar = "sumo"
>>>>>   LAYERDIR_isar = "${LAYERDIR}"
>>>>> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
>>>>> index ab6ae8e..6fefca6 100644
>>>>> --- a/meta/conf/layer.conf
>>>>> +++ b/meta/conf/layer.conf
>>>>> @@ -11,8 +11,11 @@ BBFILE_COLLECTIONS += "core"
>>>>>   BBFILE_PATTERN_core = "^${LAYERDIR}/"
>>>>>   BBFILE_PRIORITY_core = "5"
>>>>> +LAYERSERIES_CORENAMES = "sumo"
>>>>> +
>>>>>   # This should only be incremented on significant changes that will
>>>>>   # cause compatibility issues with other layers
>>>>> -LAYERVERSION_core = "1"
>>>>> +LAYERVERSION_core = "11"
>>>>> +LAYERSERIES_COMPAT_core = "sumo"
>>>>>   LAYERDIR_core = "${LAYERDIR}"
>>>>>
>>>>
>>>> That looks... weird. Does bitbake now actually have Yocto release names 
>>>> encoded???
>>>
>>> Absolutely agree, but warning comes from the latest bitbake:
>>> lib/bb/cookerdata.py:                    bb.warn("Layer %s should set 
>>> LAYERSERIES_COMPAT_%s in its conf/layer.conf file to list the core layer 
>>> names it is compatible with." % (c, c))
>>>
>>
>> OK, but does the value have to come from a restricted set? Or can we use that 
>> to declare layers compatible with specific Isar releases?
> 
> Of course the value could be our own - (it was restricted by my fantasy :)), 
> f.e. we may set to LAYERSERIES_CORENAMES = "isartor"...
> 

Ah, ok. As we have no release names, I would suggest version strings.

How is this variable evaluated (beyond testing that it's set)?

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux