Re: [PATCH v2] debianize: use debhelper-compat to generate compat file

[Gylstorff Quirin <quirin.gylstorff@siemens.com>]

On 4/18/24 2:15 PM, Florian Bezdeka wrote:
> On Wed, 2024-04-17 at 21:16 +0000, Moessbauer, Felix (T CED OES-DE)
> wrote:
>> On Wed, 2024-04-17 at 11:00 +0200, Florian Bezdeka wrote:
>>> Hi all,
>>>
>>> [CC: Clara]
>>>
>>> On Thu, 2024-02-01 at 11:12 +0100, 'Quirin Gylstorff' via isar-users
>>> wrote:
>>>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>>>
>>>> debhelper supports the versions debhelper-compat (= 9) till
>>>> debhelper-compat (= 13).
>>>>
>>>> This patch also adds the variable `DEBIAN_COMPAT` to set the compat
>>>> to the desired version.
>>>
>>> This introduces a regression. We are no longer able to build the rpi-
>>> firmware with that patch applied.
>>>
>>> Seems there are more side effects switching from debhelper to
>>> debhelper-compat.
>>
>> Hi Florian,
>>
>> these side-effects are expected and also required for many users. All
>> packages build for post buster should use debhelper-compat 13 as stated
>> in the policies. Not being compatible is considered a bug.
>>
>>>
>>> In our case something with the dh_dwz step goes wrong. TheELF file
>>> generated during build is no longer "recognized", or as a file with
>>> wrong input format. Clara can provide more information / logs if
>>> necessary.
>>
>> If dh_dwz is the issue, just overwrite that in the rules file.
> 
> The patch does two things at once:
> 
> - Switch from debhelper to debhelper-compat
> - Lifting the compatibility level from 10 to 13 (for bookworm)
Which is required by Debian - we should follow upstream with the policies.

Quirin
> 
> The later is causing trouble here. It seems to enable dh_dwz which
> turns out to be broken for arm64. Some Debian bugs indicate it's
> unfixable for bookworm...
> 
> For now no further action required. We can handle it here.
> 
> Just another "updating ISAR broke my layers" cycle. We're used to that
> (sadly).
> 
> Florian
> 
>>
>>>
>>> I have no solution/fix right now. As this is clearly a regression we
>>> should consider reverting.
>>
>> Please do not revert, but fix the package. Many users already rely on
>> the debhelper-compat 13 features (like tmpfiles.d support).
>>
>> Felix
>>
>>>
>>> Best regards,
>>> Florian
>>>
>