From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7245237195775148032 X-Received: by 2002:a17:90a:898f:b0:25c:1676:e89d with SMTP id v15-20020a17090a898f00b0025c1676e89dmr1352367pjn.4.1686914896771; Fri, 16 Jun 2023 04:28:16 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:90a:1286:b0:25e:8b14:b9c2 with SMTP id g6-20020a17090a128600b0025e8b14b9c2ls654369pja.0.-pod-prod-09-us; Fri, 16 Jun 2023 04:28:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ShRW5b06kkQwQ/85cR5P/G2FS2Hi+qKbK7p0pRSFMErmPHpKp93FXJnDslMH1vfiExB6V X-Received: by 2002:a05:6a21:32a0:b0:117:a86:6c7a with SMTP id yt32-20020a056a2132a000b001170a866c7amr2186199pzb.12.1686914895676; Fri, 16 Jun 2023 04:28:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686914895; cv=none; d=google.com; s=arc-20160816; b=aW5MmpY9gIDFCie2Wt/QslHzRUDDlfuw1gdA45X7DB2q+qmwfsuJr0qHQmvbmAAAUS e3AwfGYqvddV4gsVqt0Ul9SDT+w1uL8NfQaahYeAvqyTSmAPMAtmv27nzVcpIW8x5RgQ B5wKkHUhUISz74gaSstZOTAun4eivRiVScHtbpojtyF/beFs8SrvRnuE8bwVCdctBiNF AyyDC4XqgwarrKwyxMx6b8QflUNmlp1PZuKlnaRiema6yiz4ZsDY37lx+Qz6AFN5Y+ER vL7o0o4UWq5jwFZiS6/+neONK0eQGLEYDFCyDT2Uxl/VvW2M/QArhO/Ovm/6AFrk22w6 86ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=tzZhKFb0m7z4QcW5VpfifNSVsTbVSrqUhlKtxdmnLDs=; b=bE9AtTtgeXASbYTC7Jct6ftc/ZrJ43UthmaqT2yHjLR/RIColIxWF57/GTZ0MldMmf ksAer0wDIueRudoNFInrfgaNcR9Z8s+kCP3DpCm179jcoa5zFSU7IqMzadPXFgxQHzbX eTa7ucOlgTvYofrZ5U7OlqGTz3n8t+wRtuMZwGn/w1XfRBV1Njop+UF16jHAThrz5RzR OyBl5dIxqQq0yhsrivSjIy4mNcRkEignou1y3/kNRnxQixlqeGpKcsRLz6G0UhuSvfcx End9M3V3cSseQE83suRjVdVmUGa4AowDlsqvrLaUChoXXAQkvbDVZglKlteDVOQC4vvJ BnmA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id fc1-20020a056a002e0100b0064d71940f98si1745376pfb.5.2023.06.16.04.28.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Jun 2023 04:28:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 35GBS9bg032446 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Jun 2023 13:28:09 +0200 Message-ID: <794b4d4cf1163a2e3ec797c9326d6e3a9f310f06.camel@ilbers.de> Subject: Re: [PATCH v2] vm-img: move templates from meta-isar to meta again From: Uladzimir Bely To: Henning Schild , isar-users@googlegroups.com Date: Fri, 16 Jun 2023 14:27:59 +0300 In-Reply-To: <20230616110615.25091-1-henning.schild@siemens.com> References: <20230616110615.25091-1-henning.schild@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.2 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: hgD/dPaAvnbz On Fri, 2023-06-16 at 13:06 +0200, 'Henning Schild' via isar-users wrote: > The vm image class needs these templates to work in cases where > people > do not have their own copies in their layers. Having them in meta- > isar > means that layers using the class with the default templates would > have > to use that example layer as well. >=20 We had the similar issue with new `meta-test` layer we are going to use for CI purposes. Since it doesn't have its own copy of mentioned files (and some files for `imx6-sabrelite` and `phyboard-mira` in `meta- isar/recipes-core/images/`), we used the similar approach: ``` FILESEXTRAPATHS:append =3D ":${LAYERDIR_isar}/recipes-core/images:" ``` I'm still not sure we need to move any files to the "upper" layer, since `virtualbox` and `vmware` machines using them are defined in 'meta-isar' layer. But if we move files for vmware/virtualbox (in order to reduce downstream dependency from meta-isar layer), why we don't do it for phyboard-mira/imx6-sablrelite?.. > Fixes: 3ac61204e1ed ("replace custom OVA logic with imagetype logic") > Signed-off-by: Henning Schild > Reported-by: Clara Kowalsky > --- > =C2=A0meta/classes/imagetypes_vm.bbclass=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | = 1 > + > =C2=A0.../recipes-core/images/virtualbox/vm-img-virtualbox.ovf.tmpl=C2=A0= =C2=A0=C2=A0 | 0 > =C2=A0.../recipes-core/images/vmware/vm-img-vmware.ovf.tmpl=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 0 > =C2=A03 files changed, 1 insertion(+) > =C2=A0rename {meta-isar =3D> meta}/recipes-core/images/virtualbox/vm-img- > virtualbox.ovf.tmpl (100%) > =C2=A0rename {meta-isar =3D> meta}/recipes-core/images/vmware/vm-img- > vmware.ovf.tmpl (100%) >=20 > diff --git a/meta/classes/imagetypes_vm.bbclass > b/meta/classes/imagetypes_vm.bbclass > index 41f2af067331..cd56d31b0fe0 100644 > --- a/meta/classes/imagetypes_vm.bbclass > +++ b/meta/classes/imagetypes_vm.bbclass > @@ -6,6 +6,7 @@ > =C2=A0 > =C2=A0inherit buildchroot > =C2=A0 > +FILESEXTRAPATHS:prepend =3D "${LAYERDIR_core}/recipes-core/images:" > =C2=A0OVF_TEMPLATE_FILE ?=3D "vm-img-virtualbox.ovf.tmpl" > =C2=A0IMAGE_SRC_URI:ova =3D "file://${OVF_TEMPLATE_FILE}" > =C2=A0 > diff --git a/meta-isar/recipes-core/images/virtualbox/vm-img- > virtualbox.ovf.tmpl b/meta/recipes-core/images/virtualbox/vm-img- > virtualbox.ovf.tmpl > similarity index 100% > rename from meta-isar/recipes-core/images/virtualbox/vm-img- > virtualbox.ovf.tmpl > rename to meta/recipes-core/images/virtualbox/vm-img- > virtualbox.ovf.tmpl > diff --git a/meta-isar/recipes-core/images/vmware/vm-img- > vmware.ovf.tmpl b/meta/recipes-core/images/vmware/vm-img- > vmware.ovf.tmpl > similarity index 100% > rename from meta-isar/recipes-core/images/vmware/vm-img- > vmware.ovf.tmpl > rename to meta/recipes-core/images/vmware/vm-img-vmware.ovf.tmpl > --=20 > 2.39.3 >=20