public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'cedric.hombourger@siemens.com' via isar-users" <isar-users@googlegroups.com>
To: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"Kumar, Rakesh" <kumar.rakesh@siemens.com>
Cc: "Kiszka, Jan" <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/2] initramfs-fsck-hook: bump version, rename package and files
Date: Mon, 9 Sep 2024 03:15:36 +0000	[thread overview]
Message-ID: <79e61ebca511834ae147bc57e5fe8ab293c1b60c.camel@siemens.com> (raw)
In-Reply-To: <20240907165104.1825446-1-kumar.rakesh@siemens.com>

On Sat, 2024-09-07 at 22:21 +0530, Rakesh Kumar wrote:
> * Bump initramfs-fsck-hook version from 0.2 to 0.3.
> * Renamed package from initramfs-fsck-hook-ext4 to initramfs-fsck-
> ext4
>   for better readability.

Chances of breaking downstream layers are too high

> * Renamed hook and trigger files for better readability.
> 
> Signed-off-by: Rakesh Kumar <kumar.rakesh@siemens.com>
> ---
>  ...sck.ext4.hook => initramfs-fsck-ext4.hook} |  0
>  ....triggers => initramfs-fsck-ext4.triggers} |  0
>  .../initramfs-fsck-ext4_0.3.bb                | 20
> +++++++++++++++++++
>  .../initramfs-fsck-hook-ext4_0.2.bb           | 18 -----------------
>  4 files changed, 20 insertions(+), 18 deletions(-)
>  rename meta/recipes-support/initramfs-fsck-
> hook/files/{initramfs.fsck.ext4.hook => initramfs-fsck-ext4.hook}
> (100%)
>  rename meta/recipes-support/initramfs-fsck-hook/files/{initramfs-
> fsck-hook-ext4.triggers => initramfs-fsck-ext4.triggers} (100%)
>  create mode 100644 meta/recipes-support/initramfs-fsck-
> hook/initramfs-fsck-ext4_0.3.bb
>  delete mode 100644 meta/recipes-support/initramfs-fsck-
> hook/initramfs-fsck-hook-ext4_0.2.bb
> 
> diff --git a/meta/recipes-support/initramfs-fsck-
> hook/files/initramfs.fsck.ext4.hook b/meta/recipes-support/initramfs-
> fsck-hook/files/initramfs-fsck-ext4.hook
> similarity index 100%
> rename from meta/recipes-support/initramfs-fsck-
> hook/files/initramfs.fsck.ext4.hook
> rename to meta/recipes-support/initramfs-fsck-hook/files/initramfs-
> fsck-ext4.hook
> diff --git a/meta/recipes-support/initramfs-fsck-
> hook/files/initramfs-fsck-hook-ext4.triggers b/meta/recipes-
> support/initramfs-fsck-hook/files/initramfs-fsck-ext4.triggers
> similarity index 100%
> rename from meta/recipes-support/initramfs-fsck-hook/files/initramfs-
> fsck-hook-ext4.triggers
> rename to meta/recipes-support/initramfs-fsck-hook/files/initramfs-
> fsck-ext4.triggers
> diff --git a/meta/recipes-support/initramfs-fsck-hook/initramfs-fsck-
> ext4_0.3.bb b/meta/recipes-support/initramfs-fsck-hook/initramfs-
> fsck-ext4_0.3.bb
> new file mode 100644
> index 00000000..de19828c
> --- /dev/null
> +++ b/meta/recipes-support/initramfs-fsck-hook/initramfs-fsck-
> ext4_0.3.bb
> @@ -0,0 +1,20 @@
> +# This software is a part of ISAR.
> +# Copyright (C) Siemens AG, 2019
> +#
> +# SPDX-License-Identifier: MIT
> +
> +
> +DESCRIPTION = "Recipe to add fsck hook to the initramfs"
> +
> +DEBIAN_DEPENDS = "e2fsprogs,initramfs-tools"
> +
> +inherit dpkg-raw
> +SRC_URI = "file://${PN}.triggers    \
> +           file://${PN}.hook        \
> +          "
> +
> +do_install[cleandirs] += "${D}/etc/initramfs-tools/hooks"
> +
> +do_install() {
> +    install -m 0755 ${WORKDIR}/${PN}.hook ${D}/etc/initramfs-
> tools/hooks/
> +}
> diff --git a/meta/recipes-support/initramfs-fsck-hook/initramfs-fsck-
> hook-ext4_0.2.bb b/meta/recipes-support/initramfs-fsck-
> hook/initramfs-fsck-hook-ext4_0.2.bb
> deleted file mode 100644
> index 9860dbc8..00000000
> --- a/meta/recipes-support/initramfs-fsck-hook/initramfs-fsck-hook-
> ext4_0.2.bb
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -# This software is a part of ISAR.
> -# Copyright (C) Siemens AG, 2019
> -#
> -# SPDX-License-Identifier: MIT
> -
> -
> -DESCRIPTION = "Recipe to add fsck hook to the initramfs"
> -
> -inherit dpkg-raw
> -SRC_URI = "file://initramfs-fsck-hook-ext4.triggers \
> -           file://initramfs.fsck.ext4.hook \
> -          "
> -
> -
> -do_install() {
> -        install -m 0755 -d ${D}/etc/initramfs-tools/hooks
> -        install -m 0740 ${WORKDIR}/initramfs.fsck.ext4.hook
> ${D}/etc/initramfs-tools/hooks/fsck.ext4.hook
> -}

-- 
Cedric Hombourger
Siemens AG
www.siemens.com

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/79e61ebca511834ae147bc57e5fe8ab293c1b60c.camel%40siemens.com.

  parent reply	other threads:[~2024-09-09  3:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06  9:39 [PATCH] initramfs-fsck-hook: bump version and improve error handling 'Rakesh Kumar' via isar-users
2024-09-06  9:56 ` 'Jan Kiszka' via isar-users
2024-09-07 16:51   ` [PATCH 1/2] initramfs-fsck-hook: bump version, rename package and files 'Rakesh Kumar' via isar-users
2024-09-07 16:51     ` [PATCH 2/2] initramfs-fsck-hook: improve error handling and correct fsck path 'Rakesh Kumar' via isar-users
2024-09-09  3:13       ` 'cedric.hombourger@siemens.com' via isar-users
2024-09-09  3:15     ` 'cedric.hombourger@siemens.com' via isar-users [this message]
2024-09-07 16:59   ` [PATCH 0/2] initramfs-fsck-hook: version bump to 0.3 and error handling improvement 'Rakesh Kumar' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79e61ebca511834ae147bc57e5fe8ab293c1b60c.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kumar.rakesh@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox