Re: [PATCH v5 4/5] linux-custom: rewrite to no longer depend on the kernel's builddeb

[Jan Kiszka <jan.kiszka@siemens.com>]

On 11.12.19 16:20, Gylstorff Quirin wrote:
>> +do_build() {
>> +
>> +    # Print a few things that are of particular interest
>> +    print_settings
>> +
>> +    # Process existing kernel configuration to make sure it is complete
>> +    # (use defaults for options that were not specified)
>> +    ${MAKE} O=${KERNEL_BUILD_DIR} olddefconfig prepare || exit ${?}
>> +
>> +    # Check if the recipe's PV makes sense
>> +    KR=$(${MAKE} O=${KERNEL_BUILD_DIR} -s --no-print-directory
>> kernelrelease)
>> +    eval $(grep ^CONFIG_LOCALVERSION= ${KERNEL_BUILD_DIR}/${KCONF} ||
>> true)
>> +    if [ "${PV}-${KERNEL_LOCALVERSION}" != "${KR}" ]; then
>> +        echo "ERROR: Recipe version (${PV}-${KERNEL_LOCALVERSION})
>> does not seem to match the kernelrelease (${KR})!" 1>&2
>> +        echo "ERROR: Make sure the kernel version in your NAME/PV/PR
>> settings and/or CONFIG_LOCALVERSION are aligned" 1>&2
>> +        exit 1 > +    fi
> 
> we have some CI use case where we build the latest git release could we
> add something like this
> 
> -    if [ "${PV}-${KERNEL_LOCALVERSION}" != "${KR}" ]; then
> -        echo "ERROR: Recipe version (${PV}-${KERNEL_LOCALVERSION}) does
> not seem to match the kernelrelease (${KR})!" 1>&2
> -        echo "ERROR: Make sure the kernel version in your NAME/PV/PR
> settings and/or CONFIG_LOCALVERSION are aligned" 1>&2
> -        exit 1
> +    if [ "${PV}" =~ "latest" ]; then

I suspect you wanted to suggest != "latest".

> +        if [ "${PV}-${KERNEL_LOCALVERSION}" != "${KR}" ]; then
> +            echo "ERROR: Recipe version (${PV}-${KERNEL_LOCALVERSION})
> does not seem to match the kernelrelease (${KR})!" 1>&2
> +            echo "ERROR: Make sure the kernel version in your
> NAME/PV/PR settings and/or CONFIG_LOCALVERSION are aligned" 1>&2
> +            exit 1
> +        fi

We need some relaxation path for the check, yes. Given the other
versioning issue, I'm still trying to build a complete picture.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux