From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6768877611266342912 X-Received: by 2002:a2e:5357:: with SMTP id t23mr2563341ljd.227.1576079036248; Wed, 11 Dec 2019 07:43:56 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:1b6:: with SMTP id c22ls372484ljn.14.gmail; Wed, 11 Dec 2019 07:43:55 -0800 (PST) X-Google-Smtp-Source: APXvYqxgJ6l7SHl0EHBQ8x3YDEvh1QICmyCAI7Z/rmxXJqifmf8Ov3GfLP9yiw0H6BklcMXASdc3 X-Received: by 2002:a2e:9bcd:: with SMTP id w13mr2468036ljj.139.1576079035539; Wed, 11 Dec 2019 07:43:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576079035; cv=none; d=google.com; s=arc-20160816; b=uXExDsnqk+iGhLV3M/gLsib6a8+PZDzLY6jkCT9VdIfzHi+7sMF66CDbZTPvEi83If xZB8qMfcIofty74LZdc1siPrSnDjVNm4rqIDIYe/X0P8XHYGXLBKq4pxST5yJupXFjHT nTVmlK4RbFYMZ+P0z+KNlCaZ346RztuLo6oXxk2swd06DVn+F0Q77+9Kcle8IfCVaKFF rXlfGhrkmDd55I227HQu3aX28Yijd51po7l5Je0KHuNgYVh/Q7NOOszQeWXrj8LaRw1r dmNF6fspLRtyx3rIk38OmONSlr4t+PNicRX6SqtrvUDeZZCWoutYkz6vxAghtOH1//SW q8Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=+ot1rndg3sVyY5tMObmettEOMP2Ol/KoT2i8nSSTrTE=; b=vTC+yEtvhjDHPgYbrRvmDlnyqDU7TbzFuK8eZGV+AyAFHkF5FtDkgBHKztERP5SGv5 UnNh8F1pzepY1mxQZ/OIf9QShAlVfScxKv7c+U4AcTvLxqa6uZ/+r8k05iND9nswFKsG kdVpOozWa8ZBfg5178LrW/fpyFkd3YBCBv5baExhV0cYNce3h4JRvXWHEXH+KFHqCcAz YWv25hcqlUEKdbR7TpIJ8hw+wekBlH2/4mZthkF/iPxU43YWsaO5xG8ZhZozk/Fo6a6a 9xzmLzW1gSefM4ZJYYjjff8oTOLCcLlHTeG9xpAfssgjssgTrNJVPj65ILNYJ4jhmcZ9 JHwQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id j30si130368lfp.5.2019.12.11.07.43.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Dec 2019 07:43:55 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id xBBFhsxW025314 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 11 Dec 2019 16:43:54 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xBBFhsbO010256; Wed, 11 Dec 2019 16:43:54 +0100 Subject: Re: [PATCH v5 4/5] linux-custom: rewrite to no longer depend on the kernel's builddeb To: Gylstorff Quirin , isar-users@googlegroups.com References: From: Jan Kiszka Message-ID: <79f99cd5-208c-9968-3b78-08234a206e71@siemens.com> Date: Wed, 11 Dec 2019 16:43:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: b30fv1uyBBIZ On 11.12.19 16:20, Gylstorff Quirin wrote: >> +do_build() { >> + >> +    # Print a few things that are of particular interest >> +    print_settings >> + >> +    # Process existing kernel configuration to make sure it is complete >> +    # (use defaults for options that were not specified) >> +    ${MAKE} O=${KERNEL_BUILD_DIR} olddefconfig prepare || exit ${?} >> + >> +    # Check if the recipe's PV makes sense >> +    KR=$(${MAKE} O=${KERNEL_BUILD_DIR} -s --no-print-directory >> kernelrelease) >> +    eval $(grep ^CONFIG_LOCALVERSION= ${KERNEL_BUILD_DIR}/${KCONF} || >> true) >> +    if [ "${PV}-${KERNEL_LOCALVERSION}" != "${KR}" ]; then >> +        echo "ERROR: Recipe version (${PV}-${KERNEL_LOCALVERSION}) >> does not seem to match the kernelrelease (${KR})!" 1>&2 >> +        echo "ERROR: Make sure the kernel version in your NAME/PV/PR >> settings and/or CONFIG_LOCALVERSION are aligned" 1>&2 >> +        exit 1 > +    fi > > we have some CI use case where we build the latest git release could we > add something like this > > -    if [ "${PV}-${KERNEL_LOCALVERSION}" != "${KR}" ]; then > -        echo "ERROR: Recipe version (${PV}-${KERNEL_LOCALVERSION}) does > not seem to match the kernelrelease (${KR})!" 1>&2 > -        echo "ERROR: Make sure the kernel version in your NAME/PV/PR > settings and/or CONFIG_LOCALVERSION are aligned" 1>&2 > -        exit 1 > +    if [ "${PV}" =~ "latest" ]; then I suspect you wanted to suggest != "latest". > +        if [ "${PV}-${KERNEL_LOCALVERSION}" != "${KR}" ]; then > +            echo "ERROR: Recipe version (${PV}-${KERNEL_LOCALVERSION}) > does not seem to match the kernelrelease (${KR})!" 1>&2 > +            echo "ERROR: Make sure the kernel version in your > NAME/PV/PR settings and/or CONFIG_LOCALVERSION are aligned" 1>&2 > +            exit 1 > +        fi We need some relaxation path for the check, yes. Given the other versioning issue, I'm still trying to build a complete picture. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux