From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6633025437179052032 X-Received: by 2002:a7b:cd0b:: with SMTP id f11mr146919wmj.18.1544515972949; Tue, 11 Dec 2018 00:12:52 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:7c11:: with SMTP id x17ls287657wmc.12.canary-gmail; Tue, 11 Dec 2018 00:12:52 -0800 (PST) X-Google-Smtp-Source: AFSGD/XrIfBfooG3c0NqO0LCf6wCurIXFtP9ZMAX9tgmZ6HBOwSGdmCb1Ynbm6mXj7JWDYFyndAv X-Received: by 2002:a1c:aac9:: with SMTP id t192mr128703wme.23.1544515972553; Tue, 11 Dec 2018 00:12:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544515972; cv=none; d=google.com; s=arc-20160816; b=bLKbwvrvNBHkvRjwkKG751KCJVqDOSQGMG4HYSCE8GoPzmL3ha2V4vGJNj9l2kwmg+ mU6RYWmlyBRzP0s0xD5H5be3cWuovMvH0Gu7+/avG1mTecjRLq3xnOAmIRYjJLMyaL8D i1kGdTZG5f4Z3J78QyTNgXC5l1k7/tamtLL+ax88CNWG+X4LKFVkm2kqszJUNHA7Qq6f O+py1+kIu6hZPlX+00ry6wfEb0pQDQ027eNxyW3tCPjWWKCnvQ7R7nAiP62IItnPoAMm /ClTkUcvH7ppQcwdFu0D3lgYzfW+YJmtzrm5X/O8fTkTAvn2DjFEKab6pQQkDoQI1kIy FumQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=tEZj4itAMP9ovtqu9grDu+lzxN+eyEl6/Q6E0adRVbE=; b=SEvgbvtx7TzN5PFwoX4sOIdADNGYQcGDKwuP7kb0tgWFhcOQbnmfqu1aSNDjeGLep6 +RlFVo+Dana38HTZ9+wNrqNbcCFINgt5qUddIVXKjIJ1i3DMCLUcUMldomJ+Zjux8JKk ZkpgWMLIimW++jnom/Hj3ty3e4tbKqajvQT1GGw6DhlyqxCGoUAWFWxWOpAxANsw1RqD BNxYcz/NbIfVjcFx2eoe4n5IF8S9b/J7LqMbdpFGFut0d087Gun31TsAdKcFms2Eu22/ RYi8fRnCbvImbFZ230h94ni40xvqXDZUZXnwFHSHOJLwc+q0u3muSxBqb+0cc792+/hG 9irg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id r194si429332wmg.4.2018.12.11.00.12.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Dec 2018 00:12:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id wBB8Cogv017039 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 11 Dec 2018 09:12:51 +0100 Subject: Re: [PATCH] isar-events: Fix processing of /proc/mounts To: Jan Kiszka , isar-users References: From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: <7a323504-2124-ba21-86f7-987414505f5d@ilbers.de> Date: Tue, 11 Dec 2018 11:12:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 4kqemU+G/lea On 12/9/18 7:06 PM, Jan Kiszka wrote: > From: Jan Kiszka > > We have to read /proc/mounts completely before starting to umount. That > virtual file will change after each umount, and that could make us miss > some mount points. Applied to the 'next', Thanks, Maxim. > Fixes: 05d0fc43e9e9 ("isar-events: Improve umount handler") > Signed-off-by: Jan Kiszka > --- > meta/classes/isar-events.bbclass | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass > index 05b27e5..c4a6149 100644 > --- a/meta/classes/isar-events.bbclass > +++ b/meta/classes/isar-events.bbclass > @@ -18,10 +18,11 @@ python isar_handler() { > > with open(os.devnull, 'w') as devnull: > with open('/proc/mounts', 'rU') as f: > - for line in f: > - if basepath in line: > - subprocess.call('sudo umount -l ' + line.split()[1], > - stdout=devnull, stderr=devnull, shell=True) > + lines = f.readlines() > + for line in lines: > + if basepath in line: > + subprocess.call('sudo umount -l ' + line.split()[1], > + stdout=devnull, stderr=devnull, shell=True) > } > > isar_handler[eventmask] = "bb.runqueue.runQueueExitWait bb.event.BuildCompleted" > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov