From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7250097659913961472 X-Received: by 2002:ad4:5765:0:b0:630:44b:180d with SMTP id r5-20020ad45765000000b00630044b180dmr14639004qvx.25.1688457087642; Tue, 04 Jul 2023 00:51:27 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ad4:4e09:0:b0:635:e853:69c7 with SMTP id dl9-20020ad44e09000000b00635e85369c7ls4159646qvb.1.-pod-prod-06-us; Tue, 04 Jul 2023 00:51:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlFhU0jly7nSqOJW9mt+jZ8LU32+GXlwka+cNrvuBFlPwFsVB97MnHpP1yam489UUQ+qtBty X-Received: by 2002:a05:6102:407:b0:444:2302:29ce with SMTP id d7-20020a056102040700b00444230229cemr4734261vsq.28.1688457086963; Tue, 04 Jul 2023 00:51:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688457086; cv=none; d=google.com; s=arc-20160816; b=La04ZneZzu0qCl/tX29FMscyIqbSa1FgGfIdOUHuPVbtb9gPkQSbvi/dOjizoN4O/S xfXqMGySnvCOHkSsz/ivQjVwNRrgSOuoI92YfQOL1yUeDrJBITC4M3rFo8/m0ezanOj+ i8KezYqearVSV8GIy5bOjeIacsyXu5gILhmkLGJUUuDx+KKp6+FFAyVa3rVorwz4FxjT 6Vb+OTAZhYMu7lir5qdYDW0hflFSmrXDl/LNJCO/t0/NdE7U2qpwags+Dr1ZCUCEV7vI kQP8g2FZCRkt8h2Z5O4t59e/ASh2W0/WQsVBBjqsA0qTsksEFwd5H7F7U3grltZZZQMg xB2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=We31xIascdo8S3IBfuDU8On4xFdzppfJT2ocjch2EzY=; fh=5a6hkQp4/Gk5A4S+jOQQm0zXm8w6cFNlaYHg5e/4IHs=; b=Ahc4VHxkjRj5J+CntI+sv0ME/Kj/449L3S0hRfZ0cKE7Ll+n2G6mGWqjFePRkZtCWN fpMDtrfIdxSMeCfCr+Octnt/tyBkL3DoJGhvfUm+jwF3WISbTpoLqZzpJvfwEjwVC2VD Yp1pYFRtvaRYdpUi4xuQ32I1u5s5yS0nyUhjUg/KP8+e15F0CR0PC3zmxQ1WR+2MXcvT 1EEH+JmZMBd+EQz2BAjtDsP7duG+/ucWuo2w1khbYXUriSgNd80I/24lUHtkQFGd4gWi x6a7C9loiPL8GOlpyEL2dAJZnjxiXFjknmS+89in/bxMAYidJyPvU1X2QIucJAsbnAcX OWjg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=e6allgjv; spf=pass (google.com: domain of ch@denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=ch@denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gmr-mx.google.com with ESMTPS id d4-20020ab007c4000000b0078f49ecc442si2583459uaf.1.2023.07.04.00.51.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 00:51:26 -0700 (PDT) Received-SPF: pass (google.com: domain of ch@denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=e6allgjv; spf=pass (google.com: domain of ch@denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=ch@denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Received: from [10.88.0.66] (dslb-088-077-007-063.088.077.pools.vodafone-ip.de [88.77.7.63]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ch@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1376184773; Tue, 4 Jul 2023 09:51:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1688457085; bh=We31xIascdo8S3IBfuDU8On4xFdzppfJT2ocjch2EzY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=e6allgjvFLJjAu+U6owgbB930kfWwmM0mXE+pki0jFdvifyJy6l/JjrVVWGlx0U1M AaPCeeo6IYKrfrUEQTFs71JGG4SsnO2L3siS/8Ad14hxyljEstnxa+M/QG2CqmmyAs g+7AHrERQLXmV4giXYVn6jYK6es7ur1yPZOnWpJZG/dfJ8FUDabcVYd9lRyEwUn5oo OH54RF6oOvBmGotUIFGTQvvTvquup9iV4UK6QTsFlzBXYdoVNaIGCG0halPn81Zoku u4tVc/RTHbVOJEUhIGlyNkuV4Dg7Tg7cHTLdfH+00pwOVZBButZXiirU3Om9FUs80t +WKHr8iBuSAMw== Message-ID: <7a618f39-d59d-a60f-ba69-ef4af43369bd@denx.de> Date: Tue, 4 Jul 2023 09:51:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH 1/1] linux-module: append local files path to FILSPATH Content-Language: en-US To: "Kanagarajan, Vijaikumar" , "isar-users@googlegroups.com" , "Vijaikumar_Kanagarajan@mentor.com" References: <20230629132107.2202204-1-ch@denx.de> <20230629132107.2202204-2-ch@denx.de> From: Claudius Heine Organization: Denx Software Engineering In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-TUID: j3g+gYUX+Bdx Hi Vijai, On 2023-06-30 13:36, 'Kanagarajan, Vijaikumar' via isar-users wrote: > On 2023-06-29 15:21, Claudius Heine wrote: >> FILESEXTRAPATHS is meant to allow bbappend files to overwrite files >> from their recipe. For this reason the 'normal' patter in bbappend >> files is to prepend the local file path to FILESEXTRAPATHS, which >> results in files from the local file path to be preferred over files >> from the original recipe, or other, lower prioritized bbappend files. >> >> The `module.inc` file is meant to be included by other recipes (`.bb`) >> files. So it should still allow the recipe to overwrite files its >> files that where added via the normal recipes `FILESPATH` search path. >> >> If `module.inc` uses `FILESEXTRAPATHS:prepend` to add its local file >> path to `FILESPATH`, then the recipe, that includes the `module.inc` >> would have to use `FILESEXTRAPATHS:prepend` as well, after including >> the `module.inc` file in order to overwrite the files from the >> `module.inc` file. However this is a workaround of the issue. >> >> `module.inc` should append its local file search path to `FILESPATH`, >> so that it allows other recipes to overwrite any file from it, without >> requiring an additional workaround. > > I don't see a better way than this. > We have an inc file which exposes a default dir. When we build a recipe the default FILESPATH is populated and now we have no mechanism to override those unless we do another FILESEXTRAPATHS:prepend after the include. > I assume this should be the case with other includes as well. > > Acked-by: Vijai Kumar K > > Also wondering what kind of limitation was there in the current debian/ contents that you must override? Thanks for the ack. I will prepare a patchset that uses this scheme for the other FILESEXTRAPATHS in .inc files. The issue with the debian files of modules.inc (and the split in isar between bitbake recipes and debian source packages) is that it contains the 'rules' file, which specifies how the Makefile of the project is executed. That means if the developer of the kernel module uses a different interface than `make -C $KDIR M=$(pwd) modules` to build the modules, then the `rules` file needs to be changed. This cannot be done by just appending to the recipe. Sure, it would be possible to apply a patch to the source modules first, so that the same `rules` file can be used, but depending on how complex the build process of the out-of-tree kernel module is, this might be more complex, and less-maintainable than just replacing the `rules` file. In my case it was about the out-of-tree nvidia tegra kernel modules. In some cases, they have creative ideas on how to do things. regards, Claudius > > Thanks, > Vijai Kumar K