Re: [PATCH v5 0/5] Fix usage of additional apt keys and repos

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Andi,

On Mon, 2019-03-18 at 14:31 +0100, [ext] Andreas J. Reichel wrote:
> From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> 
> Diff to v4:
> 	* don't remove keyring deployed to target rootfs
> 	  so that one can do updates later
> 	* keys are temporarily held in WORKDIR/aptkeys, not
> 	  TMPDIR/aptkeys
> 	* variable renamed from APTKEYTMPDIR to APT_KEYS_DIR
> 
> Unchanged with reason:
> 	* function for retreiving override for https is unchanged,
> 	  since renaming this to one global function
> 	  "get_distro_overrides" is better done in a separate patch.
> 	  This patch should concentrate on getting things finally
> 	  working, before changing too much code that is more or less
> 	  a beautification.
>         * (Other comments on mailing list)
> 	* HAVE_CUSTOM_APT_KEYS is used in patch 4, but introduced in
> 	  patch 5, which is okay here, because we check if it exists...
> 
> What this series does:
> 	* Enable/fix possibility of additional apt repos
> 	* Enable/fix handling of additional apt keys
> 	* Deduplicate some code

LGTM

> 
> Signed-off-by: Andreas Reichel <andreas.reichel.ext@siemens.com>

Acked-by: Claudius Heine <ch@denx.de>

> 
> Andreas Reichel (5):
>   Revert "isar-bootstrap: Allow to set local keys in DISTRO_APT_KEYS"
>   Remove duplicate code from apt-keyring generation
>   Fix fetched key location in apt-keyring generator
>   Use apt-key to generate apt-keyring
>   If we use a custom keyring debootstrap may fall to https
> 
>  .../conf/multiconfig/qemuamd64-buster.conf    |  1 -
>  .../conf/multiconfig/qemuamd64-jessie.conf    |  1 -
>  meta/classes/isar-bootstrap-helper.bbclass    |  2 +
>  meta/conf/bitbake.conf                        |  1 +
>  .../isar-bootstrap/isar-bootstrap.inc         | 62 +++++++++++++--
> ----
>  5 files changed, 47 insertions(+), 20 deletions(-)
> 
> -- 
> 2.21.0
>