From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6669723628337102848 X-Received: by 2002:a1c:4e0c:: with SMTP id g12mr1118694wmh.9.1552916839632; Mon, 18 Mar 2019 06:47:19 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:6692:: with SMTP id l18ls1400047wru.10.gmail; Mon, 18 Mar 2019 06:47:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqzryviMZW/6IzCCjqYDK49AUF0C9xoL1IH3eH9pf3iv2G1vwkMFl6Qy+Zxb1cNNh0CcBBak X-Received: by 2002:a5d:564d:: with SMTP id j13mr746227wrw.27.1552916838661; Mon, 18 Mar 2019 06:47:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552916838; cv=none; d=google.com; s=arc-20160816; b=0AJV3iORGN14X0QZmcq8tzp45reB3nyNJAbZ6/2lIZJv4H8vFNe57Ux0Tn86YNoQ+F RNi03HjaRMHkxrv3plUdVy3hg/4cLKAVcR0l9Eqg4Bf6nBgZrk9ux46L5SRFSeyXzBkQ eRTlbiWRgFw2vqB4Fsdku/86IheLF8KQvFgvpj9sjSdWgW3waypNo1bk2jwT0schoSxY CB0J8I8R0u6YkcXQC9B6oREHdPLYdWBz0RdfhzkFBx8hxFV+ExdqkkPAuPrt0AOnRBlS 6Yr9F9rt+2VsxATVFkAafZQF1ITFAcDtKfAnFgEJ2WqONQnrxJpbdM54Mr0IGwrpM1DZ vvtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id; bh=KxvVfDNCFDBd3yzH4hQslsYIDRUeN5F/tI6mIav/x48=; b=OYDL7hsDRw9DrDtqBUuiy3g04TshM8zZarCQGuciyo6CTGCphgn8/bs34jJ2FTrkDt NhryNdPjdbBHeiKq650McYWiEcc9bZSKHIz2HZhBFQM79xvvmSoAK61failqUOPb7s9T 5Lvy6Tf5rXcA5i/dtc8Iu66Y+JzTabIic7X53OzFuZUbYQTZvyulRKwqd+6mMBQq3RrM ErSTXtN82hLnBLvon5rBG6Ivqe1vDaGSOiqehjBhHUxGtwPJ/lE4PltHvf14CYTyjbhD dtWoxC85off3Nw3FHAx5hZ2C3J3Q+NpN++ih+f1iyP9TUWg9bi6S7iXDMobKxYDfgJDv o1lA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id y196si6650wmd.0.2019.03.18.06.47.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 06:47:18 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x2IDlIgR006921 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 18 Mar 2019 14:47:18 +0100 Received: from linux-ses-ext02.ppmd.siemens.net (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x2IDlHca010988; Mon, 18 Mar 2019 14:47:18 +0100 Message-ID: <7b35069cd28fc37bfc47257a2d236d916c70b7df.camel@siemens.com> Subject: Re: [PATCH v5 0/5] Fix usage of additional apt keys and repos From: Claudius Heine To: "[ext] Andreas J. Reichel" , isar-users@googlegroups.com Date: Mon, 18 Mar 2019 14:47:17 +0100 In-Reply-To: <20190318133205.29705-1-andreas.reichel.ext@siemens.com> References: <20190318133205.29705-1-andreas.reichel.ext@siemens.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUID: hAaKvh8z2L8S Hi Andi, On Mon, 2019-03-18 at 14:31 +0100, [ext] Andreas J. Reichel wrote: > From: Andreas Reichel > > Diff to v4: > * don't remove keyring deployed to target rootfs > so that one can do updates later > * keys are temporarily held in WORKDIR/aptkeys, not > TMPDIR/aptkeys > * variable renamed from APTKEYTMPDIR to APT_KEYS_DIR > > Unchanged with reason: > * function for retreiving override for https is unchanged, > since renaming this to one global function > "get_distro_overrides" is better done in a separate patch. > This patch should concentrate on getting things finally > working, before changing too much code that is more or less > a beautification. > * (Other comments on mailing list) > * HAVE_CUSTOM_APT_KEYS is used in patch 4, but introduced in > patch 5, which is okay here, because we check if it exists... > > What this series does: > * Enable/fix possibility of additional apt repos > * Enable/fix handling of additional apt keys > * Deduplicate some code LGTM > > Signed-off-by: Andreas Reichel Acked-by: Claudius Heine > > Andreas Reichel (5): > Revert "isar-bootstrap: Allow to set local keys in DISTRO_APT_KEYS" > Remove duplicate code from apt-keyring generation > Fix fetched key location in apt-keyring generator > Use apt-key to generate apt-keyring > If we use a custom keyring debootstrap may fall to https > > .../conf/multiconfig/qemuamd64-buster.conf | 1 - > .../conf/multiconfig/qemuamd64-jessie.conf | 1 - > meta/classes/isar-bootstrap-helper.bbclass | 2 + > meta/conf/bitbake.conf | 1 + > .../isar-bootstrap/isar-bootstrap.inc | 62 +++++++++++++-- > ---- > 5 files changed, 47 insertions(+), 20 deletions(-) > > -- > 2.21.0 >