Re: [PATCH 1/3] sshd-regen-keys: correct dependency on ssh daemon service

[Gylstorff Quirin <quirin.gylstorff@siemens.com>]

On 3/10/20 5:04 PM, Cedric Hombourger wrote:
> The name of the SSH daemon service is ssh.service, not sshd.service
> This fixes some (sporadic) failures to generate host-specific ssh
> keys on first boot.
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>   .../sshd-regen-keys/files/sshd-regen-keys.service               | 2 +-
>   .../{sshd-regen-keys_0.2.bb => sshd-regen-keys_0.3.bb}          | 0
>   2 files changed, 1 insertion(+), 1 deletion(-)
>   rename meta/recipes-support/sshd-regen-keys/{sshd-regen-keys_0.2.bb => sshd-regen-keys_0.3.bb} (100%)
> 
> diff --git a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service
> index a05e1a9..f50d34c 100644
> --- a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service
> +++ b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service
> @@ -3,7 +3,7 @@ Description=Regenerate sshd host keys
>   DefaultDependencies=no
>   Conflicts=shutdown.target
>   After=systemd-remount-fs.service
> -Before=shutdown.target sshd.service
> +Before=shutdown.target ssh.service


This should not be necessary as Debian generates a link from 
/etc/systemd/system/sshd.service to /lib/systemd/system/ssh.service. 
Therefore both sshd.service and ssh.service are equivalent.

Also I have a freeze during sshd-regen-keys but the patch has no impact 
on it.

Quirin
>   ConditionPathIsReadWrite=/etc
>   
>   [Service]
> diff --git a/meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.2.bb b/meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.3.bb
> similarity index 100%
> rename from meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.2.bb
> rename to meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.3.bb
>