Re: [PATCH v2 3/3] installer: Run in unattended mode only on ttyS0

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 18.03.25 07:25, 'Jan Kiszka' via isar-users wrote:
> On 18.03.25 07:10, Uladzimir Bely wrote:
>> This fixes race between two unattended installer instances running
>> on serial "ttyS0" and graphic "tty1" terminals.
>>
>> While one of them starts writing the disk, another one fails
>> and schedules reboot in 60 seconds. Depending on build machine
>> performance we can get incomplete installation and broken target
>> filesystem.
>>
>> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
>> ---
>>  .../deploy-image/files/usr/bin/deploy-image-wic.sh          | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
>> index 7f552eee..bd580694 100755
>> --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
>> +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
>> @@ -10,6 +10,12 @@ SCRIPT_DIR=$( dirname -- "$( readlink -f -- "$0"; )"; )
>>  
>>  . ${SCRIPT_DIR}/../lib/deploy-image-wic/handle-config.sh
>>  
>> +if $installer_unattended; then
>> +    if [ "$(tty)" != "/dev/ttyS0" ]; then
> 
> This is wrong. "ttyS0" is target-specific. We need a different, generic
> mechanism to detect multiple executions.
> 
> Jan
> 
>> +        echo "Disable unattended mode on $(tty), it's active on /dev/ttyS0"
>> +        installer_unattended=0

And this would be also wrong.

But all this does not make sense yet. We have a single service that is
supposed to run a single script. I don't see why systemd should
instantiate the service multiple times. Is our service file incorrect?

Jan

>> +    fi
>> +fi
>>  
>>  if ! $installer_unattended; then
>>      installer_image_uri=$(find "$installdata" -type f -iname "*.wic*" -a -not -iname "*.wic.bmap" -exec basename {} \;)
> 
> 

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/7b66abad-a095-4eb0-bc20-643f9743e5fb%40siemens.com.