From: chombourger@gmail.com
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] isar-image-base: Remove apt listing in IMAGE_PREINSTALL
Date: Sat, 25 Aug 2018 23:19:43 -0700 (PDT) [thread overview]
Message-ID: <7b779b0d-773b-49ca-a75a-c60d9c11d323@googlegroups.com> (raw)
In-Reply-To: <a78fd1a5-5872-0d35-b3cd-22015e7dfca8@siemens.com>
[-- Attachment #1.1: Type: text/plain, Size: 1116 bytes --]
Looks good to me. I would just change the subject to 'isar-image-base:
remove "apt" from IMAGE_PREINSTALL'
(I found "listing" to be confusing/misleading until I looked at the patch)
Cedric
On Wednesday, August 22, 2018 at 9:55:45 PM UTC+2, Jan Kiszka wrote:
>
> debootstrap does that for us anyway.
>
> Signed-off-by: Jan Kiszka <jan.k...@siemens.com <javascript:>>
> ---
> meta-isar/recipes-core/images/isar-image-base.bb | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
> b/meta-isar/recipes-core/images/isar-image-base.bb
> index a24aa3e..84001fd 100644
> --- a/meta-isar/recipes-core/images/isar-image-base.bb
> +++ b/meta-isar/recipes-core/images/isar-image-base.bb
> @@ -18,8 +18,7 @@ inherit isar-bootstrap-helper
>
> DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}"
>
> -IMAGE_PREINSTALL += "apt \
> - dbus"
> +IMAGE_PREINSTALL += "dbus"
> IMAGE_TRANSIENT_PACKAGES += "isar-cfg-localepurge"
>
> WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
> --
> 2.16.4
>
[-- Attachment #1.2: Type: text/html, Size: 3788 bytes --]
next prev parent reply other threads:[~2018-08-26 6:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 19:55 Jan Kiszka
2018-08-26 6:19 ` chombourger [this message]
2018-08-27 22:11 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b779b0d-773b-49ca-a75a-c60d9c11d323@googlegroups.com \
--to=chombourger@gmail.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox