From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6592636267378245632
Date: Sat, 25 Aug 2018 23:19:43 -0700 (PDT)
From: chombourger@gmail.com
To: isar-users <isar-users@googlegroups.com>
Message-Id: <7b779b0d-773b-49ca-a75a-c60d9c11d323@googlegroups.com>
In-Reply-To: <a78fd1a5-5872-0d35-b3cd-22015e7dfca8@siemens.com>
References: <a78fd1a5-5872-0d35-b3cd-22015e7dfca8@siemens.com>
Subject: Re: [PATCH] isar-image-base: Remove apt listing in IMAGE_PREINSTALL
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_654_1976331667.1535264384021"
X-Google-Token: EP-MidwFOuW1fPwaUWM0
X-Google-IP: 192.94.31.2
X-TUID: 3K+j5C0WdMga

------=_Part_654_1976331667.1535264384021
Content-Type: multipart/alternative; 
	boundary="----=_Part_655_551159678.1535264384022"

------=_Part_655_551159678.1535264384022
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Looks good to me. I would just change the subject to 'isar-image-base: 
remove "apt" from IMAGE_PREINSTALL'
(I found "listing" to be confusing/misleading until I looked at the patch)

Cedric

On Wednesday, August 22, 2018 at 9:55:45 PM UTC+2, Jan Kiszka wrote:
>
> debootstrap does that for us anyway. 
>
> Signed-off-by: Jan Kiszka <jan.k...@siemens.com <javascript:>> 
> --- 
>  meta-isar/recipes-core/images/isar-image-base.bb | 3 +-- 
>  1 file changed, 1 insertion(+), 2 deletions(-) 
>
> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb 
> b/meta-isar/recipes-core/images/isar-image-base.bb 
> index a24aa3e..84001fd 100644 
> --- a/meta-isar/recipes-core/images/isar-image-base.bb 
> +++ b/meta-isar/recipes-core/images/isar-image-base.bb 
> @@ -18,8 +18,7 @@ inherit isar-bootstrap-helper 
>   
>  DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}" 
>   
> -IMAGE_PREINSTALL += "apt \ 
> -                     dbus" 
> +IMAGE_PREINSTALL += "dbus" 
>  IMAGE_TRANSIENT_PACKAGES += "isar-cfg-localepurge" 
>   
>  WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" 
> -- 
> 2.16.4 
>

------=_Part_655_551159678.1535264384022
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Looks good to me. I would just change the subject to &#39;=
isar-image-base: remove &quot;apt&quot; from IMAGE_PREINSTALL&#39;<br>(I fo=
und &quot;listing&quot; to be confusing/misleading until I looked at the pa=
tch)<div><br>Cedric</div><div><br>On Wednesday, August 22, 2018 at 9:55:45 =
PM UTC+2, Jan Kiszka wrote:<blockquote class=3D"gmail_quote" style=3D"margi=
n: 0;margin-left: 0.8ex;border-left: 1px #ccc solid;padding-left: 1ex;">deb=
ootstrap does that for us anyway.
<br>
<br>Signed-off-by: Jan Kiszka &lt;<a href=3D"javascript:" target=3D"_blank"=
 gdf-obfuscated-mailto=3D"O3HrUYYXAgAJ" rel=3D"nofollow" onmousedown=3D"thi=
s.href=3D&#39;javascript:&#39;;return true;" onclick=3D"this.href=3D&#39;ja=
vascript:&#39;;return true;">jan.k...@siemens.com</a>&gt;
<br>---
<br>=C2=A0meta-isar/recipes-core/<wbr>images/<a href=3D"http://isar-image-b=
ase.bb" target=3D"_blank" rel=3D"nofollow" onmousedown=3D"this.href=3D&#39;=
http://www.google.com/url?q\x3dhttp%3A%2F%2Fisar-image-base.bb\x26sa\x3dD\x=
26sntz\x3d1\x26usg\x3dAFQjCNGVqMtyn3ermWec7jxc4PQDaGESyQ&#39;;return true;"=
 onclick=3D"this.href=3D&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fis=
ar-image-base.bb\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGVqMtyn3ermWec7jxc=
4PQDaGESyQ&#39;;return true;">isar-image-base.bb</a> | 3 +--
<br>=C2=A01 file changed, 1 insertion(+), 2 deletions(-)
<br>
<br>diff --git a/meta-isar/recipes-core/<wbr>images/<a href=3D"http://isar-=
image-base.bb" target=3D"_blank" rel=3D"nofollow" onmousedown=3D"this.href=
=3D&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fisar-image-base.bb\x26s=
a\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGVqMtyn3ermWec7jxc4PQDaGESyQ&#39;;retur=
n true;" onclick=3D"this.href=3D&#39;http://www.google.com/url?q\x3dhttp%3A=
%2F%2Fisar-image-base.bb\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGVqMtyn3er=
mWec7jxc4PQDaGESyQ&#39;;return true;">isar-image-base.bb</a> b/meta-isar/re=
cipes-core/<wbr>images/<a href=3D"http://isar-image-base.bb" target=3D"_bla=
nk" rel=3D"nofollow" onmousedown=3D"this.href=3D&#39;http://www.google.com/=
url?q\x3dhttp%3A%2F%2Fisar-image-base.bb\x26sa\x3dD\x26sntz\x3d1\x26usg\x3d=
AFQjCNGVqMtyn3ermWec7jxc4PQDaGESyQ&#39;;return true;" onclick=3D"this.href=
=3D&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fisar-image-base.bb\x26s=
a\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGVqMtyn3ermWec7jxc4PQDaGESyQ&#39;;retur=
n true;">isar-image-base.bb</a>
<br>index a24aa3e..84001fd 100644
<br>--- a/meta-isar/recipes-core/<wbr>images/<a href=3D"http://isar-image-b=
ase.bb" target=3D"_blank" rel=3D"nofollow" onmousedown=3D"this.href=3D&#39;=
http://www.google.com/url?q\x3dhttp%3A%2F%2Fisar-image-base.bb\x26sa\x3dD\x=
26sntz\x3d1\x26usg\x3dAFQjCNGVqMtyn3ermWec7jxc4PQDaGESyQ&#39;;return true;"=
 onclick=3D"this.href=3D&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fis=
ar-image-base.bb\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGVqMtyn3ermWec7jxc=
4PQDaGESyQ&#39;;return true;">isar-image-base.bb</a>
<br>+++ b/meta-isar/recipes-core/<wbr>images/<a href=3D"http://isar-image-b=
ase.bb" target=3D"_blank" rel=3D"nofollow" onmousedown=3D"this.href=3D&#39;=
http://www.google.com/url?q\x3dhttp%3A%2F%2Fisar-image-base.bb\x26sa\x3dD\x=
26sntz\x3d1\x26usg\x3dAFQjCNGVqMtyn3ermWec7jxc4PQDaGESyQ&#39;;return true;"=
 onclick=3D"this.href=3D&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fis=
ar-image-base.bb\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGVqMtyn3ermWec7jxc=
4PQDaGESyQ&#39;;return true;">isar-image-base.bb</a>
<br>@@ -18,8 +18,7 @@ inherit isar-bootstrap-helper
<br>=C2=A0
<br>=C2=A0DEPENDS +=3D &quot;${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}&q=
uot;
<br>=C2=A0
<br>-IMAGE_PREINSTALL +=3D &quot;apt \
<br>- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 dbus&quot;
<br>+IMAGE_PREINSTALL +=3D &quot;dbus&quot;
<br>=C2=A0IMAGE_TRANSIENT_PACKAGES +=3D &quot;isar-cfg-localepurge&quot;
<br>=C2=A0
<br>=C2=A0WORKDIR =3D &quot;${TMPDIR}/work/${DISTRO}-${<wbr>DISTRO_ARCH}/${=
PN}&quot;
<br>--=20
<br>2.16.4
<br></blockquote></div></div>
------=_Part_655_551159678.1535264384022--

------=_Part_654_1976331667.1535264384021--