From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 16 Sep 2026 09:44:50 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-lf1-f58.google.com (mail-lf1-f58.google.com [209.85.167.58]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 68G7invb007217 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 Sep 2026 09:44:50 +0200 Received: by mail-lf1-f58.google.com with SMTP id 2adb3069b0e04-5b89a38c343sf1292874e87.0 for ; Wed, 16 Sep 2026 00:44:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1789544684; cv=pass; d=google.com; s=arc-20260327; b=KvEDzsjiwTOOLQN5l0N95rIGaOjYHFXkkdFHu9AXeyzlcwxxcz/N+Pos0DyIA19PxY /qFdNVjBO/WM6ha+RR2+Np6/4/ybpegjgw0q8gy8qZufVPvhWfvLyZBkJ50eXf6IDfa/ QeUIZTsce5KsMj9vd+2gtxrCdRtDlIwAaiIu0o6+qn06nPBXdXc4OczoM3YX/MQddSzf GaA+3T6k9lL/6pmcYqhsvYakD8HwHBKv/4OrRufFVaj+5UXI13D+/dRLd0gyHZQ/OtwJ a5wqFibFL6vfUevzhmNry2UJs3ic70ppcGuWu5KTYHGKJMMyyX0EW8NckROfjzCsa2jU xiOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:content-transfer-encoding :in-reply-to:from:cc:content-language:references:to:subject :user-agent:mime-version:date:message-id:sender:dkim-signature; bh=rcyYwAra95Tuk7xGP/CvF+jjGMzJexSf9zTMdKcxlO0=; fh=hTjS9UEmVjXf5hy9xq/FQj0dCi8VqfzIlXrSrnPPmLk=; b=ijUnuVGS7D2sO/XwYqHa/1SdzaeEfCQRW5JD5ioK8sBlYu31uIPToy5Cqi++K4sK8k 4X+c+rmZ/x/yfYigiKGCrq//c7Jk0NAnIxHSlM53thIP13T8Ya1DZ7Pe04CeyhhFCTOs +7shbqVcRRX52SwuCfW5zDDZGvxFIs70UtDz/5DqL5DYwnqrjLz0I4oyGp03r+kpB7ak raBXxnQR7lrOJGYb+KTfwQ9w4CE2Z6D+6Zti9nkbQS05yHwxpuAu02AAy3Xe0v4svwEJ +8pmyae6a3NN9vAGBHB0UHZI+G9PEykpm7XTNaXnxGjEQ8IdV6AxEOD3bBM+xl/edjL6 vu1A==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1789544684; x=1790149484; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:content-transfer-encoding:content-type :in-reply-to:from:cc:content-language:references:to:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rcyYwAra95Tuk7xGP/CvF+jjGMzJexSf9zTMdKcxlO0=; b=WdAo8ksQPRVaen7oBrz7fCm1AAZiZHtXhdesFc+g3YMRFIW6AfGRVMuPOHM8qGgh7R IlhQfMu/TnTB3fGwSrxHu/N0PrJu6W5R+sNjdA+AXFQf1PPuNSIYhkDRy2M1dXtlmZKf LfCwo6PIzBTQKa62JIp+ySVw24OeXS0fipIG1yYHwwu2EnpPjinhimpzlwQc6uiMlqtD hGGQVeM1uYvGkCLkchXD9ObwQPq/xvlhqyfovDlRP8AftgAOO2q6SvI0/D9eG7SYg4Hq S0uJsH0B8kBTNVb7/7FMzH8Xo5sSGcgxFccDlnRoocy5VCyAz4H8KD9yTAtBw4wSgb3S 5rOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789544684; x=1790149484; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :content-transfer-encoding:content-type:in-reply-to:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-beenthere:x-gm-message-state:sender:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rcyYwAra95Tuk7xGP/CvF+jjGMzJexSf9zTMdKcxlO0=; b=YuBJAA16pm4j8kEwEpzoyx+K519zxZE+HRXDOLd94WugVzi3mN8uoXeqKLMAVuMICl BKwoBwZ1D9R7msXAMkBfUXlsm1YUMwo4GDRXMnPFAakiHzA3NSCz8EgI6piB7Xys/KXR 2p2RYPHgaWuLlkHonhhbtxjInhGtR5LQfOuYthTDOfPyxGOP1eq5gIlA4mwmoCI1+Rkv HJpeiRiF1YoRdm3kQ7mKTFiu5hrKw0aPycd8WsPn2zoCE0eXq8U3r8dWQ+u05uxOQQC9 x2QKZb/dWNOoDFkMg/sK7+UAE8n/nSowGzzDhaYngmyVdWIi0JaBk1Mv+NX8o9RewU1O 6GpA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AKwUvBxsLI/L9p+9y5pQaLwRpqXXs/DQiVf8kVWWByR3dPTTsk0dBvcka/9yiS/PNVws1V/xiHdX@ilbers.de X-Gm-Message-State: AFuF++klEOVC01rV66998mEAj35Da33MN7NEElhp/Vi1h0Tpw/CnRdnj /Y641hyCHran/UYIrmC6aQ0UQNBg4E/qWD5Nzi8EPBztwPOQrENSJM9r X-Received: by 2002:a05:6512:3b2a:b0:5b1:5eea:a576 with SMTP id 2adb3069b0e04-5b8b66179b0mr380764e87.21.1789544684169; Wed, 16 Sep 2026 00:44:44 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="ATskLdexQmKWx+2a17l90fiXLPSP8f9bUrE2ht7rml/SYi3j8A==" Received: by 2002:a05:6512:485c:b0:5b4:4c58:eb05 with SMTP id 2adb3069b0e04-5b89a2d7f9bls1885060e87.2.-pod-prod-08-eu; Wed, 16 Sep 2026 00:44:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxGJOoGxkU11yMX/Ryz9ZMAnp4J0f/0yP7h+OBSBzj5uc9WWvGsMk6iEAN8Fb26aiqF9pfPiorCgioi@googlegroups.com X-Received: by 2002:a05:6512:ba5:b0:5ae:c8da:6254 with SMTP id 2adb3069b0e04-5b8b6621464mr422028e87.22.1789544680768; Wed, 16 Sep 2026 00:44:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789544680; cv=none; d=google.com; s=arc-20260327; b=kQ0a/Wes8IoLPr9B0gh+bzUEv5fcDk2/Rmg6FMsWoFBxOSUbsS8BsqBjsKYsFY2Uy0 mrs1dATjG1g/GjDroLgPFDPjos2CuoZsShJeCgrmJ0aHJZ/H0WBFRI9eWRo0BB/X2vyV Hm6BDR+xS6FffOup12in38iE2EkKaxCNKdjiAhU5d4K6SjvqQOaj+SYwkR9B7aGpthYr N+qp6L02xEwWgVm/t5PQCyFW+VO9k3juhLoJpjQbtEv0BsESQdFEUDdDuS5SOyiENgiU /xXoox+VlLdHT8IeR9dG7p2yD+uDEpSA52D7HjKYIiK4j03csgmywhD0B+2f9wkh6V3T 76ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:date:message-id; bh=OWPodpFefAh2ZQr/76PvncRlU8Mov+794dPiNfOZxs0=; fh=pojKi96lUV+iqpJvqxHVeVvZpM2m67l/kAh52R3TZug=; b=SnkzVLmAaPf9sejYyA5UjVGJoK9GLL6ny55p1zbzQi5XIL+UB/+XpsJB0EADFuRz1U 8qolH3gEzZA3MjcLqhfCpaTbR3BuW8qhvCaWLqSF54frPe4yJjOeRpgBpjubho6xIsrk mw1mNrD9UynRYfBjzqWQYdIJP/m9ozSeB6C95C1islDQ6ULpr7mP9Bbqf8GUca+Gm2WO +LaCF+dhLmkMv9Ots7wRP82uchXcvgB5jPDP5uPMc8ez3j8VeWheh6oh8/1Z5Xn8H8wk h2SV6uGWJt1Kk3kzRxRtv+XPAnP3gb1TzNUvc1OYcjMSWSsvvCEdZPY4G80mN15q1FMT OHSQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 2adb3069b0e04-5b8b5752495si34625e87.0.2026.09.16.00.44.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Sep 2026 00:44:40 -0700 (PDT) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.139] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 68G7idq4007207 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 09:44:39 +0200 Message-ID: <7bda14aa-6f21-452f-9496-1f5a2acee60e@ilbers.de> Date: Wed, 16 Sep 2026 09:44:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] avoid double slash in generated rootfs umount paths To: Srinuvasan Arjunan , isar-users References: <20260911101616.748091-1-srinuvasan.a@siemens.com> <855faf99-5468-44da-8d6d-5472b87512e9@siemens.com> <4e75a9db-b230-41a5-93d1-69a85f5568c0@siemens.com> Content-Language: en-US Cc: Jan Kiszka From: Zhihang Wei In-Reply-To: <4e75a9db-b230-41a5-93d1-69a85f5568c0@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: Gu14aAlecSv9 On 9/11/26 13:20, 'Jan Kiszka' via isar-users wrote: > On 11.09.26 13:12, 'Srinuvasan Arjunan' via isar-users wrote: >> >> On Friday, September 11, 2026 at 4:19:31=E2=80=AFPM UTC+5:30 Jan Kiszka = wrote: >> >> On 11.09.26 12:16, srinuvasan.a via isar-users wrote: >> > From: Srinuvasan A >> > >> > ROOTFS_MOUNTS inner paths are absolute, e.g. /isar-apt and >> > /isar-work. insert_isar_umounts added another slash between ROOTF= SDIR >> > and the inner path, producing paths like rootfs//isar-apt in the >> > expanded rootfs_do_umounts_priv task. >> > >> > Strip the leading slash from the inner mount path when building t= he >> > mountpoint, matching the logic already used by insert_isar_mounts= . >> > >> > Logs: >> > mountpoint -q /work/build/tmp/work/debian-trixie-amd64/isar-image= - >> base-qemuamd64/1.0-r0/rootfs//isar-apt && >> > umount /work/build/tmp/work/debian-trixie-amd64/isar-image-base- >> qemuamd64/1.0-r0/rootfs//isar-apt >> > >> > mountpoint -q /work/build/tmp/work/debian-trixie-amd64/isar-image= - >> base-qemuamd64/1.0-r0/rootfs//isar-work && >> > umount /work/build/tmp/work/debian-trixie-amd64/isar-image-base- >> qemuamd64/1.0-r0/rootfs//isar-work >> > >> > Signed-off-by: Srinuvasan A >> > --- >> > meta/classes-global/base.bbclass | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/meta/classes-global/base.bbclass b/meta/classes- >> global/base.bbclass >> > index 8f81ab70..be663fe7 100644 >> > --- a/meta/classes-global/base.bbclass >> > +++ b/meta/classes-global/base.bbclass >> > @@ -432,7 +432,7 @@ def insert_isar_umounts(d, rootfs, mounts): >> > >> > for m in mounts.split(): >> > host, inner =3D m.split(':') if ':' in m else (m, m) >> > - mp =3D '{}/{}'.format(rootfs, inner) >> > + mp =3D '{}/{}'.format(rootfs, inner[1:]) >> >> This looks fragile. Why not strip off '/', rather than blindly cutt= ing >> the last char? >> >> Jan >> >> >> =C2=A0 Thanks for the comments, >> >> =C2=A0 Here,=C2=A0inner[1:] strips the leading /, as we always assume t= he paths in >> ROOTFS_MOUNTS are absolute. > Yeah, confused that. > >> =C2=A0 For example: >> >> =C2=A0 ROOTFS_MOUNTS ??=3D "${REPO_ISAR_DIR}/${DISTRO}:/isar-apt ${WORK= DIR}:/ >> isar-work" >> >> =C2=A0 This also follows the same pattern already used by insert_isar_m= ounts. >> > It would still be clearer, not requiring a (missing) comment or reading > the commit message to understand what is cut off here. And maybe other > code would benefit from a clearer pattern as well. > > Jan > Will there be a v2? Zhihang --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= 7bda14aa-6f21-452f-9496-1f5a2acee60e%40ilbers.de.