public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Gylstorff Quirin <quirin.gylstorff@siemens.com>
To: "nicusor.huhulea@siemens.com" <nicusor.huhulea@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [isar-cip-core][PATCH] efibootguard-boot.py: update dtbs based on their deploydir subdir paths
Date: Thu, 28 Mar 2024 17:33:32 +0100	[thread overview]
Message-ID: <7beea203-abe9-4000-934c-b1d46d6ed423@siemens.com> (raw)
In-Reply-To: <DB3PR10MB6908BF491311D0AB428DFF79E63B2@DB3PR10MB6908.EURPRD10.PROD.OUTLOOK.COM>



On 3/28/24 8:54 AM, 'nicusor.huhulea@siemens.com' via isar-users wrote:
> This needs to be in sync with the isar image.bbclass changes where the dtbs are placed in
> their corresponded image name subdirectories.

Wrong mailing list - please post on cip-dev@lists.cip-project.org.
Quirin
> 
> 
>      Signed-off-by: Nicusor Huhulea <nicusor.huhulea@siemens.com>
> 
> diff --git a/scripts/lib/wic/plugins/source/efibootguard-boot.py b/scripts/lib/wic/plugins/source/efibootguard-boot.py
> index 4e3aefb..86e342c 100644
> --- a/scripts/lib/wic/plugins/source/efibootguard-boot.py
> +++ b/scripts/lib/wic/plugins/source/efibootguard-boot.py
> @@ -181,6 +181,8 @@ class EfibootguardBootPlugin(SourcePlugin):
>                                        deploy_dir, kernel_image, initrd_image,
>                                        dtb_files, source_params):
>           rootfs_path = rootfs_dir.get('ROOTFS_DIR')
> +        image_basename = get_bitbake_var("IMAGE_BASENAME")
> +        machine = get_bitbake_var("MACHINE")
>           efiarch = get_bitbake_var("EFI_ARCH")
>           if not efiarch:
>               msger.error("Bitbake variable 'EFI_ARCH' not set, exiting\n")
> @@ -210,8 +212,10 @@ class EfibootguardBootPlugin(SourcePlugin):
>                   uefi_kernel_file=uefi_kernel_file)
>           if dtb_files:
>               for dtb in dtb_files:
> -                cmd += ' -d {deploy_dir}/{dtb_file}'.format(
> +                cmd += ' -d {deploy_dir}/{image_basename}-{machine}.dtbs/{dtb_file}'.format(
>                       deploy_dir=deploy_dir,
> +                    image_basename=image_basename,
> +                    machine=machine,
>                       dtb_file=os.path.basename(dtb))
>           exec_cmd(cmd, as_shell=True)
> 

      reply	other threads:[~2024-03-28 16:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28  7:54 nicusor.huhulea
2024-03-28 16:33 ` Gylstorff Quirin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7beea203-abe9-4000-934c-b1d46d6ed423@siemens.com \
    --to=quirin.gylstorff@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=nicusor.huhulea@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox