Re: [PATCH 7/7] linux-custom: rewrite to no longer depend on the kernel's builddeb

[Jan Kiszka <jan.kiszka@siemens.com>]

On 05.11.19 21:16, chombourger@gmail.com wrote:
> On Tuesday, November 5, 2019 at 4:26:33 PM UTC+1, Jan Kiszka wrote:
> 
>     On 05.11.19 14:57, Cedric Hombourger wrote:
>     > diff --git
>     a/meta/recipes-kernel/linux/files/debian/linux-image.postrm.tmpl
>     b/meta/recipes-kernel/linux/files/debian/linux-image.postrm.tmpl
>     > new file mode 100644
>     > index 0000000..9d88218
>     > --- /dev/null
>     > +++ b/meta/recipes-kernel/linux/files/debian/linux-image.postrm.tmpl
>     > @@ -0,0 +1,18 @@
>     > +#!/bin/sh
>     > +  
>     > +set -e
>     > +
>     > +rm -f /lib/modules/${PV}/.fresh-install
>     > +
>     > +if [ "$1" != upgrade ] && command -v linux-update-symlinks
>     >/dev/null; then
>     > +        linux-update-symlinks remove ${PV}
>     /boot/${KERNEL_FILE}-${PV}
>     > +fi
>     > +
>     > +# Pass maintainer script parameters to hook scripts
>     > +export DEB_MAINT_PARAMS="$*"
>     > +
>     > +# Tell initramfs builder whether it's wanted
>     > +export INITRD=Yes
>     > +
>     > +test -d /etc/kernel/postrm.d && run-parts --arg="${PV}"
>     --arg="/boot/${KERNEL_FILE}-${PV}" /etc/kernel/postrm.d
>     > +exit 0
>     > diff --git a/meta/recipes-kernel/linux/files/debian/rules.tmpl
>     b/meta/recipes-kernel/linux/files/debian/rules.tmpl
> 
>     There is quite some duplication between postinst and postrm already.
>     Moreover, I think you are missing preinst and prerm. I think all four
>     should probably be generated from one template.
> 
> 
> Ok I have checked upstream scripts and it seems that they all differ
> see https://salsa.debian.org/kernel-team/linux/tree/master/debian/templates
> 
> I would recommend we just copy over their scripts but use our templating
> system instead of theirs
> (use ${var} instead of @var@)
>  

Yes, seems reasonable. I checked but didn't spot anything that seems
specific to their kernel.

So far we lived from the scripted that the kernel generates, and those
have much higher commonality. But they likely miss some useful bits.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux