From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6755821036247187456 X-Received: by 2002:a2e:9b89:: with SMTP id z9mr16441032lji.185.1572985444097; Tue, 05 Nov 2019 12:24:04 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:1d6:: with SMTP id 205ls1735816lfb.4.gmail; Tue, 05 Nov 2019 12:24:03 -0800 (PST) X-Google-Smtp-Source: APXvYqzjgl2cGnOPEInUlpLo7CpnBo/8qw2jiAvbfqIdD+J8d4rqXJwVeBOEov7XIpWncv2gfEwD X-Received: by 2002:a19:4b4f:: with SMTP id y76mr21951463lfa.102.1572985443304; Tue, 05 Nov 2019 12:24:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572985443; cv=none; d=google.com; s=arc-20160816; b=eAPea9QHdVPcqguKA09woztJe4CUfD+oh/5Q6mlzHQdHp3Y0JETB+/TZ1ygBDArAOP qlOrVKCOWaMALAynVuAPnfLnB8he1Y7OnSxkj/dcUL5LIr25sFTSYklbJzgBOsODQ4hd Aa0In2xM8RMbB4Rd7E0D0Oh7tfi7R7xtaQz4UfUZAqmRy/4u07jKNblbibFLPufADmyg EKRTEu5+0hAE2kXeRWrI+qhy99YHS/bog+uybdfmxjw+Nb5kwBjb70RW+DQNyd7opiMp lNsAVZnjtdYp+GAqtK/ZNDZliuBd6x0IQOnbIYDNLdV7A0/41Old5FkLcdWcQ6Imur32 lBYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=pMR5HRSzuLZTBGdvcdCNWhDfhcOCrhl6Nxin3zGQ2nk=; b=te+Ib6ZAhQAD0zonKiZUqJ4cqnUEDR0D+58DV1VYs7hL6Msr7Z+auIVzNsxaJmC/hv c4H8iUcCN38MBZVowTfhdKwL30geHBc8VA5xVHEs0PEOsNJ3K1Ihs8LIL7V50/fKLl2y g/JJxQ4kbhcyR+ciJKzZbWRhEWqyIwo5JQQgpwqjzkw5VX19i6QnevFq8dhfrt/Y0vGt cysdJ7ktl0ew9YekKMEhqg7jRye80CVw/fUAQJph91RlcTOswK7jf1Q4Ts5uT/qfzuzv MmwYR8ClUeM/8eAdsDW9sm2MeAchaL2DxrGzGte7Ledw3p2xA7MszkJ3vOE8VLIDQmDi EUFQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id s4si1838486ljg.1.2019.11.05.12.24.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Nov 2019 12:24:03 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id xA5KO2A4012578 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Nov 2019 21:24:02 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id xA5KO2EA017434; Tue, 5 Nov 2019 21:24:02 +0100 Subject: Re: [PATCH 7/7] linux-custom: rewrite to no longer depend on the kernel's builddeb To: chombourger@gmail.com, isar-users References: <1572962145-318-1-git-send-email-Cedric_Hombourger@mentor.com> <1572962258-367-1-git-send-email-Cedric_Hombourger@mentor.com> <1572962258-367-3-git-send-email-Cedric_Hombourger@mentor.com> <8b757aec-9994-683d-8ac4-1c83718373ce@siemens.com> <6736dd6f-1a6f-4367-8fed-bdacc63ec2de@googlegroups.com> From: Jan Kiszka Message-ID: <7c20399d-aeb7-3c78-3e6e-666551d6fcda@siemens.com> Date: Tue, 5 Nov 2019 21:24:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <6736dd6f-1a6f-4367-8fed-bdacc63ec2de@googlegroups.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: nJqEX8JPyznD On 05.11.19 21:16, chombourger@gmail.com wrote: > On Tuesday, November 5, 2019 at 4:26:33 PM UTC+1, Jan Kiszka wrote: > > On 05.11.19 14:57, Cedric Hombourger wrote: > > diff --git > a/meta/recipes-kernel/linux/files/debian/linux-image.postrm.tmpl > b/meta/recipes-kernel/linux/files/debian/linux-image.postrm.tmpl > > new file mode 100644 > > index 0000000..9d88218 > > --- /dev/null > > +++ b/meta/recipes-kernel/linux/files/debian/linux-image.postrm.tmpl > > @@ -0,0 +1,18 @@ > > +#!/bin/sh > > +   > > +set -e > > + > > +rm -f /lib/modules/${PV}/.fresh-install > > + > > +if [ "$1" != upgrade ] && command -v linux-update-symlinks > >/dev/null; then > > +        linux-update-symlinks remove ${PV} > /boot/${KERNEL_FILE}-${PV} > > +fi > > + > > +# Pass maintainer script parameters to hook scripts > > +export DEB_MAINT_PARAMS="$*" > > + > > +# Tell initramfs builder whether it's wanted > > +export INITRD=Yes > > + > > +test -d /etc/kernel/postrm.d && run-parts --arg="${PV}" > --arg="/boot/${KERNEL_FILE}-${PV}" /etc/kernel/postrm.d > > +exit 0 > > diff --git a/meta/recipes-kernel/linux/files/debian/rules.tmpl > b/meta/recipes-kernel/linux/files/debian/rules.tmpl > > There is quite some duplication between postinst and postrm already. > Moreover, I think you are missing preinst and prerm. I think all four > should probably be generated from one template. > > > Ok I have checked upstream scripts and it seems that they all differ > see https://salsa.debian.org/kernel-team/linux/tree/master/debian/templates > > I would recommend we just copy over their scripts but use our templating > system instead of theirs > (use ${var} instead of @var@) >   Yes, seems reasonable. I checked but didn't spot anything that seems specific to their kernel. So far we lived from the scripted that the kernel generates, and those have much higher commonality. But they likely miss some useful bits. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux