From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6521574336665485312 X-Received: by 10.80.202.11 with SMTP id d11mr881116edi.9.1518549748818; Tue, 13 Feb 2018 11:22:28 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.171.6 with SMTP id s6ls8052202edc.2.gmail; Tue, 13 Feb 2018 11:22:28 -0800 (PST) X-Google-Smtp-Source: AH8x227eJ0BnA2MofKZqLQjl1/dwRi2cOAyQ7NYHSjSg9GbBFy+9RGLaBHE6/x0ejpDYsDa5kiGB X-Received: by 10.80.184.23 with SMTP id j23mr870356ede.3.1518549748017; Tue, 13 Feb 2018 11:22:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518549747; cv=none; d=google.com; s=arc-20160816; b=bbDcMUKpoaPNi1IDw4vxPv61G4mV1kW+slwYzaCFSvmQ0TmXSlWTjN7XCQ2wb1pTQW ktQ7i3el5XOPsdmY6XqB6c9BCiBoxmvpXm9pxuYd1VtwV1pk9fMkJmSDgCchjrWih/W7 c7pKSkiN9QYj4VkTwU8jiQiGm1eqsBxOoeR8rMVy5GvK7+FNMymr+AUwDZp1wifDOrfk uRVb5voIrblH+VqbeczYARzXSvr6zPy+cr7LSKJIcGJB9d+sh68TDQAat/fPMQX8GLND h9+DUc5jO5iXHgQIBa2cjoZ9bxc9gggNF0TWMy90pIUqLhnNbSUa342b9Mk+nfLqHAtU D04g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=5QQYTUIDRosLv0kmt4P8oK4dtOViwQHQu0vf2Cu7bEA=; b=SMZ2oKqIkfVx8KgUVRGl8HbNjDWZU9Z1azrGnMTeXE+ys5kk1hy2CvbchBaHsGq/Tm SrAsVYcL9NPPAF+0dqtRWBWZ1ypgSenFsUjmoi1qVn4B50fMl5/YprhzEKF3gW/FetuA Rdce1kVOC9584ceAGW5/bKg5MvRyX+DA4fbpl4UhI5AK3OVak5lcLI5g3/ciqtHF4a7+ +tEPXWIlTa4o3z5m8nE1A8FPSVLhINvVXMdcPdFJ0ilxZgNZpnPbtxj2dPYogFFr10Yd XuwscXiVMQhesPrSZwDNmiJIxLQB7AvYnU8YjALNPT3uUidiwOuwLH/ZrhZN6V5Sv5tN rhsg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id m19si744265edd.4.2018.02.13.11.22.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 11:22:27 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w1DJMRpb011944 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Feb 2018 20:22:27 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w1DJMRKg029501; Tue, 13 Feb 2018 20:22:27 +0100 Subject: Re: [PATCH 4/6] Enable proper rebuilds on dependency changes To: Alexander Smirnov , isar-users References: <7d0504da7640612abded5ffe1e1b3c6d10168b49.1518422347.git.jan.kiszka@siemens.com> <73bd323b-0dc2-a84a-ae5a-59177cfe6921@ilbers.de> <4b84a0e3-df9e-8343-ff09-7b74474a0e95@siemens.com> <20278b99-b41b-ee89-b5cd-eafc2019875d@siemens.com> From: Jan Kiszka Message-ID: <7c44164d-bae8-82d3-e9c3-bb60918bfd60@siemens.com> Date: Tue, 13 Feb 2018 20:22:26 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: y5OVl+RTguoW On 2018-02-13 20:02, Alexander Smirnov wrote: > > On 02/13/2018 09:44 PM, Jan Kiszka wrote: >> On 2018-02-13 19:08, Alexander Smirnov wrote: >>> On 02/13/2018 08:57 PM, Jan Kiszka wrote: >>>> On 2018-02-13 17:21, Jan Kiszka wrote: >>>>> On 2018-02-13 14:03, Alexander Smirnov wrote: >>>>>> On 02/12/2018 10:59 AM, Jan Kiszka wrote: >>>>>>> From: Jan Kiszka >>>>>>> >>>>>>> Install a basichash as signature handler and set the stamp policy to >>>>>>> full - and suddenly we get proper rebuilds of the image and all >>>>>>> affected >>>>>>> packages when some recipe down the dependency chain changed! >>>>>>> >>>>>>> We are using the legacy bitbake mechanism here as we do not have >>>>>>> setscene machinery like OE. Still good enough for us. >>>>>>> >>>>>> >>>>>> BTW: have you tried this? Two years ago I tried it in Yocto and it >>>>>> didn't work properly, not all the dependents were rebuilt. If it >>>>>> works, >>>>>> it's a very good feature! >>>>> >>>>> Yes, I'm using it since this weekend for both Isar as well as >>>>> jailhouse-images development, and it helped a lot already. The only >>>>> limitation I found, but I do not remember right now if that isn't >>>>> inherent to bitbake, is that it does not detect changes in files that >>>>> the recipes carries in its SRC_URI (file://...). Then you need "-c >>>>> clean" for the affected target - which now works as well. >>>>> >>>> >>>> Found another issue, which worked surprisingly well so far despite >>>> being >>>> fairly broken: do_setup_mounts is not re-run on rebuilds. >>> >>> Investigating exactly this issue. It occures for clean builds also. My >>> guess is patch #3, currently I'm building with only 2 first applied. >>> With 3rd one applied build failed. >>> >> >> That's not the right approach, the concept of the setup_mounts task is >> broken. > > Why you think it's broken? Just tested, it works good: It's broken in its design: you stamp a task and then remove that stamp again on restarts. That only works because we didn't generate the full dependency chain. Once you do, all dependent tasks we be kicked for re-run. Removing patch 3 is voodoo debugging. I bet you can't explain why that works around the issue, and I'm sure it will break eventually again. Moreover, it's needlessly complex. The much simpler solution is to try-mount when needed, at user side. Patch will follow, likely by resending the whole series Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux